[v8-dev] Re: [turbofan] Greedy: split around calls heuristic. (issue 1328783002 by mtro...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 3 (id:??) landed as https://crrev.com/db646fb2f88cb30042a8bc79281e129f4ce36de0 Cr-Commit-Position: refs/heads/master@{#30579} https://codereview.chromium.org/1328783002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [turbofan] Greedy: split around calls heuristic. (issue 1328783002 by mtro...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #3 (id:40001) https://codereview.chromium.org/1328783002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: [turbofan] Greedy: split around calls heuristic. (issue 1328783002 by mtro...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328783002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328783002/40001 https://codereview.chromium.org/1328783002/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: [turbofan] Greedy: split around calls heuristic. (issue 1328783002 by mtro...@chromium.org)

2015-09-03 Thread jarin
lgtm https://codereview.chromium.org/1328783002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] [turbofan] Greedy: split around calls heuristic. (issue 1328783002 by mtro...@chromium.org)

2015-09-03 Thread mtrofin
Reviewers: Jarin, Benedikt Meurer, Description: [turbofan] Greedy: split around calls heuristic. Once a range is found to have a conflict, split around all the calls it crosses over, since it will anyway have conflicts there, too. Please review this at https://codereview.chromium.org/132878300

[v8-dev] Re: Update V8 DEPS. (issue 1305273008 by v8-autor...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1305273008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Update V8 DEPS. (issue 1305273008 by v8-autor...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/9be35adeb7a47ee3dfee0d82323d14908f88ba34 Cr-Commit-Position: refs/heads/master@{#30578} https://codereview.chromium.org/1305273008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Update V8 DEPS. (issue 1305273008 by v8-autor...@chromium.org)

2015-09-03 Thread v8-autor...@chromium.org via codereview.chromium.org
Reviewers: Hablich, Michael Achenbach, vogelheim, Description: Update V8 DEPS. Rolling v8/build/gyp to 2b17e0b26a93e8c9758c23aec6c554da4ca8f0a9 TBR=machenb...@chromium.org,vogelh...@chromium.org,habl...@chromium.org Please review this at https://codereview.chromium.org/1305273008/ Base URL: h

[v8-dev] Re: Update V8 DEPS. (issue 1305273008 by v8-autor...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305273008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305273008/1 https://codereview.chromium.org/1305273008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: [heap] introduce ArrayBufferTracker (issue 1324023007 by fe...@indutny.com)

2015-09-03 Thread fedor
And I have just split out the implementation, as you requested https://codereview.chromium.org/1324023007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: [heap] introduce ArrayBufferTracker (issue 1324023007 by fe...@indutny.com)

2015-09-03 Thread fedor
On a completely unrelated note. Do you think that the way ArrayBuffers are managed right now is faster than the way External strings are? The strings appears to be living in the table (list), and this list is iterated on GC, freeing the items that have not been marked. The arraybuffers live i

[v8-dev] Re: AIX: Fix 'may be used uninitialized' compiler errors (issue 1323313003 by mbra...@us.ibm.com)

2015-09-03 Thread michael_dawson
On 2015/09/03 22:19:12, mtbrandyberry wrote: lgtm https://codereview.chromium.org/1323313003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe fr

[v8-dev] Re: PPC: Remove obsolete functionality from the MacroAssemblers. (issue 1311123004 by mbra...@us.ibm.com)

2015-09-03 Thread joransiu
lgtm https://codereview.chromium.org/1311123004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] PPC: Remove obsolete functionality from the MacroAssemblers. (issue 1311123004 by mbra...@us.ibm.com)

2015-09-03 Thread mbrandy
Reviewers: Benedikt Meurer, dstence, joransiu, john.yan, michael_dawson, Description: PPC: Remove obsolete functionality from the MacroAssemblers. Port 64e3bad3677d01d70ddcedd541619216b973e90d Original commit message: This is uncontroversial the dead code removal part of https://coderev

[v8-dev] Re: Speedup stringsearch for two byte strings (issue 1303033012 by k...@skomski.com)

2015-09-03 Thread karl
On 2015/09/03 16:46:33, Jakob wrote: https://codereview.chromium.org/1303033012/diff/1/src/string-search.h File src/string-search.h (left): https://codereview.chromium.org/1303033012/diff/1/src/string-search.h#oldcode196 src/string-search.h:196: nit: keep this line https://codereview.chrom

[v8-dev] AIX: Fix 'may be used uninitialized' compiler errors (issue 1323313003 by mbra...@us.ibm.com)

2015-09-03 Thread mbrandy
Reviewers: danno, michael_dawson, Description: AIX: Fix 'may be used uninitialized' compiler errors Fix additional cases where the AIX compiler reports that a variable may be used uninitialized. R=da...@chromium.org, michael_daw...@ca.ibm.com BUG= Please review this at https://codereview.chrom

[v8-dev] Re: Issue 4406 in v8: profiler has huge impact on performance for some code (mac)

2015-09-03 Thread codesite-noreply via v8-dev
Comment #5 on issue 4406 by rsturg...@google.com: profiler has huge impact on performance for some code (mac) https://code.google.com/p/v8/issues/detail?id=4406 Looks like it's an issue with use of AVX instructions on these machines. If I run with --noenable_avx there is no slowdown while pr

[v8-dev] Re: Remove obsolete functionality from the MacroAssemblers. (issue 1322843005 by bmeu...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 2 (id:??) landed as https://crrev.com/64e3bad3677d01d70ddcedd541619216b973e90d Cr-Commit-Position: refs/heads/master@{#30577} https://codereview.chromium.org/1322843005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Remove obsolete functionality from the MacroAssemblers. (issue 1322843005 by bmeu...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #2 (id:20001) https://codereview.chromium.org/1322843005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Remove obsolete functionality from the MacroAssemblers. (issue 1322843005 by bmeu...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322843005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322843005/20001 https://codereview.chromium.org/1322843005/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: [es6] parse destructuring assignment (issue 1309813007 by caitpotte...@gmail.com)

2015-09-03 Thread caitpotter88
On 2015/08/31 13:43:34, conradw wrote: On 2015/08/31 13:13:30, wingo wrote: > On 2015/08/31 11:22:53, conradw wrote: > > On 2015/08/28 09:54:13, wingo wrote: > > > > https://codereview.chromium.org/1309813007/diff/1/src/expression-classifier.h > > > File src/expression-classifier.h (right): > >

[v8-dev] Re: Remove obsolete functionality from the MacroAssemblers. (issue 1322843005 by bmeu...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/9333) https://codereview.chromium.org/1322843005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/

[v8-dev] Remove obsolete functionality from the MacroAssemblers. (issue 1322843005 by bmeu...@chromium.org)

2015-09-03 Thread bmeurer
Reviewers: Jakob, Message: Hey Jakob, Landing this independently of the ClassOf change. TBR'ed as you already liked the change :-) Benedikt Description: Remove obsolete functionality from the MacroAssemblers. This is uncontroversial the dead code removal part of https://codereview.chromium

[v8-dev] Re: Remove obsolete functionality from the MacroAssemblers. (issue 1322843005 by bmeu...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322843005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322843005/1 https://codereview.chromium.org/1322843005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: PPC: [es6] Initial steps towards a correct implementation of IsCallable. (issue 1330613005 by mbra...@us.ibm.com)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/6990fb1c19f6bd14895475d5081fccfc9ccfe750 Cr-Commit-Position: refs/heads/master@{#30576} https://codereview.chromium.org/1330613005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: PPC: [es6] Initial steps towards a correct implementation of IsCallable. (issue 1330613005 by mbra...@us.ibm.com)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1330613005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Version 4.6.85.13 (cherry-pick) (issue 1308703013 by ofrob...@google.com)

2015-09-03 Thread bmeurer
lgtm https://codereview.chromium.org/1308703013/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Issue 2700 in v8: Implement arrow functions

2015-09-03 Thread codesite-noreply via v8-dev
Comment #61 on issue 2700 by bugdro...@chromium.org: Implement arrow functions https://code.google.com/p/v8/issues/detail?id=2700#c61 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/9628d86085ddee83067c45046ed89e0e6f635d3f commit 9628d86085ddee83

[v8-dev] Re: Version 4.6.85.13 (cherry-pick) (issue 1308703013 by ofrob...@google.com)

2015-09-03 Thread hablich
On 2015/09/03 18:39:38, ofrobots wrote: lgtm https://codereview.chromium.org/1308703013/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from th

[v8-dev] Re: PPC: [es6] Introduce a dedicated JSIteratorResult type. (issue 1325203004 by mbra...@us.ibm.com)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1325203004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: PPC: [es6] Introduce a dedicated JSIteratorResult type. (issue 1325203004 by mbra...@us.ibm.com)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/fdbccd64f7054f8a3328311f036e4f59a1b52131 Cr-Commit-Position: refs/heads/master@{#30575} https://codereview.chromium.org/1325203004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Issue 2160 in v8: Add support for default parameters

2015-09-03 Thread codesite-noreply via v8-dev
Comment #18 on issue 2160 by bugdro...@chromium.org: Add support for default parameters https://code.google.com/p/v8/issues/detail?id=2160#c18 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/9628d86085ddee83067c45046ed89e0e6f635d3f commit 9628d86

[v8-dev] Re: PPC: [es6] Re-implement rest parameters via desugaring. (issue 1318523006 by mbra...@us.ibm.com)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/9628d86085ddee83067c45046ed89e0e6f635d3f Cr-Commit-Position: refs/heads/master@{#30574} https://codereview.chromium.org/1318523006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: PPC: [es6] Re-implement rest parameters via desugaring. (issue 1318523006 by mbra...@us.ibm.com)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1318523006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Version 4.6.85.13 (cherry-pick) (issue 1308703013 by ofrob...@google.com)

2015-09-03 Thread ofrob...@google.com via codereview.chromium.org
Reviewers: Benedikt Meurer, Description: Version 4.6.85.13 (cherry-pick) Merged 5434d052f138adc0933c20ad24cc3d84555be53d fix gen-postmortem-metadata.py for kInObjectPropertiesOffset R=bmeu...@chromium.org BUG=v8:4411 Please review this at https://codereview.chromium.org/1308703013/ Base URL:

[v8-dev] Re: [es5] Class of object is "Function" if object has [[Call]]. (issue 1307943013 by bmeu...@chromium.org)

2015-09-03 Thread bmeurer
On 2015/09/03 15:02:09, Michael Achenbach wrote: A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1306303005/ by mailto:machenb...@chromium.org. The reason for reverting is: [Sheriff] Changes several layout test expectations. Please fix upstrea

[v8-dev] Re: PPC: [es6] Introduce a dedicated JSIteratorResult type. (issue 1325203004 by mbra...@us.ibm.com)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325203004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325203004/1 https://codereview.chromium.org/1325203004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: PPC: [es6] Re-implement rest parameters via desugaring. (issue 1318523006 by mbra...@us.ibm.com)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318523006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318523006/1 https://codereview.chromium.org/1318523006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: PPC: [es6] Initial steps towards a correct implementation of IsCallable. (issue 1330613005 by mbra...@us.ibm.com)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330613005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330613005/1 https://codereview.chromium.org/1330613005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: PPC: [es6] Introduce a dedicated JSIteratorResult type. (issue 1325203004 by mbra...@us.ibm.com)

2015-09-03 Thread dstence
lgtm https://codereview.chromium.org/1325203004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: PPC: [es6] Initial steps towards a correct implementation of IsCallable. (issue 1330613005 by mbra...@us.ibm.com)

2015-09-03 Thread dstence
lgtm https://codereview.chromium.org/1330613005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: PPC: [es6] Re-implement rest parameters via desugaring. (issue 1318523006 by mbra...@us.ibm.com)

2015-09-03 Thread dstence
lgtm https://codereview.chromium.org/1318523006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [Tick processor] Add an option to the tick-processor to print the summary. (issue 1318933004 by gdee...@google.com)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 2 (id:??) landed as https://crrev.com/e1f38de76a758f8640685f5b3afc0d153f0abd86 Cr-Commit-Position: refs/heads/master@{#30573} https://codereview.chromium.org/1318933004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [Tick processor] Add an option to the tick-processor to print the summary. (issue 1318933004 by gdee...@google.com)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #2 (id:20001) https://codereview.chromium.org/1318933004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: [Tick processor] Add an option to the tick-processor to print the summary. (issue 1318933004 by gdee...@google.com)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318933004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318933004/20001 https://codereview.chromium.org/1318933004/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: MIPS: Refine '[es6] Introduce a dedicated JSIteratorResult type.' (issue 1315903005 by balazs.kilv...@imgtec.com)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/29a2e8f861bdb1be40704205027becac1c4e72e5 Cr-Commit-Position: refs/heads/master@{#30572} https://codereview.chromium.org/1315903005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: MIPS: Refine '[es6] Introduce a dedicated JSIteratorResult type.' (issue 1315903005 by balazs.kilv...@imgtec.com)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1315903005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: [Tick processor] Add an option to the tick-processor to print the summary. (issue 1318933004 by gdee...@google.com)

2015-09-03 Thread gdeepti via v8-dev
https://codereview.chromium.org/1318933004/diff/1/tools/tickprocessor.js File tools/tickprocessor.js (right): https://codereview.chromium.org/1318933004/diff/1/tools/tickprocessor.js#newcode461 tools/tickprocessor.js:461: var printAllTicks = this.printSummary_ == undefined || On 2015/09/03 08:37

[v8-dev] Re: Revert of Vector ICs: platform support for vector-based stores. (issue 1303053004 by machenb...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/d51c588524a2255d7c7b4f7aecab2c5a055f4e1b Cr-Commit-Position: refs/heads/master@{#30571} https://codereview.chromium.org/1303053004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Revert of Vector ICs: platform support for vector-based stores. (issue 1303053004 by machenb...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1303053004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Revert of Vector ICs: platform support for vector-based stores. (issue 1303053004 by machenb...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303053004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303053004/1 https://codereview.chromium.org/1303053004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: Vector ICs: platform support for vector-based stores. (issue 1328603003 by mvstan...@chromium.org)

2015-09-03 Thread machenbach
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.chromium.org/1303053004/ by machenb...@chromium.org. The reason for reverting is: [Sheriff] Breaks compile on arm: http://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20builder/builds/6590. https://coderev

[v8-dev] Revert of Vector ICs: platform support for vector-based stores. (issue 1303053004 by machenb...@chromium.org)

2015-09-03 Thread machenbach
Reviewers: Benedikt Meurer, Jakob, mvstanton, Message: Created Revert of Vector ICs: platform support for vector-based stores. Description: Revert of Vector ICs: platform support for vector-based stores. (patchset #7 id:120001 of https://codereview.chromium.org/1328603003/ ) Reason for revert:

[v8-dev] Re: MIPS: Refine '[es6] Introduce a dedicated JSIteratorResult type.' (issue 1315903005 by balazs.kilv...@imgtec.com)

2015-09-03 Thread bmeurer
FYI, for Benedikt and v8 team, LoadRoot() is preferred over li() where possible, since it is one instruction vs two. MIPS64 ABI (n64) has 8 argument registers rather than the 4 on MIPS32 ABI, and the "conventional names" for registers 4 thru 15 were therefore changed from [a0-a3][t0-t7] to

[v8-dev] Re: Issue 4411 in v8: post-mortem metadata generator fails to build on V8 4.6+ (merge request)

2015-09-03 Thread codesite-noreply via v8-dev
Updates: Status: Assigned Owner: habl...@chromium.org Cc: bmeu...@chromium.org Labels: Type-Bug Priority-Medium Component-Build merge-approved-4.6 Comment #1 on issue 4411 by habl...@chromium.org: post-mortem metadata generator fails to build on V8 4.6+ (merge re

[v8-dev] Re: Issue 3589 in v8: Add support for float32 to TurboFan

2015-09-03 Thread codesite-noreply via v8-dev
Updates: Owner: ja...@chromium.org Comment #10 on issue 3589 by bmeu...@chromium.org: Add support for float32 to TurboFan https://code.google.com/p/v8/issues/detail?id=3589 The backend part is (mostly) done. Matter of adding support to the type system and representation analysis.

[v8-dev] Issue 4411 in v8: post-mortem metadata generator fails to build on V8 4.6+ (merge request)

2015-09-03 Thread codesite-noreply via v8-dev
Status: Untriaged Owner: New issue 4411 by ofrob...@google.com: post-mortem metadata generator fails to build on V8 4.6+ (merge request) https://code.google.com/p/v8/issues/detail?id=4411 Merge request for 4.6. Fix already landed on master as: https://chromium.googlesource.com/v8/v8/+/

[v8-dev] Re: Vector ICs: platform support for vector-based stores. (issue 1328603003 by mvstan...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 7 (id:??) landed as https://crrev.com/63af1b3aec6547e7cdf502666ff79c562de8b679 Cr-Commit-Position: refs/heads/master@{#30570} https://codereview.chromium.org/1328603003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Vector ICs: platform support for vector-based stores. (issue 1328603003 by mvstan...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #7 (id:120001) https://codereview.chromium.org/1328603003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: PPC: [es6] Re-implement rest parameters via desugaring. (issue 1318523006 by mbra...@us.ibm.com)

2015-09-03 Thread caitpotter88
Non-owner LGTM https://codereview.chromium.org/1318523006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving ema

[v8-dev] Re: MIPS: Refine '[es6] Introduce a dedicated JSIteratorResult type.' (issue 1315903005 by balazs.kilv...@imgtec.com)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315903005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315903005/1 https://codereview.chromium.org/1315903005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: Vector ICs: platform support for vector-based stores. (issue 1328603003 by mvstan...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328603003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328603003/120001 https://codereview.chromium.org/1328603003/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Speedup stringsearch for two byte strings (issue 1303033012 by k...@skomski.com)

2015-09-03 Thread jkummerow
https://codereview.chromium.org/1303033012/diff/1/src/string-search.h File src/string-search.h (left): https://codereview.chromium.org/1303033012/diff/1/src/string-search.h#oldcode196 src/string-search.h:196: nit: keep this line https://codereview.chromium.org/1303033012/diff/1/src/string-searc

[v8-dev] Re: MIPS: Refine '[es6] Introduce a dedicated JSIteratorResult type.' (issue 1315903005 by balazs.kilv...@imgtec.com)

2015-09-03 Thread paul . lind
LGTM. FYI, for Benedikt and v8 team, LoadRoot() is preferred over li() where possible, since it is one instruction vs two. MIPS64 ABI (n64) has 8 argument registers rather than the 4 on MIPS32 ABI, and the "conventional names" for registers 4 thru 15 were therefore changed from [a0-a3][t0-

[v8-dev] PPC: [es6] Introduce a dedicated JSIteratorResult type. (issue 1325203004 by mbra...@us.ibm.com)

2015-09-03 Thread mbrandy
Reviewers: Benedikt Meurer, dstence, joransiu, john.yan, michael_dawson, Description: PPC: [es6] Introduce a dedicated JSIteratorResult type. Port 72bc4b5c8a5c4279bcb8b340edbc8aa1c46d75a1 Original commit message: Use a single JSIteratorResult type for all implementation provided iterato

[v8-dev] PPC: [es6] Initial steps towards a correct implementation of IsCallable. (issue 1330613005 by mbra...@us.ibm.com)

2015-09-03 Thread mbrandy
Reviewers: Benedikt Meurer, dstence, joransiu, john.yan, michael_dawson, Description: PPC: [es6] Initial steps towards a correct implementation of IsCallable. Port 8a378f46d52ce64578c71313ed76a67592fbf63c Original commit message: This turns the has_instance_call_handler bit on Map into an i

[v8-dev] PPC: [es6] Re-implement rest parameters via desugaring. (issue 1318523006 by mbra...@us.ibm.com)

2015-09-03 Thread mbrandy
Reviewers: caitp, dstence, joransiu, john.yan, michael_dawson, Description: PPC: [es6] Re-implement rest parameters via desugaring. Port 510baeacbab311798d5e8795800ff773d00d062c Original commit message: Kills the kRestParameter bailout/disabled optimization, and fixes lazily parsed arro

[v8-dev] [es6] Use SubString in String{Starts,Ends}With (issue 1321853006 by k...@skomski.com)

2015-09-03 Thread karl
Reviewers: Dan Ehrenberg, Description: [es6] Use SubString in String{Starts,Ends}With Much faster and constant than always searching the whole string var allCodePoints = []; for (var i = 0; i < 65536; i++) allCodePoints[i] = i; var allCharsString = String.fromCharCode.apply(String, allCode

[v8-dev] Re: Vector ICs: platform support for vector-based stores. (issue 1328603003 by mvstan...@chromium.org)

2015-09-03 Thread jkummerow
lgtm https://codereview.chromium.org/1328603003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] MIPS: Refine '[es6] Introduce a dedicated JSIteratorResult type.' (issue 1315903005 by balazs.kilv...@imgtec.com)

2015-09-03 Thread balazs . kilvady
Reviewers: danno, Benedikt Meurer, paul.l..., akos.palfi.imgtec, Description: MIPS: Refine '[es6] Introduce a dedicated JSIteratorResult type.' Port 72bc4b5c8a5c4279bcb8b340edbc8aa1c46d75a1 Original commit message: Use a single JSIteratorResult type for all implementation provided iterator resu

[v8-dev] Re: Reland "Make sure that memory reducer makes progress in incremental marking"" (issue 1311993003 by u...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #5 (id:80001) https://codereview.chromium.org/1311993003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Reland "Make sure that memory reducer makes progress in incremental marking"" (issue 1311993003 by u...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 5 (id:??) landed as https://crrev.com/69bb3e1f1fcf449c95619d9dd1baa883c7cb51ad Cr-Commit-Position: refs/heads/master@{#30569} https://codereview.chromium.org/1311993003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Vector ICs: platform support for vector-based stores. (issue 1328603003 by mvstan...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328603003/11 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328603003/11 https://codereview.chromium.org/1328603003/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Vector ICs: platform support for vector-based stores. (issue 1328603003 by mvstan...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-

[v8-dev] Re: Vector ICs: platform support for vector-based stores. (issue 1328603003 by mvstan...@chromium.org)

2015-09-03 Thread mvstanton
Thanks all! https://codereview.chromium.org/1328603003/diff/40001/src/ast.cc File src/ast.cc (right): https://codereview.chromium.org/1328603003/diff/40001/src/ast.cc#newcode353 src/ast.cc:353: if (saw_computed_name && On 2015/09/03 11:27:39, Jakob wrote: This is surprising: having seen a comp

[v8-dev] Re: Reland "Make sure that memory reducer makes progress in incremental marking"" (issue 1311993003 by u...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311993003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311993003/80001 https://codereview.chromium.org/1311993003/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: Reland "Make sure that memory reducer makes progress in incremental marking"" (issue 1311993003 by u...@chromium.org)

2015-09-03 Thread ulan via v8-dev
Thanks! https://codereview.chromium.org/1311993003/diff/60001/src/heap/heap.h File src/heap/heap.h (right): https://codereview.chromium.org/1311993003/diff/60001/src/heap/heap.h#newcode843 src/heap/heap.h:843: void FinalizeIncrementalMarkingIfComplete(const char* comment); On 2015/09/03 15:01:4

[v8-dev] Re: Revert of [es5] Class of object is "Function" if object has [[Call]]. (issue 1306303005 by machenb...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/c340548979e51cb0bd5d8021165b1becc5875507 Cr-Commit-Position: refs/heads/master@{#30568} https://codereview.chromium.org/1306303005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Revert of [es5] Class of object is "Function" if object has [[Call]]. (issue 1306303005 by machenb...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1306303005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Revert of [es5] Class of object is "Function" if object has [[Call]]. (issue 1306303005 by machenb...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306303005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306303005/1 https://codereview.chromium.org/1306303005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Revert of [es5] Class of object is "Function" if object has [[Call]]. (issue 1306303005 by machenb...@chromium.org)

2015-09-03 Thread machenbach
Reviewers: Jarin, Jakob, Benedikt Meurer, Message: Created Revert of [es5] Class of object is "Function" if object has [[Call]]. Description: Revert of [es5] Class of object is "Function" if object has [[Call]]. (patchset #3 id:40001 of https://codereview.chromium.org/1307943013/ ) Reason

[v8-dev] Re: [es5] Class of object is "Function" if object has [[Call]]. (issue 1307943013 by bmeu...@chromium.org)

2015-09-03 Thread machenbach
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1306303005/ by machenb...@chromium.org. The reason for reverting is: [Sheriff] Changes several layout test expectations. Please fix upstream first if intended. E.g.: https://build.chromium.org/p/clie

[v8-dev] Re: Reland "Make sure that memory reducer makes progress in incremental marking"" (issue 1311993003 by u...@chromium.org)

2015-09-03 Thread mlippautz
lgtm, thanks for fixing this immediately :) https://codereview.chromium.org/1311993003/diff/60001/src/heap/heap.h File src/heap/heap.h (right): https://codereview.chromium.org/1311993003/diff/60001/src/heap/heap.h#newcode843 src/heap/heap.h:843: void FinalizeIncrementalMarkingIfComplete(const c

[v8-dev] Reland "Make sure that memory reducer makes progress in incremental marking"" (issue 1311993003 by u...@chromium.org)

2015-09-03 Thread ulan via v8-dev
PTAL. The patch set 1 contains the original CL + DCHECK in incremenal-marking + regression test. The patch set 2 contains the actual fix. https://codereview.chromium.org/1311993003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Issue 4408 in v8: Tagbot for non-master branches

2015-09-03 Thread codesite-noreply via v8-dev
Comment #2 on issue 4408 by bugdro...@chromium.org: Tagbot for non-master branches https://code.google.com/p/v8/issues/detail?id=4408#c2 The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/e063c3673454963fb7f2f2b1e372378fefd5c5ed commi

[v8-dev] Re: Reland Automatically download gold plugin for cfi builds. (issue 1330623002 by machenb...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/589a095200779c564ac2a027233c515285ff5e00 Cr-Commit-Position: refs/heads/master@{#30567} https://codereview.chromium.org/1330623002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Reland Automatically download gold plugin for cfi builds. (issue 1330623002 by machenb...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1330623002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: [es5] Class of object is "Function" if object has [[Call]]. (issue 1307943013 by bmeu...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 3 (id:??) landed as https://crrev.com/af778389947f1b01fb036756ea3cb8ed8ab98452 Cr-Commit-Position: refs/heads/master@{#30566} https://codereview.chromium.org/1307943013/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [es5] Class of object is "Function" if object has [[Call]]. (issue 1307943013 by bmeu...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #3 (id:40001) https://codereview.chromium.org/1307943013/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: [turbofan] Do not force stack slot for eager deopt inputs. (issue 1307203005 by ja...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 3 (id:??) landed as https://crrev.com/6893da537769a28806d99c195b710b9ad8c4280d Cr-Commit-Position: refs/heads/master@{#30565} https://codereview.chromium.org/1307203005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Reland Automatically download gold plugin for cfi builds. (issue 1330623002 by machenb...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330623002/1 https://codereview.chromium.org/1330623002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: [turbofan] Do not force stack slot for eager deopt inputs. (issue 1307203005 by ja...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #3 (id:40001) https://codereview.chromium.org/1307203005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Include individual deferred block ranges in splintering. (issue 1322703003 by mtro...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/5fc253a8057f65fa6866cc03bd116a4e76ed214d Cr-Commit-Position: refs/heads/master@{#30564} https://codereview.chromium.org/1322703003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Include individual deferred block ranges in splintering. (issue 1322703003 by mtro...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1322703003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Include individual deferred block ranges in splintering. (issue 1322703003 by mtro...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322703003/1 https://codereview.chromium.org/1322703003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: Include individual deferred block ranges in splintering. (issue 1322703003 by mtro...@chromium.org)

2015-09-03 Thread jarin
lgtm https://codereview.chromium.org/1322703003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [heap] Make AlwaysAllocateScope thread-safe. (issue 1325173003 by mlippa...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 3 (id:??) landed as https://crrev.com/296db16e6fe33369100c6771e430b94568c6ab4a Cr-Commit-Position: refs/heads/master@{#30563} https://codereview.chromium.org/1325173003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [heap] Make AlwaysAllocateScope thread-safe. (issue 1325173003 by mlippa...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #3 (id:40001) https://codereview.chromium.org/1325173003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: [heap] Make AlwaysAllocateScope thread-safe. (issue 1325173003 by mlippa...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325173003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325173003/40001 https://codereview.chromium.org/1325173003/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: [turbofan] Do not force stack slot for eager deopt inputs. (issue 1307203005 by ja...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307203005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307203005/40001 https://codereview.chromium.org/1307203005/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

  1   2   >