Hey Jaro,
Can you take a look at the x64 port before I start porting that over to
everything else?
Thanks,
Benedikt
https://codereview.chromium.org/1311013008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm % 1 comment.
https://codereview.chromium.org/1324023007/diff/60001/src/heap/array-buffer-tracker.cc
File src/heap/array-buffer-tracker.cc (right):
https://codereview.chromium.org/1324023007/diff/60001/src/heap/array-buffer-tracker.cc#newcode132
src/heap/array-buffer-tracker.cc:132:
reinter
PTAL
https://codereview.chromium.org/1307743011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Just two very early comments, and one question:
You mentioned that it should be possible to write certain bytecode handlers
as
native builtins. How about doing that for the call opcode? Because that
seems
like a lot of machinery in TurboFan to support this very special opcode.
https://coder
+mstarzinger
+jarin
https://codereview.chromium.org/1323463005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivin
lgtm
https://codereview.chromium.org/1296743003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1328083002/diff/80001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1328083002/diff/80001/src/preparser.h#newcode2614
src/preparser.h:2614: if (!in_class && !is_generator) {
I reorganized ParsePropertyDefinition because it was getti
Reviewers: rossberg, wingo, adamk (ooo until sept 8), aperez,
Message:
PTAL, quick bugfix for reported issue with shorthand properties. Super
simple
stuff.
Description:
[es6] support `get` and `set` in shorthand properties
Add support for `get` and `set` as shorthand properties. Also
support
Updates:
Status: Started
Owner: caitpott...@gmail.com
Labels: Type-Bug Harmony Priority-Medium
Comment #1 on issue 4412 by caitpott...@gmail.com: Shorthand property name
`get` and `set` throws SyntaxError
https://code.google.com/p/v8/issues/detail?id=4412
(No comment w
Status: Untriaged
Owner:
New issue 4412 by taken@gmail.com: Shorthand property name `get` and
`set` throws SyntaxError
https://code.google.com/p/v8/issues/detail?id=4412
Version: 4.7.31
OS: Windwos 7 64 bit
Architecture: x64
What steps will reproduce the problem?
1. Use get in the o
Comment #11 on issue 1239 by erig...@google.com: ES5 getter/setter
performance
https://code.google.com/p/v8/issues/detail?id=1239
On both Chrome 45 and on Chrome 47 canary, on that jsperf page I see
Uncaught TypeError: Cannot read property 'name' of undefined.
message: Uncaught TypeError
Patchset 3 (id:??) landed as
https://crrev.com/49a40c220361aa9a62a2cd66100e9b3714135f48
Cr-Commit-Position: refs/heads/master@{#30604}
https://codereview.chromium.org/1326173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1326173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1326173002/40001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1326173002/40001
https://codereview.chromium.org/1326173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
ht
Reviewers: Weiliang,
Message:
PTAL
Description:
X87: [runtime] Remove useless IN builtin.
port 3dc9b122fa9f7d551e05f5b9d7415bcfdcac92db (r30582).
original commit message:
Similar to DELETE, the IN builtin is just a thin wrapper for %HasElement
and %HasProperty anyway, and cannot be op
Reviewers: Weiliang,
Message:
PTAL
Description:
X87: Reland Vector ICs: platform support for vector-based stores.
port 40fbed0609ddb3e4ee4338049383004b62d13853 (r30581)
original commit message:
The last changes for vector store functionality, they are in 3 areas:
1) The new vector [k
Reviewers: Weiliang,
Message:
PTAL
Description:
X87: Remove obsolete functionality from the MacroAssemblers.
port 64e3bad3677d01d70ddcedd541619216b973e90d (r30577)
original commit message:
This is uncontroversial the dead code removal part of
https://codereview.chromium.org/1307943013
Reviewers: Weiliang,
Message:
PTAL
Description:
X87: [es6] Introduce a dedicated JSIteratorResult type.
port 72bc4b5c8a5c4279bcb8b340edbc8aa1c46d75a1 (r30557)
original commit message:
Use a single JSIteratorResult type for all implementation provided
iterator results (i.e. the String,
Reviewers: Weiliang,
Message:
PTAL
Description:
X87: [es6] Initial steps towards a correct implementation of IsCallable.
port 8a378f46d52ce64578c71313ed76a67592fbf63c (r30552)
original commit message:
This turns the has_instance_call_handler bit on Map into an is_callable
bit, that ma
Reviewers: Weiliang,
Message:
PTAL
Description:
X87: [es6] Re-implement rest parameters via desugaring.
port 510baeacbab311798d5e8795800ff773d00d062c (r30550)
original commit message:
Kills the kRestParameter bailout/disabled optimization, and fixes
lazily parsed arrow functions with
Reviewers: Weiliang,
Message:
PTAL
Description:
X87: Crankshaft is now able to compile top level code even if there is a
ScriptContext.
port 29ebcc32052d486cbc1933ac4738aa5cb68aa851 (r30496).
original commit message:
This CL introduces HPrologue instruction which does the context
alloca
Reviewers: Weiliang,
Message:
PTAL
Description:
X87: [builtins] Pass correct number of arguments after adapting arguments.
port fbad63669e309e8c5c3f2ecf503df2fefaac79bb (r30467)
original commit message:
The call protocol requires that the register dedicated to the number of
actual arg
Comment #10 on issue 1239 by m93a...@gmail.com: ES5 getter/setter
performance
https://code.google.com/p/v8/issues/detail?id=1239
It seems that Chrome is slow when dealing with configurable getter/setter
properties – they are ~3 times slower than those unconfigurable. When
compared to Fire
23 matches
Mail list logo
