On 2015/09/09 at 23:35:56, info wrote:
https://codereview.chromium.org/1303093004/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/1303093004/diff/1/src/api.cc#newcode3271
src/api.cc:3271: has_pending_exception =
On 2015/09/09 14:16:59, jochen wrote:
> can you pull
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1202173002/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1202173002/20001
https://codereview.chromium.org/1202173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm
https://codereview.chromium.org/1202173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Try jobs failed on following builders:
v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/8021)
v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
PTAL
Updated CL with OrderedHashSet
https://codereview.chromium.org/1316213008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group
Please also add tests for this functionality.
https://codereview.chromium.org/1239803004/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1239803004/diff/20001/src/objects.cc#newcode2367
src/objects.cc:2367: if (!prev_object->IsUndefined()) {
How about
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1202173002/60001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1202173002/60001
https://codereview.chromium.org/1202173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1202173002/60001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1202173002/60001
https://codereview.chromium.org/1202173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
src/full-codegen/* LGTM.
https://codereview.chromium.org/1202173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1202173002/40001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1202173002/40001
https://codereview.chromium.org/1202173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Try jobs failed on following builders:
v8_linux64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/9756)
v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5838)
Try jobs failed on following builders:
v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5841)
https://codereview.chromium.org/1202173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
Committed patchset #4 (id:60001)
https://codereview.chromium.org/1202173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
On 2015/09/16 15:25:35, adamk wrote:
lgtm
Sorry for the delay, I was expecting a ping from your end when you
uploaded a
new patch.
My bad, maybe I'm too used to Bugzilla reporting uploaded attachments by
email
automatically, by default.
https://codereview.chromium.org/1328083002/
--
Patchset 4 (id:??) landed as
https://crrev.com/b5588f48fd0b4e3ee43be1fe6c19d7ddd8b8b5f1
Cr-Commit-Position: refs/heads/master@{#30767}
https://codereview.chromium.org/1202173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
On 2015/09/08 23:35:13, caitp wrote:
Sounds good to me. I'll have a patchset later tonight
https://codereview.chromium.org/1328083002/diff/40001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1328083002/diff/40001/src/preparser.h#newcode2663
lgtm
Sorry for the delay, I was expecting a ping from your end when you uploaded
a
new patch.
https://codereview.chromium.org/1328083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1328083002/160001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1328083002/160001
https://codereview.chromium.org/1328083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
On 2015/09/15 09:32:28, commit-bot: I haz the power wrote:
Try jobs failed on following builders:
v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5780)
The presubmit has been failing due to the lack of an owner LGTM for
LGTM (rubber-stamp for heap).
https://codereview.chromium.org/1309243003/diff/60001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/1309243003/diff/60001/src/bootstrapper.cc#newcode1857
src/bootstrapper.cc:1857: Handle flag(FLAG_harmony_tolength
?
Committed patchset #8 (id:160001)
https://codereview.chromium.org/1328083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group
Patchset 8 (id:??) landed as
https://crrev.com/b444da41ad9ef32cea08fd24fd89eab258cd1360
Cr-Commit-Position: refs/heads/master@{#30769}
https://codereview.chromium.org/1328083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
LGTM (rubber-stamp for heap).
https://codereview.chromium.org/1309243003/diff/60001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/1309243003/diff/60001/src/bootstrapper.cc#newcode1857
src/bootstrapper.cc:1857: Handle flag(FLAG_harmony_tolength
?
Patchset 5 (id:??) landed as
https://crrev.com/d4e1299f1686ff55f9425d6b322c194a1968fe3f
Cr-Commit-Position: refs/heads/master@{#30772}
https://codereview.chromium.org/1309243003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #5 (id:80001)
https://codereview.chromium.org/1309243003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 1 (id:??) landed as
https://crrev.com/007baaedd30fb506569b5f649eddd456197eecae
Cr-Commit-Position: refs/heads/master@{#30778}
https://codereview.chromium.org/1274453002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1274453002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1274453002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1274453002/1
https://codereview.chromium.org/1274453002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
https://codereview.chromium.org/1321543004/diff/40001/src/debug/debug.cc
File src/debug/debug.cc (right):
https://codereview.chromium.org/1321543004/diff/40001/src/debug/debug.cc#newcode2282
src/debug/debug.cc:2282: break_in_nondebuggable_))
On 2015/09/01 at 01:55:48, Yang OOO until mid October
https://codereview.chromium.org/1321543004/diff/80001/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (right):
https://codereview.chromium.org/1321543004/diff/80001/test/cctest/test-debug.cc#newcode7763
test/cctest/test-debug.cc:7763: const char* command_continue =
It sounds like Yang
https://codereview.chromium.org/1318713007/diff/20001/src/runtime/runtime-atomics.cc
File src/runtime/runtime-atomics.cc (right):
https://codereview.chromium.org/1318713007/diff/20001/src/runtime/runtime-atomics.cc#newcode490
src/runtime/runtime-atomics.cc:490: case kExternalFloat64Array:
On
Fixed nit. Let's land this for good :)
https://codereview.chromium.org/1309243003/diff/60001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/1309243003/diff/60001/src/bootstrapper.cc#newcode1857
src/bootstrapper.cc:1857: Handle flag(FLAG_harmony_tolength
?
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1309243003/80001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1309243003/80001
https://codereview.chromium.org/1309243003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
33 matches
Mail list logo
