[v8-dev] Re: improve allocation accounting for incremental mark (issue 1274453002 by ofrob...@google.com)

2015-09-16 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1274453002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: improve allocation accounting for incremental mark (issue 1274453002 by ofrob...@google.com)

2015-09-16 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/007baaedd30fb506569b5f649eddd456197eecae Cr-Commit-Position: refs/heads/master@{#30778} https://codereview.chromium.org/1274453002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: improve allocation accounting for incremental mark (issue 1274453002 by ofrob...@google.com)

2015-09-16 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274453002/1 https://codereview.chromium.org/1274453002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: ES6: Array.prototype.slice and friends should use ToLength instead of ToUint32 (issue 1309243003 by ape...@igalia.com)

2015-09-16 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #5 (id:80001) https://codereview.chromium.org/1309243003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: ES6: Array.prototype.slice and friends should use ToLength instead of ToUint32 (issue 1309243003 by ape...@igalia.com)

2015-09-16 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 5 (id:??) landed as https://crrev.com/d4e1299f1686ff55f9425d6b322c194a1968fe3f Cr-Commit-Position: refs/heads/master@{#30772} https://codereview.chromium.org/1309243003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: ES6: Array.prototype.slice and friends should use ToLength instead of ToUint32 (issue 1309243003 by ape...@igalia.com)

2015-09-16 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309243003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309243003/80001 https://codereview.chromium.org/1309243003/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: ES6: Array.prototype.slice and friends should use ToLength instead of ToUint32 (issue 1309243003 by ape...@igalia.com)

2015-09-16 Thread aperez
Fixed nit. Let's land this for good :) https://codereview.chromium.org/1309243003/diff/60001/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/1309243003/diff/60001/src/bootstrapper.cc#newcode1857 src/bootstrapper.cc:1857: Handle flag(FLAG_harmony_tolength ?

[v8-dev] Re: [Atomics] Remove support for atomic accesses on floating-point values. (issue 1318713007 by bi...@chromium.org)

2015-09-16 Thread binji
https://codereview.chromium.org/1318713007/diff/20001/src/runtime/runtime-atomics.cc File src/runtime/runtime-atomics.cc (right): https://codereview.chromium.org/1318713007/diff/20001/src/runtime/runtime-atomics.cc#newcode490 src/runtime/runtime-atomics.cc:490: case kExternalFloat64Array: On 201

[v8-dev] Re: [futex] Allow debugger to break in the middle of a futexWait (issue 1321543004 by bi...@chromium.org)

2015-09-16 Thread binji
https://codereview.chromium.org/1321543004/diff/80001/test/cctest/test-debug.cc File test/cctest/test-debug.cc (right): https://codereview.chromium.org/1321543004/diff/80001/test/cctest/test-debug.cc#newcode7763 test/cctest/test-debug.cc:7763: const char* command_continue = It sounds like Yang w

[v8-dev] Re: [futex] Allow debugger to break in the middle of a futexWait (issue 1321543004 by bi...@chromium.org)

2015-09-16 Thread binji
https://codereview.chromium.org/1321543004/diff/40001/src/debug/debug.cc File src/debug/debug.cc (right): https://codereview.chromium.org/1321543004/diff/40001/src/debug/debug.cc#newcode2282 src/debug/debug.cc:2282: break_in_nondebuggable_)) On 2015/09/01 at 01:55:48, Yang OOO until mid October

[v8-dev] Re: ES6: Array.prototype.slice and friends should use ToLength instead of ToUint32 (issue 1309243003 by ape...@igalia.com)

2015-09-16 Thread mstarzinger
LGTM (rubber-stamp for heap). https://codereview.chromium.org/1309243003/diff/60001/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/1309243003/diff/60001/src/bootstrapper.cc#newcode1857 src/bootstrapper.cc:1857: Handle flag(FLAG_harmony_tolength ? heap()->t

[v8-dev] Re: ES6: Array.prototype.slice and friends should use ToLength instead of ToUint32 (issue 1309243003 by ape...@igalia.com)

2015-09-16 Thread dehrenberg via v8-dev
On 2015/09/15 09:32:28, commit-bot: I haz the power wrote: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5780) The presubmit has been failing due to the lack of an owner LGTM for src/he

[v8-dev] Re: ES6: Array.prototype.slice and friends should use ToLength instead of ToUint32 (issue 1309243003 by ape...@igalia.com)

2015-09-16 Thread mstarzinger
LGTM (rubber-stamp for heap). https://codereview.chromium.org/1309243003/diff/60001/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/1309243003/diff/60001/src/bootstrapper.cc#newcode1857 src/bootstrapper.cc:1857: Handle flag(FLAG_harmony_tolength ? heap()->t

[v8-dev] Re: [es6] support `get` and `set` in shorthand properties (issue 1328083002 by caitpotte...@gmail.com)

2015-09-16 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 8 (id:??) landed as https://crrev.com/b444da41ad9ef32cea08fd24fd89eab258cd1360 Cr-Commit-Position: refs/heads/master@{#30769} https://codereview.chromium.org/1328083002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [es6] support `get` and `set` in shorthand properties (issue 1328083002 by caitpotte...@gmail.com)

2015-09-16 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #8 (id:160001) https://codereview.chromium.org/1328083002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: [es6] support `get` and `set` in shorthand properties (issue 1328083002 by caitpotte...@gmail.com)

2015-09-16 Thread caitpotter88
On 2015/09/16 15:25:35, adamk wrote: lgtm Sorry for the delay, I was expecting a ping from your end when you uploaded a new patch. My bad, maybe I'm too used to Bugzilla reporting uploaded attachments by email automatically, by default. https://codereview.chromium.org/1328083002/ -- -

[v8-dev] Re: [es6] support `get` and `set` in shorthand properties (issue 1328083002 by caitpotte...@gmail.com)

2015-09-16 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328083002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328083002/160001 https://codereview.chromium.org/1328083002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: [es6] support `get` and `set` in shorthand properties (issue 1328083002 by caitpotte...@gmail.com)

2015-09-16 Thread adamk
lgtm Sorry for the delay, I was expecting a ping from your end when you uploaded a new patch. https://codereview.chromium.org/1328083002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the G

[v8-dev] Re: [es6] support `get` and `set` in shorthand properties (issue 1328083002 by caitpotte...@gmail.com)

2015-09-16 Thread caitpotter88
On 2015/09/08 23:35:13, caitp wrote: Sounds good to me. I'll have a patchset later tonight https://codereview.chromium.org/1328083002/diff/40001/src/preparser.h File src/preparser.h (right): https://codereview.chromium.org/1328083002/diff/40001/src/preparser.h#newcode2663 src/preparser.h:2

[v8-dev] Re: Remove --pretenuring-call-new (issue 1202173002 by mvstan...@chromium.org)

2015-09-16 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 4 (id:??) landed as https://crrev.com/b5588f48fd0b4e3ee43be1fe6c19d7ddd8b8b5f1 Cr-Commit-Position: refs/heads/master@{#30767} https://codereview.chromium.org/1202173002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Remove --pretenuring-call-new (issue 1202173002 by mvstan...@chromium.org)

2015-09-16 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #4 (id:60001) https://codereview.chromium.org/1202173002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Remove --pretenuring-call-new (issue 1202173002 by mvstan...@chromium.org)

2015-09-16 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202173002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1202173002/60001 https://codereview.chromium.org/1202173002/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: Remove --pretenuring-call-new (issue 1202173002 by mvstan...@chromium.org)

2015-09-16 Thread jkummerow
src/full-codegen/* LGTM. https://codereview.chromium.org/1202173002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop rec

[v8-dev] Re: Remove --pretenuring-call-new (issue 1202173002 by mvstan...@chromium.org)

2015-09-16 Thread commit-...@chromium.org via codereview.chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5841) https://codereview.chromium.org/1202173002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev ---

[v8-dev] Re: Remove --pretenuring-call-new (issue 1202173002 by mvstan...@chromium.org)

2015-09-16 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202173002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1202173002/60001 https://codereview.chromium.org/1202173002/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: Remove --pretenuring-call-new (issue 1202173002 by mvstan...@chromium.org)

2015-09-16 Thread commit-...@chromium.org via codereview.chromium.org
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/9756) v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5838) https://codere

[v8-dev] Re: Remove --pretenuring-call-new (issue 1202173002 by mvstan...@chromium.org)

2015-09-16 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202173002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1202173002/40001 https://codereview.chromium.org/1202173002/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: Bubble up the transitions associated with PreventExtensionsWithTransition (issue 1239803004 by conr...@chromium.org)

2015-09-16 Thread ishell
Please also add tests for this functionality. https://codereview.chromium.org/1239803004/diff/20001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1239803004/diff/20001/src/objects.cc#newcode2367 src/objects.cc:2367: if (!prev_object->IsUndefined()) { How about addi

[v8-dev] Re: Speedup JSReceiver::GetKeys (issue 1316213008 by cbr...@chromium.org)

2015-09-16 Thread cbruni
PTAL Updated CL with OrderedHashSet https://codereview.chromium.org/1316213008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group a

[v8-dev] Re: Remove --pretenuring-call-new (issue 1202173002 by mvstan...@chromium.org)

2015-09-16 Thread commit-...@chromium.org via codereview.chromium.org
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/8021) v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/buil

[v8-dev] Re: Remove --pretenuring-call-new (issue 1202173002 by mvstan...@chromium.org)

2015-09-16 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1202173002/20001 https://codereview.chromium.org/1202173002/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: Remove --pretenuring-call-new (issue 1202173002 by mvstan...@chromium.org)

2015-09-16 Thread hpayer
lgtm https://codereview.chromium.org/1202173002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Fix a segment-fault caused by Value::IntegerValue (issue 1303093004 by pmq2...@gmail.com)

2015-09-16 Thread jochen
On 2015/09/09 at 23:35:56, info wrote: https://codereview.chromium.org/1303093004/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/1303093004/diff/1/src/api.cc#newcode3271 src/api.cc:3271: has_pending_exception = On 2015/09/09 14:16:59, jochen wrote: > can you pull th