: __ push(r1); // constructor function
> On 2008/09/11 21:33:13, Feng Qian wrote:
>>
>> The constructor function pushed on the stack seems not used. Double
>
> check!
>
> It is used for example on line 78:
> __ ldr(r1, MemOperand(sp, kPointerSize));
>
> http://coderevi
have a helper class that the constructor pushes esp
and the destructor verifies the stack is balanced, then we can use the
helper class for each statement.
Cheers,
Feng
On Tue, Sep 16, 2008 at 3:54 AM, <[EMAIL PROTECTED]> wrote:
> Reviewers: Kasper Lund, Feng Qian,
>
> Descript
t; statements with --debug-code and stack balance checks enabled once
> this has been submitted.
>
> Cheers,
> Kasper
>
> On Tue, Sep 16, 2008 at 7:21 PM, Feng Qian <[EMAIL PROTECTED]> wrote:
>> As Ivan and I discussed offline, it is better to have stack balance
>>
On Sat, Sep 27, 2008 at 3:56 PM, Andrew Paprocki <[EMAIL PROTECTED]> wrote:
>
> Is anyone interested in trying to implement E4X in v8? Can anyone from
> Google comment on whether anyone there is already working on this
> effort so work wouldn't be duplicated?
No one from V8 team is working on thi
Awesome, hoping Windows issue can be fixed by someone.
On Tue, Sep 30, 2008 at 9:09 AM, Christian Plesner Hansen
<[EMAIL PROTECTED]> wrote:
>
> On Dean's suggestion I've added a -j option to the test script that
> will run (and build) the tests in parallel. On my machine (a four
> core) running
I don't know how many bytes can you save, any data?
Is it guaranteed that uninitialized data field is zero on other platforms?
On Wed, Oct 15, 2008 at 1:22 PM, Blaisorblade <[EMAIL PROTECTED]> wrote:
>
> Hi all,
> I noticed that in some cases you explicitly initialize global
> variables to 0 when
Thanks, that sounds good.
On Mon, Oct 20, 2008 at 8:07 AM, <[EMAIL PROTECTED]> wrote:
> I've been working on a development shell that includes counters (as well
> as readline support). The code is under review
> (http://codereview.chromium.org/7519) and as soon as I've submitted it,
> which I e
lgtm, I will check this in for you.
On Fri, Oct 24, 2008 at 2:35 PM, <[EMAIL PROTECTED]> wrote:
> Reviewers: Feng Qian,
>
> Description:
> Remove unused strcasecmp function.
>
> It conflicted with one defined in webkit/wtf/StringExtras.h
>
>
On Mon, Oct 27, 2008 at 4:02 AM, <[EMAIL PROTECTED]> wrote:
> Drive by comment:
>
>
> http://codereview.chromium.org/7990/diff/201/206
> File src/array.js (right):
>
> http://codereview.chromium.org/7990/diff/201/206#newcode376
> Line 376: // TODO: can we just use arguments?
> I think it would wo
Done.
Using 'if (y == null) return 1;'
On Sat, Oct 25, 2008 at 12:24 AM, Kasper Lund <[EMAIL PROTECTED]> wrote:
> LGTM. I would remove the extra newlines because they aren't used in
> the other parts of the function though, and maybe add a comment that
> the IS_OBJECT check and the %_ObjectEqual
lgtm, thanks
On Tue, Oct 28, 2008 at 7:54 AM, <[EMAIL PROTECTED]> wrote:
> Reviewers: Feng Qian,
>
> Description:
> Fix lint issues.
>
> [EMAIL PROTECTED]
>
> Please review this at http://codereview.chromium.org/8659
>
> SVN Base: http://v8.googl
Kasper, can you explain why need 3 GC's? I probably missed some
changes in GC and policy.
On Wed, Oct 29, 2008 at 4:43 AM, <[EMAIL PROTECTED]> wrote:
>
> Reviewers: Erik Corry, Kevin Millikin,
>
> Description:
> Allow three runtime call attempts before throwing an out of
> memory exception. Stil
I figured out why it crashes.
JavaScriptCore is compiled with ENABLE_CTI on, and it adds a field to
JSGlobalData;
KJSBinding and WebCore are compiled without ENABLE_CTI, so
JSGlobalData misses a field.
The difference causes object layout mismatch.
I am adding ENABLE_CTI=1 for in both using_java
! Thanks Feng :)
> -Darin
>
> On Mon, Nov 3, 2008 at 5:11 PM, Feng Qian <[EMAIL PROTECTED]> wrote:
>>
>> I figured out why it crashes.
>>
>> JavaScriptCore is compiled with ENABLE_CTI on, and it adds a field to
>> JSGlobalData;
>> KJSBinding and
Do you mean 'hidden prototype object'? It is like a normal object
except that not accessible by JS code '__proto__'.
I am not sure if object cloning can help much because you need to fix
whole prototype chain for a cloned object. V8 is doing something like
that for object literals (Boilerplate).
an allocation in new space, we'll GC
that space. The second one - should that be necessary - will do a full
GC and retry one last time with allocation guaranteed to succeed if
there's enough memory. So only two GCs - not three.
Cheers,
Kasper
On Thu, Oct 30, 2008 at 7:12 PM, Feng Qian
ures (particularly about object layout) that I can read to
> better understand this issue?
>
> Thanks.
>
> On Nov 7, 9:27 am, Feng Qian <[EMAIL PROTECTED]> wrote:
>> Do you mean 'hidden prototype object'? It is like a normal object
>> except that not acces
Ivan and I consider this as a temporary solution. We'd like to change
the signature of cmp instruction so the hidden side-effect (using ip)
becomes obvious. Currently you cannot tell the differences between
cmp(ip, Operand(Handle(name)); and
cmp(ip, Operand(r0));
The former is troublesome, but t
It is a wrong fix, reverted, only add a test of the current situation.
Now I am thinking issue 54 should be about fixing confusing API.
Internal field count wasn't lost, but it is on global's prototype
object, accessible via context->Global()->GetPrototype().
On Wed, Dec 10, 2008 at 11:46 AM, <
lgtm
On Thu, Dec 11, 2008 at 2:48 AM, <[EMAIL PROTECTED]> wrote:
> Reviewers: Christian Plesner Hansen, Feng Qian,
>
> Description:
> Make sure that the API does not change templates pass in from the
> user. The API should never change templates behind the back of the
>
lgtm
On Fri, Jan 23, 2009 at 9:48 AM, wrote:
> Reviewers: Feng Qian,
>
> Description:
> Fix Windows build (maybe).
>
> TBR=fqian
>
>
> Please review this at http://codereview.chromium.org/18556
>
> SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
review.chromium.org/21117/diff/30/1023
> File include/v8.h (right):
>
> http://codereview.chromium.org/21117/diff/30/1023#newcode844
> Line 844: */
> On 2009/02/11 19:14:59, Feng Qian wrote:
>>
>> The description does not mention a subtlety in the implementation: if
>
&g
What's the status of Isolate?
On 2010/07/01 22:00:57, Vitaly wrote:
Thanks everyone for comments! This is now landed.
-- Vitaly
http://codereview.chromium.org/2566002/diff/17001/18001
File include/v8.h (right):
http://codereview.chromium.org/2566002/diff/17001/18001#newcode2388
include
23 matches
Mail list logo
