https://codereview.chromium.org/782573002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it, send
jochen and rmcilroy: could you please take a look?
This CL depends on this landing first:
https://codereview.chromium.org/753103003/
https://codereview.chromium.org/749213004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
https://codereview.chromium.org/749213004/diff/1/BUILD.gn
File BUILD.gn (right):
https://codereview.chromium.org/749213004/diff/1/BUILD.gn#newcode1418
BUILD.gn:1418: deps = []
On 2014/11/24 17:21:06, rmcilroy wrote:
Is there any reason you need to make these changes? I would have
thought the
Addressed Ross' comments.
https://codereview.chromium.org/749213004/diff/1/BUILD.gn
File BUILD.gn (right):
https://codereview.chromium.org/749213004/diff/1/BUILD.gn#newcode1418
BUILD.gn:1418: deps = []
On 2014/11/24 18:01:34, rmcilroy wrote:
On 2014/11/24 17:28:11, baixo1 wrote:
On
Could you please take a look?
Thanks!
https://codereview.chromium.org/746263002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group
On 2014/11/21 13:40:51, rmcilroy wrote:
On 2014/11/21 12:34:02, Andrew Hayden wrote:
I'm not too worried about the approach; it's not pretty, but GYP is
obtuse
with
things like this. More reasons to get the GN migration done, IMO, not
that
this
should be an excuse for poor code quality.
Andrew, thanks for reporting this!
I know the solution is not ideal but I tried everything under the sun to
simply
replace the last argument of 'action' by a variable that would be either
snapshot_blob.bin or snapshot_blob_host.bin, depending on what toolset it
being
built. Nothing worked,
Daniel: could you please take a look?
Thanks!
https://codereview.chromium.org/738153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
Please take a look.
https://codereview.chromium.org/727513002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Please take a look.
https://codereview.chromium.org/684263002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Reviewers: rmcilroy, vogelheim,
Message:
Please take a look.
Description:
v8_external_snapshot target visible only when using
v8_use_external_startup_data
Prevent snapshot_blob.bin from being unnecessarily generated when building
all
targets.
Please review this at
Addressed Ross' comment.
https://codereview.chromium.org/643163002/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):
https://codereview.chromium.org/643163002/diff/1/tools/gyp/v8.gyp#newcode1405
tools/gyp/v8.gyp:1405: [ 'v8_use_external_startup_data==1', {
On 2014/10/10 16:31:33, rmcilroy
Addressed Ross' comments.
https://codereview.chromium.org/609843002/diff/20001/src/arm64/assembler-arm64.h
File src/arm64/assembler-arm64.h (right):
https://codereview.chromium.org/609843002/diff/20001/src/arm64/assembler-arm64.h#newcode1903
src/arm64/assembler-arm64.h:1903:
On 2014/10/02
Addressed Ross' comments.
https://codereview.chromium.org/609843002/diff/40001/src/arm64/macro-assembler-arm64.cc
File src/arm64/macro-assembler-arm64.cc (right):
https://codereview.chromium.org/609843002/diff/40001/src/arm64/macro-assembler-arm64.cc#newcode3069
Reviewers: rmcilroy, Yang, vogelheim,
Message:
Please take a look.
Description:
Extend snapshot creation to generate 4-byte values
Please review this at https://codereview.chromium.org/623993002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+9, -3 lines):
Addressed Ross' comment.
https://codereview.chromium.org/623993002/diff/1/tools/js2c.py
File tools/js2c.py (right):
https://codereview.chromium.org/623993002/diff/1/tools/js2c.py#newcode502
tools/js2c.py:502: size = 4
On 2014/10/03 16:51:35, rmcilroy wrote:
nit - please move this into an else
https://codereview.chromium.org/609843002/diff/1/src/ia32/assembler-ia32.h
File src/ia32/assembler-ia32.h (right):
https://codereview.chromium.org/609843002/diff/1/src/ia32/assembler-ia32.h#newcode1102
src/ia32/assembler-ia32.h:1102: // Support not implemented in ia32 yet.
On 2014/09/26
Reviewers: rmcilroy,
Message:
Please take a look.
Description:
Refactor FrameAndConstantPoolScope
Please review this at https://codereview.chromium.org/609843002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+48, -46 lines):
M src/arm/macro-assembler-arm.h
Could you guys take another look, please?
Builds were not working correctly because the blobs could be generated from
multiple targets (host and target). This was fixed.
https://codereview.chromium.org/506983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
https://codereview.chromium.org/506983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it, send
Changed to strncmp
https://codereview.chromium.org/496253003/diff/20001/tools/js2c.py
File tools/js2c.py (right):
https://codereview.chromium.org/496253003/diff/20001/tools/js2c.py#newcode514
tools/js2c.py:514: value += '\0'
You're right. Just changed the strcmp side.
On 2014/08/26 12:43:12,
Reviewers: mcilroy, vogelheim,
Message:
Please take a look.
Description:
Properly separate host and target builds when using external natives.
Please review this at https://codereview.chromium.org/506983002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+11,
Reviewers: rmcilroy,
Message:
Please take a look.
Description:
Fix external snapshot serialization by null-terminating strings
Please review this at https://codereview.chromium.org/496253003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -0 lines):
M
On 2014/08/22 10:17:20, rmcilroy wrote:
+vogelheim: Could you take a look please? The external snapshot code was
crashing for Andre before he added this fix.
https://codereview.chromium.org/496253003/diff/1/tools/js2c.py
File tools/js2c.py (right):
24 matches
Mail list logo
