Reviewers: danno, Michael Starzinger, paul.l..., akos.palfi.imgtec,
Description:
MIPS: Fix 'Optimize simulator.'
For simulator optimization we modified Instruction::InstructionType()
function
so a simpler but less complete InstructionType() function used by default.
This
fix enables the full
Reviewers: danno, Benedikt Meurer, paul.l..., akos.palfi.imgtec,
Description:
MIPS: Refine '[es6] Introduce a dedicated JSIteratorResult type.'
Port 72bc4b5c8a5c4279bcb8b340edbc8aa1c46d75a1
Original commit message:
Use a single JSIteratorResult type for all implementation provided
iterator resu
lgtm
https://codereview.chromium.org/1297183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
LGTM.
https://codereview.chromium.org/1264103005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
l-g-t-m
https://codereview.chromium.org/1257953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails fro
LGTM.
https://codereview.chromium.org/1263723002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: paul.l..., akos.palfi.imgtec,
Description:
MIPS: refine '[stubs] Optimize LoadGlobalViaContextStub and
StoreGlobalViaContextStub.'
BUG=
Please review this at https://codereview.chromium.org/1256983005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+6,
ARM/MIPS people: Please port these changes.
We started to work on the MIPS/MIPS64 ports.
https://codereview.chromium.org/1250413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Gr
We are working on fixing the MIPS ports.
https://codereview.chromium.org/1238143002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gr
l-g-t-m
https://codereview.chromium.org/1238253002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails fro
LGTM.
https://codereview.chromium.org/1233903003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2015/07/16 15:56:04, bbudge wrote:
Thanks for catching this.
My change got reverted and I'm trying to reland it. I incorporated your
change
in this version. Let me know if you prefer that I leave it out so you can
land
this CL.
We (and V8 team also) prefer if you include MIPS changes
Reviewers: bbudge, danno, paul.l..., dusmil.imgtec, akos.palfi.imgtec,
Description:
MIPS64: Fix 'Expose SIMD.Float32x4 type to Javascript.'
Port e5ed3bee99807c502fa7d7a367ec401e16d3f773
Original commit message:
This CL exposes the constructor function, defines type related
information, and impl
On 2015/07/14 12:01:20, Yang wrote:
Paul, could you help me with the MIPS/MIPS64 ports?
We made the MIPS port of the CL: https://codereview.chromium.org/1233213002/
https://codereview.chromium.org/1234833003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-
Reviewers: paul.l...,
https://codereview.chromium.org/1233213002/diff/1/src/mips/assembler-mips-inl.h
File src/mips/assembler-mips-inl.h (right):
https://codereview.chromium.org/1233213002/diff/1/src/mips/assembler-mips-inl.h#newcode369
src/mips/assembler-mips-inl.h:369: // debug-mips.cc
BreakL
Also clang formatted.
https://codereview.chromium.org/1237753004/diff/1/build/standalone.gypi
File build/standalone.gypi (right):
https://codereview.chromium.org/1237753004/diff/1/build/standalone.gypi#newcode795
build/standalone.gypi:795: ]
On 2015/07/14 13:16:09, Jakob wrote:
nit: trailing '
Reviewers: danno, Michael Achenbach, Sven Panne, Jakob, paul.l...,
dusmil.imgtec, akos.palfi.imgtec,
Message:
We would like to use Xcode/mac for development. V8-team reviewers, please
take a
look. These changes have got lgtm in
https://codereview.chromium.org/1133163005/#ps160001
but were re
Reviewers: danno, Toon Verwaest, paul.l..., dusmil.imgtec,
akos.palfi.imgtec,
Description:
MIPS64: Fix 'Fix keyed element access wrt string wrappers'.
Port 01f40e6ad6c8137708955494987857fbe489616b
BUG=v8:4296
LOG=n
Please review this at https://codereview.chromium.org/1233923002/
Base URL:
Reviewers: Benedikt Meurer, paul.l..., Hablich, dusmil.imgtec,
Description:
MIPS64: Fix BlockTrampolinePoolFor() to emit trampoline before blocking, if
needed.
Port f0d1106a3fa1ffaa822efc90d61e2aca315cbe15
Fixes possible failure in AssembleArchTableSwitch().
BUG=v8:4294
LOG=y
Please review th
lgtm with minor nit(s)
https://codereview.chromium.org/1227163011/diff/40001/src/mips/builtins-mips.cc
File src/mips/builtins-mips.cc (right):
https://codereview.chromium.org/1227163011/diff/40001/src/mips/builtins-mips.cc#newcode513
src/mips/builtins-mips.cc:513: __ push(a3); // argument 3/2:
lgtm
https://codereview.chromium.org/1234533004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: danno, Michael Starzinger, paul.l..., dusmil.imgtec,
akos.palfi.imgtec,
Description:
MIPS64: Refine 'Remove unused byte from Map::instance_sizes field.'
Port 2027335f1ce44b0c6523eb5e55881e2a4e162815
Original commit message:
Note that there are currently no objects that require a pr
LGTM
https://codereview.chromium.org/1233623004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
LGTM
https://codereview.chromium.org/1211143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
On 2015/06/30 14:11:30, Jakob wrote:
On 2015/06/30 12:53:42, balazs.kilvady wrote:
> Without CLANG_CXX_LIBRARY def. Xcode uses an stdlibc++ from gcc 4.2.1
(the
> version where Apple stopped gcc support and it is from pre-c11 era).
That may be fine. The Chromium style guide explicitly forbids
Jakob, thaks for the answer.
On 2015/06/30 12:21:17, Jakob wrote:
I don't know. I'd think that using clang on Mac is possible, but I haven't
tried
it.
Yes, till now we used Xcode's clang (which is a modified 3.6) running
current
gyp. But we could not use c++11 with it as c++11 is only suppor
Michael, Jakob,
Could you tell me what is the status of c++11 usage of V8 on mac?
If we can’t use the third_party/…/clang on mac then why the gclient sync
downloads it and why the buildbots are using it? Anyway it seems we don’t
have
any chance to use c++11: numeric_limits::lowest(), std::unord
Rebased on https://codereview.chromium.org/1217783002/
https://codereview.chromium.org/1200833013/diff/20001/build/standalone.gypi
File build/standalone.gypi (right):
https://codereview.chromium.org/1200833013/diff/20001/build/standalone.gypi#newcode778
build/standalone.gypi:778: 'CLANG_CXX_LIB
On 2015/06/29 09:58:48, Jakob wrote:
How about rebasing this onto https://codereview.chromium.org/1217783002/
which
computes base_dir for all configurations?
That is a better way.
I also fixed the nit, thanks for catching it.
Can I cancel the commit or should I make a followup CL?
https://co
Reviewers: danno, Jakob, paul.l..., akos.palfi.imgtec,
Message:
This patch allows to use the same version of clang (third_party/llvm/clang)
on
Mac and Linux. Works from Xcode and command line build also. And with v8
buildbots: https://codereview.chromium.org/1214753002/
Description:
Use third
lgtm
https://codereview.chromium.org/1220443002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: danno, jbramley, Paul Neave, dusmil.imgtec, akos.palfi.imgtec,
Description:
MIPS: [turbofan] Fix implementation of Float64Min.
Port d783b763629526a1ec57a9f14caa61d0166efac7
Original commit message:
ARM64's `fmin` and `fmax` instructions don't have the same behaviour as
TurboFan's Flo
Reviewers: danno, conradw, paul.l..., dusmil.imgtec, akos.palfi.imgtec,
Description:
MIPS64: Fix 'Revert of Revert of [strong] Implement strong mode
restrictions on
property access'.
Port 41405c0470d5b30ec5d22665ed9430c46b33624f
TEST=mjsunit/strong/load-property-mutate-backing-store, mjsunit
Reviewers: danno, Benedikt Meurer, paul.l..., dusmil.imgtec,
akos.palfi.imgtec, titzer,
Description:
MIPS: Fix unaligned double acces in
cctest/test-simplified-lowering/RunAccessTests_float64.
TEST=cctest/test-simplified-lowering/RunAccessTests_float64
BUG=
Please review this at https://coder
Reviewers: danno, Benedikt Meurer, Jakob, jarin, paul.l..., dusmil.imgtec,
akos.palfi.imgtec,
Message:
This does need a v8-team review. PTAL if alignment fix is acceptable in v8
this
way or please let us know if there is any better approach.
Description:
MIPS: Fix unaligned memory access.
Reviewers: danno, Sven Panne, Michael Achenbach, martyn.capewell, Jakob,
paul.l..., dusmil.imgtec, akos.palfi,
Message:
This does need a v8-team review on a standlone.gypi (was LGTMed earlier). We
removed the mac related parts and plan to make a followup CL for mac. PTAL
Description:
MIPS64: R
Reviewers: paul.l..., dusmil.imgtec, akos.palfi.imgtec,
djordje.pesic_imgtec.com,
Description:
MIPS: Replace numeric_limits<>::lowest() in cctest-assembler*.cc
On Mac for the requested minimal version (10.5) only old stl (from gcc
4.2.1)
can be used so unfortunately we can't use numeric_limi
lgtm
https://codereview.chromium.org/1170173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
lgtm
https://codereview.chromium.org/1153263012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
I rebased the patch and added the target_conditions check so the --rpath and
--dynamic-linker flags are not used for building mksnapshot. I tested it
with
mips64el only. Further tests are in progress.
https://codereview.chromium.org/1160973006/
--
--
v8-dev mailing list
v8-dev@googlegroups.co
Reviewers: danno, arv, paul.l..., dusmil.imgtec, akos.palfi.imgtec,
Description:
MIPS64: Fix '[es6] Super call in arrows and eval'.
Port 4b8051a02ae9f765b7d803fc7986301abde36007
Original commit message:
This splits the SuperReference AST node into SuperPropertyReference and
SuperCallReference.
Reviewers: paul.l..., dusmil.imgtec, akos.palfi.imgtec,
Message:
Seems to work fine at cross-compiling for all the supported mips archs. And
simulator builds also work. Although I didn't have time to try out all the
possible configuration with all the arch variants. And we need lgtm from
Googl
lgtm
https://codereview.chromium.org/1161713003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: danno, martyn.capewell, paul.l..., akos.palfi.imgtec,
dusmil.imgtec,
Description:
MIPS64: Enable shorten-64-to-32 warning.
Port cdc43bc5fd02fff2905e2e28a79054d0d1eee3ea
Original commit message:
Enable clang's shorten-64-to-32 warning flag on ARM64, and fix the warnings
that arise.
https://codereview.chromium.org/1027193002/diff/40001/src/compiler/mips/instruction-selector-mips.cc
File src/compiler/mips/instruction-selector-mips.cc (right):
https://codereview.chromium.org/1027193002/diff/40001/src/compiler/mips/instruction-selector-mips.cc#newcode1068
src/compiler/mips/ins
PTAL
https://codereview.chromium.org/1027193002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
https://codereview.chromium.org/1027193002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, sen
On 2015/05/07 15:41:11, paul.l... wrote:
On 2015/05/07 15:31:02, dusmil wrote:
> Can we use BlockGrowBufferScope?
I don't think you can block it, you might be emitting a large jump table,
and
need to grow the buffer. How does this change work in that case?
Assembler::dd(Label*) has a Check
Reviewers: paul.l..., akos.palfi.imgtec, dusmil.imgtec,
Description:
MIPS: Fix Assembler::dd(Label*) implementation.
BUG=
TEST=mjsunit/asm/embenchen/lua_binarytrees
Please review this at https://codereview.chromium.org/1127393003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
A
Reviewers: danno, arv, paul.l..., akos.palfi.imgtec,
Description:
MIPS: Improve '[es6] When comparing two symbols we may need to throw a
TypeError'.
Improve d26f5d392317dcf1eef3693eadfa1b95a8850df8
Original commit message:
When comparing a symbol to istself using <, <=, > or >= we need to
throw
Please find the MIPS port at https://codereview.chromium.org/1127573004/
https://codereview.chromium.org/1053143005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" gro
lgtm
https://codereview.chromium.org/1118693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Sven Panne, paul.l..., dusmil.imgtec, akos.palfi.imgtec,
Description:
MIPS: Fix 'Detect simple tail calls'.
4b122b7504ab458faa4132c338809b40147751bf
BUG=
Please review this at https://codereview.chromium.org/1116913002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Should not we add the same alias names for sel*.[s|d] ops?
https://codereview.chromium.org/1118693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
Reviewers: danno, mtbrandyberry, jochen, paul.l..., dusmil.imgtec,
akos.palfi.imgtec,
Description:
MIPS: Followup 'Fix Add HArrayBufferNotNeutered instruction'.
Followup fix of nit discussed in Issue 003002.
BUG=
Please review this at https://codereview.chromium.org/1112793004/
Base URL
Reviewers: danno, jochen, paul.l..., dusmil.imgtec, akos.palfi.imgtec,
Description:
MIPS: Fix 'Add HArrayBufferNotNeutered instruction'.
BUG=
Please review this at https://codereview.chromium.org/003002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -4 l
Looks good. I see SecondaryField param is used in min, max too, but it is a
nit
for me:
https://codereview.chromium.org/1108583003/diff/1/src/mips/assembler-mips.h
File src/mips/assembler-mips.h (right):
https://codereview.chromium.org/1108583003/diff/1/src/mips/assembler-mips.h#newcode915
sr
https://codereview.chromium.org/1100083002/diff/11/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/1100083002/diff/11/src/arm/lithium-codegen-arm.cc#newcode3359
src/arm/lithium-codegen-arm.cc:3359: __ LoadRoot(scratch,
Heap::kAr
On 2015/04/23 13:40:00, Jakob wrote:
LGTM with a bunch of comments, mostly nits though. Happy to take another
look
if
you want.
MIPS folks, can you please take a look at the lithium-codegen-mips*
changes?
In src/mips64/lithium-codegen-mips64.cc, line 3345
__ lw(scratch, FieldMemOperand(r
On 2015/04/14 16:35:24, paul.l... wrote:
On 2015/04/14 09:41:57, Jakob wrote:
> MIPS: This is ready for landing, please be so kind to prepare the ports.
Jakob, with this CL on ToT now, with the flag on, there are lots of
crashes in
release mode, and asserts hit in debug (ia32 & x64):
# Fatal
LGTM.
https://codereview.chromium.org/1085693003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: danno, Benedikt Meurer, paul.l..., akos.palfi.imgtec,
gergely.kis.imgtec, dusmil.imgtec,
Description:
MIPS: [turbofan] Materialize JSFunction from frame if possible.
Port 725cdc533cb4e31c042d32ce1979012b5bd99ced
Original commit message:
This reduces the overhead of recursive calls
lgtm
https://codereview.chromium.org/1067393003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: danno, Benedikt Meurer, paul.l..., dusmil.imgtec,
akos.palfi.imgtec, gergely.kis.imgtec,
Description:
MIPS: [turbofan] Add new Float32Abs and Float64Abs operators.
Port 9af9f1d0262e2dab66c62331a03f6a76504f3866
Original commit message:
These operators compute the absolute floating p
lgtm
https://codereview.chromium.org/1066403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: danno, Yang, paul.l..., gergely.kis.imgtec, akos.palfi.imgtec,
dusmil.imgtec,
Description:
MIPS64: Fix typo of 'Always update raw pointers when handling interrupts
inside
RegExp code.'
Port c67cb287a901ddf03d4ae4dafcf431d09fd3e22c
BUG=
Please review this at https://codereview.c
Reviewers: danno, Michael Starzinger, paul.l..., akos.palfi.imgtec,
gergely.kis.imgtec, dusmil.imgtec,
Description:
MIPS64: Make --always-opt also optimize top-level code.
Port 2d281e71ac49058ef5696f4255ff1fa30796bc5e
Original commit message:
This enables eager optimization of top-level code
https://codereview.chromium.org/1066843003/diff/1/src/mips/builtins-mips.cc
File src/mips/builtins-mips.cc (right):
https://codereview.chromium.org/1066843003/diff/1/src/mips/builtins-mips.cc#newcode876
src/mips/builtins-mips.cc:876: __ Push(a1, argc);
On 2015/04/07 13:23:51, Jakob wrote:
Note
Reviewers: danno, Jakob, paul.l..., dusmil.imgtec, akos.palfi.imgtec,
gergely.kis.imgtec,
Description:
MIPS: JSEntryTrampoline: check for stack space before pushing arguments
Port 146598f44a1efd0f942745abfd6c08a073972c01
Original commit message:
Optimistically pushing a lot of arguments can r
LGTM.
https://codereview.chromium.org/1059433003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm.
https://codereview.chromium.org/1043393002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: paul.l..., dusmil.imgtec, akos.palfi.imgtec, gergely.kis.imgtec,
Description:
MIPS: Rename BranchF functions.
BUG=
Please review this at https://codereview.chromium.org/1052653003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+78, -86 lines):
M src
Reviewers: danno, Benedikt Meurer (OOO), paul.l..., akos.palfi.imgtec,
dusmil.imgtec, gergely.kis.imgtec,
Description:
Finish 'MIPS: [turbofan] Add backend support for float32 operations.'
Add missing parts of the port to MIPS/MIPS64 implementations.
BUG=
Please review this at https://codere
LGTM.
https://codereview.chromium.org/1045203003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: danno, Benedikt Meurer (OOO), paul.l..., dusmil.imgtec,
akos.palfi.imgtec, gergely.kis.imgtec,
Description:
MIPS: [turbofan] Add backend support for float32 operations.
Port 8dad78cdbd21c2cd02d6e0645313bd4b9983c78e
Original commit message:
This adds the basics necessary to support
LGTM.
https://codereview.chromium.org/1046873004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2015/03/26 17:33:40, Toon Verwaest wrote:
PTAL
balazs.kilvady: fyi
I've ported your CL to MIPS, I've uploaded the patch into this CL:
https://codereview.chromium.org/1043493003/
If you can merge the MIPS port into your CL or we'll land this patch when
you
land your CL.
https://coderevie
On 2015/03/26 17:33:40, Toon Verwaest wrote:
PTAL
balazs.kilvady: fyi
Thank you for the fyi. I will do the port as soon as I can.
https://codereview.chromium.org/1010803012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Reviewers: danno, titzer, paul.l..., akos.palfi.imgtec, gergely.kis.imgtec,
dusmil.imgtec,
Description:
MIPS: Fix [turbofan] Factor out common switch-related code in instruction
selectors.
BUG=
Please review this at https://codereview.chromium.org/1019923004/
Base URL: https://chromium.googl
Reviewers: paul.l..., dusmil, akos.palfi.imgtec, gergely.kis.imgtec,
Message:
PTAL,
Is the arch variant checking is OK and should/could we add min/max to
mips32r6
also (in this CL)?
Description:
MIPS64: [turbofan] Support Float64Min and Float64Max.
Port b9ef7d42678d486123445aa17459ff778625b
https://codereview.chromium.org/1025453003/diff/40001/src/serialize.h
File src/serialize.h (right):
https://codereview.chromium.org/1025453003/diff/40001/src/serialize.h#newcode333
src/serialize.h:333: // 0x1fUnused (including 0x3f, 0x5f, 0x7f).
On 2015/03/20 16:55:46, paul.l... wrote:
Reviewers: danno, caitp, paul.l..., akos.palfi.imgtec, dusmil.imgtec,
gergely.kis.imgtec,
Description:
MIPS: [es6] generate rest parameters correctly for subclass constructors
Port bef80fcfd7e89cadc215f7d10a016a375e346490
BUG=v8:3977
LOG=N
Please review this at https://codereview.chromium.or
Yang could you take a look, please if u have time?
https://codereview.chromium.org/1025453003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe fr
Reviewers: danno, Benedikt Meurer, paul.l..., dusmil.imgtec,
akos.palfi.imgtec, gergely.kis.imgtec,
Description:
MIPS: [turbofan] Turn Math.clz32 into an inlinable builtin.
Port 3aa206b86560da94f895625186295bf07a0301d8
BUG=v8:3952
LOG=n
Please review this at https://codereview.chromium.org/1
https://codereview.chromium.org/1025453003/diff/20001/src/serialize.cc
File src/serialize.cc (right):
https://codereview.chromium.org/1025453003/diff/20001/src/serialize.cc#newcode1837
src/serialize.cc:1837: rinfo->rmode() == RelocInfo::INTERNAL_REFERENCE
On 2015/03/19 19:16:33, yangguo wrote:
Reviewers: Yang, danno, balazs.kilvady, akos.palfi.imgtec, dusmil.imgtec,
paul.l...,
https://codereview.chromium.org/1025453003/diff/1/src/mips64/assembler-mips64-inl.h
File src/mips64/assembler-mips64-inl.h (right):
https://codereview.chromium.org/1025453003/diff/1/src/mips64/assembler-mips6
lgtm.
https://codereview.chromium.org/1019463003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM.
https://codereview.chromium.org/1011383004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: paul.l..., dusmil.imgtec, akos.palfi.imgtec, gergely.kis.imgtec,
Description:
MIPS: Serializer: serialize internal references via object visitor.
Port 7c149afb6c875b1c53723384459dc14a0e961927
BUG=
Please review this at https://codereview.chromium.org/1019083002/
Base URL: https://c
LGTM
https://codereview.chromium.org/1015613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: danno, Toon Verwaest, paul.l..., gergely.kis.imgtec,
akos.palfi.imgtec, dusmil.imgtec,
Description:
MIPS: Disinherit PropertyCell from Cell.
Port 8c0d289772649217a55011133c0e481741618330
BUG=
Please review this at https://codereview.chromium.org/1017103003/
Base URL: https://chro
Reviewers: danno, Toon Verwaest, paul.l..., dusmil.imgtec,
akos.palfi.imgtec, gergely.kis.imgtec,
Description:
MIPS: Remove PropertyCell space.
Port 16c8485a35efc36cf6ccd15185282d65412e1502
Original commit message:
Replaces StoreGlobalCell / LoadGlobalCell with NamedField variants that use
wr
Reviewers: danno, Michael Starzinger, paul.l..., dusmil.imgtec,
akos.palfi.imgtec, gergely.kis.imgtec,
Description:
MIPS: Remove kind field from StackHandler.
Port 15f8213809a57c2a163b500a732c9ffe5160a41a
Original commit message:
This relands commit 96f79568a926966ebcf0685bf9adc947f4e1fbff.
Reviewers: paul.l..., dusmil.imgtec, gergely.kis.imgtec, akos.palfi.imgtec,
Description:
MIPS: Improve naming of turbofan ops for %_DoubleHi, %_DoubleLo and
%_ConstructDouble.
BUG=
Please review this at https://codereview.chromium.org/1006523002/
Base URL: https://chromium.googlesource.com/v8/
Reviewers: danno, Benedikt Meurer, paul.l..., gergely.kis.imgtec,
akos.palfi.imgtec, dusmil.imgtec,
Description:
MIPS: [turbofan] Introduce optional Float64Min and Float64Max machine
operators.
Port 99f8d57f3c5d967bc3b10356b22d7ec7be55e89f
Original commit message:
Basically recognize certa
Reviewers: danno, Michael Starzinger, paul.l..., akos.palfi.imgtec,
gergely.kis.imgtec, dusmil.imgtec,
Description:
MIPS: Simplify pending message object handling.
Port d4696c484142c601cbd691ae80164043785a3af7
Original commit message:
This moves the decision whether to report a message or not
Reviewers: danno, Michael Starzinger, paul.l..., dusmil.imgtec,
akos.palfi.imgtec, gergely.kis.imgtec,
Description:
MIPS: Simplify pending message script handling.
Port f71e26268338d2840133264329bf35a63011bb5a
Original commit message:
This removes the separate tracking of the pending message
Reviewers: danno, loislo, paul.l..., dusmil.imgtec, akos.palfi.imgtec,
gergely.kis.imgtec,
Description:
MIPS64: CpuProfiler: fix for CollectDeoptEvents test.
Port a925f3f4784f8318f69a201a6b44aa94f97e4ba3
Original commit message:
The same idea as in https://codereview.chromium.org/984893003/
Reviewers: danno, loislo, paul.l..., akos.palfi.imgtec, gergely.kis.imgtec,
dusmil.imgtec,
Description:
MIPS: CpuProfiler: fix for CollectDeoptEvents test.
Port a925f3f4784f8318f69a201a6b44aa94f97e4ba3
Original commit message:
The same idea as in https://codereview.chromium.org/984893003/
BU
Reviewers: danno, arv, paul.l..., dusmil.imgtec, gergely.kis.imgtec,
akos.palfi.imgtec,
Description:
MIPS: [es6] Throw TypeError for computed static prototype property name
Port 8d946b9c3f6ea42dd5232c0529be4d47798b06aa
Original commit message:
The prototype of a class constructor function is
1 - 100 of 391 matches
Mail list logo
