On 2014/04/09 22:01:12, bradn wrote:
LGTM
https://codereview.chromium.org/232143002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this g
On 2013/04/29 07:33:41, Dmitry Lomov (chromium) wrote:
Unfortunately this does not fix mksnapshot on Win64.
On 2013/04/27 00:58:15, Brad Chen wrote:
> PTAL
Thank you for checking this! I had accidentally omitted the Win64-specific
patch.
PTAL
https://codereview.chromium.org/14305029/
--
--
v
Reviewers: ulan, Jakob,
Message:
PTAL
Description:
Accurate function prototypes for native calls from ARM simulator.
This is a resubmit of codereview.chromium.org/13818012 with the following
modifications:
- src/x64/code-stubs-x64.cc for changes specific to Win64 calling
conventions.
- src
PTAL
New patch uploaded. I will need your help to submit.
Thanks,
Brad
https://codereview.chromium.org/13841011/diff/1/Makefile
File Makefile (right):
https://codereview.chromium.org/13841011/diff/1/Makefile#newcode275
Makefile:275: tools/run-tests.py $(TESTJOBS) --outdir=$(OUTDIR)/native \
With 13818012 landed, this is (hopefully) my last change. It should enable
the
Native Client build targets and have no effect on other builds. Once this
has
landed, I will need help from Michael to set up NaCl builders for the V8
waterfall.
https://codereview.chromium.org/13841011/
--
--
v8-
NOTE: I am seeing a "TIMEOUT" test failure for arm.check
cctest/testapi/Threading1. I see this with or without this CL, so I'm
assuming
it has nothing to do with my changes.
I'm also seeing some problems with the pre-submit checks that run with
foo.check. That might actually be my problem, al
Thanks for the comments. I'll upload a minor update after a little bit of
local
testing.
https://codereview.chromium.org/13818012/diff/3001/src/arguments.h
File src/arguments.h (right):
https://codereview.chromium.org/13818012/diff/3001/src/arguments.h#newcode122
src/arguments.h:122: Type Nam
On 2013/04/09 16:13:07, Brad Chen wrote:
PTAL
Please ignore this change.
https://codereview.chromium.org/13820012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" gr
Reviewers: danno, Jakob, ulan,
Message:
PTAL
Description:
Exclude another test from mjsunit.
BUG=2614
Please review this at https://codereview.chromium.org/13820012/
SVN Base: git://github.com/v8/v8.git@master
Affected files:
M test/mjsunit/mjsunit.status
Index: test/mjsunit/mjsunit.st
a shell command.
'v8_compress_startup_data%': 'off',
'v8_target_arch%': '<(target_arch)',
+# Native Client builds currently use the V8 ARM JIT and
+# arm/simulator-arm.cc to defer the significant effort required
+# for NaCl JIT suppo
Reviewers: danno, ulan, Jakob,
Message:
PTAL
Description:
Accurate function prototypes for native calls from ARM simulator.
Native method invocation from the arm/simulator-arm.cc previously made
non-portable assumptions about calling conventions. This was okay for 32-bit
stack-based machines, w
Thanks for your help getting the first four patches landed. The next few
will
be:
- change native function invocation from simulator-arm.cc to use accurate
function prototypes
- exclude one more test in mjsunit
- build system changes
Unlike the previous CLs, some of these change paths used by a
On 2013/04/09 07:38:18, ulan wrote:
> I will change the #ifdef to disable for Native Client on all platforms.
Okay?
OK, sounds good.
PTAL
https://codereview.chromium.org/13704002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
https://codereview.chromium.org/13704002/diff/1/src/platform-linux.cc
File src/platform-linux.cc (right):
https://codereview.chromium.org/13704002/diff/1/src/platform-linux.cc#newcode1084
src/platform-linux.cc:1084: // Profiling is disabled for x86_64 Native
Client.
On 2013/04/08 16:29:56, Brad
https://codereview.chromium.org/13704002/diff/1/src/platform-linux.cc
File src/platform-linux.cc (right):
https://codereview.chromium.org/13704002/diff/1/src/platform-linux.cc#newcode1084
src/platform-linux.cc:1084: // Profiling is disabled for x86_64 Native
Client.
On 2013/04/08 11:27:10, ulan
dit-restart-frame: SKIP
debug-liveedit-double-call: SKIP
+##
+# Native Client uses the ARM simulator so will behave similarly to arm
+# on mjsunit tests.
+# TODO(bradchen): enable more tests for NaCl V8 when it stops using
c
+++ b/src/platform-posix.cc
@@ -94,6 +94,12 @@ void OS::Guard(void* address, const size_t size) {
void* OS::GetRandomMmapAddr() {
+#if defined(__native_client__)
+ // TODO(bradchen): restore randomization once Native Client gets
+ // smarter about using mmap address hints.
+ //
Reviewers: danno, Jakob,
Message:
PTAL
Description:
A helper script for testing Native Client builds of V8.
This is modeled after tools/android-run.py. It is meant to be used
as a --command-prefix argument to tools/run-tests.py
BUG=2614
Please review this at https://codereview.chromium.org/1
Reviewers: danno, Jakob,
Message:
PTAL
Description:
A new Makefile for the Native Client V8 builds.
This was derived from Makefile.android
BUG=2614
Please review this at https://codereview.chromium.org/13561007/
SVN Base: git://github.com/v8/v8.git@master
Affected files:
A + Makefile.nac
On 2013/04/04 16:38:17, ulan wrote:
https://codereview.chromium.org/13520004/diff/2001/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):
https://codereview.chromium.org/13520004/diff/2001/src/arm/simulator-arm.cc#newcode1767
src/arm/simulator-arm.cc:1767: UNREACHABLE();
> Is it
On 2013/04/04 14:53:46, ulan wrote:
> I would need to know the variety of function prototypes that need to be
supported, not obvious to me from the code.
src/assembler.h defines builtin types that take doubles:
// Builtin that takes float arguments and returns an int.
// int f(dou
On 2013/04/04 11:36:26, danno wrote:
That's fine.
I briefly looked at the changes, and the one thing that sticks out is the
simulator changes that are really hard-switched on x64 NaCL. Is there any
way
to
unify the implementation so that they are common, even if that means
changing
the n
On 2013/04/03 23:39:47, Brad Chen wrote:
PTAL
I was thinking on the way home this might be easier to review in smaller
pieces,
although you would loose the big picture. Unless I hear objections from you
I
will break this into smaller pieces (tomorrow).
https://codereview.chromium.org/135
Reviewers: danno, Jakob, Michael Starzinger,
Message:
PTAL
Description:
Native Client builds of V8 on ia32 and x64.
This port uses the ARM code generator and interpreter to allow a
temporary low-performance solution pending availability of NaCl
JIT ports or a fast portable interpreter.
This pa
It appears as though I have done something to confuse the code review
system. I
will close this issue and upload a new patch.
Brad
On 2013/03/14 14:11:57, Brad Chen wrote:
Please feel free to add reviewers as you see fit.
https://codereview.chromium.org/12478009/
--
--
v8-dev mailing lis
Reviewers: danno,
Message:
Please feel free to add reviewers as you see fit.
Description:
WIP: Preliminary support for Native Client builds of V8 on ia32 and x64.
This port uses the ARM code generator and interpreter to allow a
temporary low-performance solution while we are waiting for NaCl JI
Looking at this more carefully...
https://codereview.chromium.org/12374065/diff/1/src/atomicops.h
File src/atomicops.h (right):
https://codereview.chromium.org/12374065/diff/1/src/atomicops.h#newcode61
src/atomicops.h:61: #if defined(__ILP32__) || defined(__APPLE__)
So, actually trying this in
On 2013/03/02 09:50:35, vapier wrote:
The change looks fine, although I don't quite understand the review process.
Does the V8 project have a notion of committers and owners and such? Or can
any
Chromium committer land changes?
https://codereview.chromium.org/12374065/
--
--
v8-dev mailing l
28 matches
Mail list logo
