[v8-dev] X87: initialize the FPU state for X87 in prologue. (issue 1317643009 by chunyang....@intel.com)

2015-09-07 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: initialize the FPU state for X87 in prologue. This CL is a fix for c0c3d866fb824290c24d4c2a14414019d844515f (r30606). In r30606, initialization of FPU implementation is not moved to prologue generation correctly. BUG= Please review

[v8-dev] X87: [runtime] Remove useless IN builtin. (issue 1325183003 by chunyang....@intel.com)

2015-09-06 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [runtime] Remove useless IN builtin. port 3dc9b122fa9f7d551e05f5b9d7415bcfdcac92db (r30582). original commit message: Similar to DELETE, the IN builtin is just a thin wrapper for %HasElement and %HasProperty anyway, and cannot be op

[v8-dev] X87: Reland Vector ICs: platform support for vector-based stores. (issue 1311413007 by chunyang....@intel.com)

2015-09-06 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Reland Vector ICs: platform support for vector-based stores. port 40fbed0609ddb3e4ee4338049383004b62d13853 (r30581) original commit message: The last changes for vector store functionality, they are in 3 areas: 1) The new vector [k

[v8-dev] X87: Remove obsolete functionality from the MacroAssemblers. (issue 1321653004 by chunyang....@intel.com)

2015-09-06 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Remove obsolete functionality from the MacroAssemblers. port 64e3bad3677d01d70ddcedd541619216b973e90d (r30577) original commit message: This is uncontroversial the dead code removal part of https://codereview.chromium.org/1307943013

[v8-dev] X87: [es6] Introduce a dedicated JSIteratorResult type. (issue 1331523002 by chunyang....@intel.com)

2015-09-06 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [es6] Introduce a dedicated JSIteratorResult type. port 72bc4b5c8a5c4279bcb8b340edbc8aa1c46d75a1 (r30557) original commit message: Use a single JSIteratorResult type for all implementation provided iterator results (i.e. the String,

[v8-dev] X87: [es6] Initial steps towards a correct implementation of IsCallable. (issue 1310653004 by chunyang....@intel.com)

2015-09-06 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [es6] Initial steps towards a correct implementation of IsCallable. port 8a378f46d52ce64578c71313ed76a67592fbf63c (r30552) original commit message: This turns the has_instance_call_handler bit on Map into an is_callable bit, that ma

[v8-dev] X87: [es6] Re-implement rest parameters via desugaring. (issue 1305943008 by chunyang....@intel.com)

2015-09-06 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [es6] Re-implement rest parameters via desugaring. port 510baeacbab311798d5e8795800ff773d00d062c (r30550) original commit message: Kills the kRestParameter bailout/disabled optimization, and fixes lazily parsed arrow functions with

[v8-dev] X87: Crankshaft is now able to compile top level code even if there is a ScriptContext. (issue 1308743005 by chunyang....@intel.com)

2015-09-06 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Crankshaft is now able to compile top level code even if there is a ScriptContext. port 29ebcc32052d486cbc1933ac4738aa5cb68aa851 (r30496). original commit message: This CL introduces HPrologue instruction which does the context alloca

[v8-dev] X87: [builtins] Pass correct number of arguments after adapting arguments. (issue 1304893010 by chunyang....@intel.com)

2015-09-06 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [builtins] Pass correct number of arguments after adapting arguments. port fbad63669e309e8c5c3f2ecf503df2fefaac79bb (r30467) original commit message: The call protocol requires that the register dedicated to the number of actual arg

[v8-dev] X87: [runtime] Add %ToString and %_ToString and remove the TO_STRING builtin. (issue 1326473002 by chunyang....@intel.com)

2015-08-31 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [runtime] Add %ToString and %_ToString and remove the TO_STRING builtin. port 09de997b3504368d40644afa7310b90faff5d09c (r30442). original commit message: This adds a new ToString runtime function and a fast-path ToStringStub (whi

[v8-dev] X87: [Interpreter] Add support for parameter variables. (issue 1324453003 by chunyang....@intel.com)

2015-08-28 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [Interpreter] Add support for parameter variables. port 5d975694e4d3ecf66716cc5395d4d10c9730f9dd (r30403) original commit message: Adds support for parameters to the BytecodeArrayBuilder and BytecodeGenerator. Parameters are acces

[v8-dev] X87: Correctify instanceof and make it optimizable. (issue 1318663003 by chunyang....@intel.com)

2015-08-25 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL. Description: X87: Correctify instanceof and make it optimizable. port 5d875a57fa2e65c1a4a6b50aeb23c38299c3cfbc (r30342). original commit message: The previous hack with HInstanceOfKnownGlobal was not only slower, but also very brittle and required a

[v8-dev] X87: [Interpreter] Pass context to interpreter bytecode handlers and add LoadConstextSlot (issue 1316583003 by chunyang....@intel.com)

2015-08-25 Thread chunyang . dai
Reviewers: Michael Starzinger, Weiliang, rmcilroy, Message: PTAL. Description: X87: [Interpreter] Pass context to interpreter bytecode handlers and add LoadConstextSlot For X87 platform, it has the same general register as ia32 and it will spill the context to the stack too. port bfdc

[v8-dev] Re: Version 4.6.85.2 (cherry-pick) (issue 1315533002 by chunyang....@intel.com)

2015-08-24 Thread chunyang . dai
Committed patchset #1 (id:1) manually as 720fb509e62c2227795cc0f60f05b46271da8de8. https://codereview.chromium.org/1315533002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v

[v8-dev] Version 4.6.85.2 (cherry-pick) (issue 1315533002 by chunyang....@intel.com)

2015-08-24 Thread chunyang . dai
Reviewers: Hablich, Description: Version 4.6.85.2 (cherry-pick) Merged 682365d77f954b879c9397587d118faa55218d0b Merged ab6751451dfba9f7d7ef6a17f60ac15556d6ede0 Merged 8116f95c965e31cbd9df1004ece619d252679a69 Merged 97a48c538d9ea746b1a3f3c41c23fd07ec7d50ec Merged 0afbd7add0a3035acbfcc40dc8894a1ed

[v8-dev] Re: X87: Disable test case for X87 because of double register number restriction. (issue 1308763003 by chunyang....@intel.com)

2015-08-23 Thread chunyang . dai
Hi, Titzer. I changed these two test cases to use "RegisterConfiguration::ArchDefault()->num_double_registers()" to do the double register number restriction check. It will not use "DoubleRegister::kMaxNumAllocatableRegisters" directly. Please review it. Thanks. https://codereview.chrom

[v8-dev] Re: X87: Disable test case for X87 because of double register number restriction. (issue 1308763003 by chunyang....@intel.com)

2015-08-21 Thread chunyang . dai
Hi, Titzer. thanks for your suggestion. These two test cases already have the following check: if (DoubleRegister::kMaxNumAllocatableRegisters < 2) return; But for x87 platform, it's a special case that crankshaft support many double registers so Double::kMaxNumAllocatableRegisters is defi

[v8-dev] X87: Cleanup: Remove unncessary leave_frame parameter from stub cache. (issue 1303973004 by chunyang....@intel.com)

2015-08-21 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Cleanup: Remove unncessary leave_frame parameter from stub cache. port fe432e1ace48c345c659c0bcb6a84798bca0b15e (r30250). original commit message: BUG= Please review this at https://codereview.chromium.org/1303973004/ Base URL: https://ch

[v8-dev] X87: VectorICs: New interface descriptor for vector transitioning stores. (issue 1303223002 by chunyang....@intel.com)

2015-08-21 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: VectorICs: New interface descriptor for vector transitioning stores. port cd35155918f8f1a081a208721a878deba00a252b (r30284). original commit message: BUG= Please review this at https://codereview.chromium.org/1303223002/ Base URL: https:/

[v8-dev] X87: [turbofan] Fix stack->stack double moves for pushing on ia32 and x64. (issue 1286123008 by chunyang....@intel.com)

2015-08-21 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [turbofan] Fix stack->stack double moves for pushing on ia32 and x64. port d0bacc61e6930d97888bf747a76bcfa329995847 (r30235). original commit message: BUG= Please review this at https://codereview.chromium.org/1286123008/ Base URL: https:

[v8-dev] X87: [turbofan] Unify referencing of stack slots (issue 1293103003 by chunyang....@intel.com)

2015-08-21 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [turbofan] Unify referencing of stack slots port cbbaf9ea6abbc0417ee5765a4c58f1dda939ead0 (r30224). original commit message: [turbofan] Unify referencing of stack slots Previously, it was not possible to specify StackSlotOperands f

[v8-dev] X87: [turbofan] Support unboxed float and double stack parameters and add tests. (issue 1306833002 by chunyang....@intel.com)

2015-08-21 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [turbofan] Support unboxed float and double stack parameters and add tests. port 0492bb3291c838d7e11261abc32af58bed58bcf0 (r30203). original commit message: BUG= Please review this at https://codereview.chromium.org/1306833002/ Base UR

[v8-dev] X87: Disable test case for X87 because of double register number restriction. (issue 1308763003 by chunyang....@intel.com)

2015-08-21 Thread chunyang . dai
Reviewers: titzer, Weiliang, Message: PTAL. Description: X87: Disable test case for X87 because of double register number restriction. These two test cases introduced by 8525136b require that the double register is =2. But currently on x87 turbofan implementation only 1 double register i

[v8-dev] X87: [interpreter]: Changes to interpreter builtins for accumulator and register file registers. (issue 1304593002 by chunyang....@intel.com)

2015-08-21 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [interpreter]: Changes to interpreter builtins for accumulator and register file registers. port 00df60d1c6943a10fb5ca84fce2c017dcd2001f5 (r30219). original commit message: Makes the following modifications to the interpreter builtin

[v8-dev] X87: [simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values. (issue 1304963003 by chunyang....@intel.com)

2015-08-21 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL. Description: X87: [simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values. port f4c079d450a5990639b295d40a3d1663d70412d6 (r30107). This is the appendix of 458dfe3b943edb3238917edfe9e2dde326cd1adb which misses one modified file. original commit message:

[v8-dev] Add per-file OWNERS for x87-specific cctests. (issue 1290963005 by chunyang....@intel.com)

2015-08-13 Thread chunyang . dai
Reviewers: Jakob, danno, Weiliang, Message: PTAL. Description: Add per-file OWNERS for x87-specific cctests. BUG= Please review this at https://codereview.chromium.org/1290963005/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+2, -0 lines): M test/cctest/OWNE

[v8-dev] Re: X87: Realize IWYU pattern for frames-inl.h header. (issue 1286143009 by chunyang....@intel.com)

2015-08-13 Thread chunyang . dai
Hello. Michael. PTAL. This porting patch needs one review from the owner of this file. thanks https://codereview.chromium.org/1286143009/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Goog

[v8-dev] X87: [compiler] Remove broken support for undetectable strings. (issue 1287173002 by chunyang....@intel.com)

2015-08-12 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [compiler] Remove broken support for undetectable strings. port b62dbf1efdec68ae709b0e91d3b7c13171b720c9 (r30132). original commit messge: Support for undetectable strings was officially dropped in https://codereview.chromium.org/91

[v8-dev] X87: Realize IWYU pattern for frames-inl.h header. (issue 1286143009 by chunyang....@intel.com)

2015-08-12 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Realize IWYU pattern for frames-inl.h header. port 19a49abf02dfac722dc8c5079aba9d73fcd60725 (r30127). original commit message: BUG= Please review this at https://codereview.chromium.org/1286143009/ Base URL: https://chromium.googlesource.

[v8-dev] X87: [simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values. (issue 1286313003 by chunyang....@intel.com)

2015-08-12 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values. port f4c079d450a5990639b295d40a3d1663d70412d6 (r30107). original commit message: There's no need to have one InstanceType per SIMD primitive type (this will not scale long-t

[v8-dev] Re: Version 4.5.103.15 (cherry-pick) (issue 1272133002 by chunyang....@intel.com)

2015-08-05 Thread chunyang . dai
Committed patchset #1 (id:1) manually as 71d2ce6b04113387360b4814b817ed046b14ebcf. https://codereview.chromium.org/1272133002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v

[v8-dev] Re: Version 4.5.103.15 (cherry-pick) (issue 1272133002 by chunyang....@intel.com)

2015-08-05 Thread chunyang . dai
Hi, Michael. I created one issue v8:4352 to track this issue according to the wiki. Please review it. Because my computer is restarted and my previous back-port session is closed. So I have to create this new CL. The original CL https://codereview.chromium.org/1254133005/ cannot be continue

[v8-dev] Version 4.5.103.15 (cherry-pick) (issue 1272133002 by chunyang....@intel.com)

2015-08-05 Thread chunyang . dai
Reviewers: Hablich, Description: Version 4.5.103.15 (cherry-pick) Merged 8ae236c0c4bcc7218f2f2dcf909c1410b9ce065e Fix the failure when enabling v8 profiler or vtune profiler in chromium. R=habl...@chromium.org BUG=v8:4352 Please review this at https://codereview.chromium.org/1272133002/ Base

[v8-dev] Re: Version 4.5.103.15 (cherry-pick) (issue 1254133005 by chunyang....@intel.com)

2015-08-03 Thread chunyang . dai
Hi, Hablich. Please help to check this porting patch. Thanks. https://codereview.chromium.org/1254133005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] X87: VectorICs: refactoring to eliminate "for queries only" vector ic mode. (issue 1265113002 by chunyang....@intel.com)

2015-08-02 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: VectorICs: refactoring to eliminate "for queries only" vector ic mode. port 1a5751f9b3ca682fadb6fce8202dda2db5b017c6 (r29956) original commit message: Since we need the notion of a dummy vector ic, we can use that to avoid a special

[v8-dev] X87: [turbofan] Fix kArchTailCallCodeObject on ia32/x64. (issue 1256163003 by chunyang....@intel.com)

2015-08-02 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [turbofan] Fix kArchTailCallCodeObject on ia32/x64. port ec9bc7947399e29429c3bdeaff070db2a4cc92f4 (r29949). original commit message: Previously these instructions tried to jump to the value at the code entry's location, rather th

[v8-dev] X87: [interpreter] Add Interpreter{Entry,Exit}Trampoline builtins. (issue 1271433002 by chunyang....@intel.com)

2015-07-30 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [interpreter] Add Interpreter{Entry,Exit}Trampoline builtins. port c5dd553cf3a44cd8c17958a595198b5ea9492cd0 (r29929). original commit message: Adds interpreter entry and exit trampoline builtins. Also implements the Return bytecode

[v8-dev] X87: [interpreter] Change interpreter to use an BytecodeArray pointer and and offset. (issue 1267783002 by chunyang....@intel.com)

2015-07-30 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [interpreter] Change interpreter to use an BytecodeArray pointer and and offset. port 597da503220ab2a632453d2e3a915e9824d6d592 (r29910). original commit message: Changes the interpreter to use a BytecodeArray pointer and an offset to

[v8-dev] Version 4.5.103.15 (cherry-pick) (issue 1254133005 by chunyang....@intel.com)

2015-07-30 Thread chunyang . dai
Reviewers: ulan, Description: Version 4.5.103.15 (cherry-pick) Merged 8ae236c0c4bcc7218f2f2dcf909c1410b9ce065e Fix the failure when enabling v8 profiler or vtune profiler in chromium. R=u...@chromium.org BUG= Please review this at https://codereview.chromium.org/1254133005/ Base URL: https:/

[v8-dev] Fix the failure when enabling v8 profiler or vtune profiler in chromium. (issue 1270493002 by chunyang....@intel.com)

2015-07-30 Thread chunyang . dai
Reviewers: ulan, Message: PTAL. Description: Fix the failure when enabling v8 profiler or vtune profiler in chromium. When enabling the v8 profiler (Using the following command parameters: --js-flags=--prof) or vtune profiling in chromium. it will break. This failure is introduced by t

[v8-dev] X87: [stubs] Properly handle read-only properties in StoreGlobalViaContextStub. (issue 1263473002 by chunyang....@intel.com)

2015-07-28 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [stubs] Properly handle read-only properties in StoreGlobalViaContextStub. port cac64b9f634743f7f5311d4dca8d50157b10fab5 (r29881) original commit message: We don't need the hole check and slow runtime mode for read-only propertie

[v8-dev] X87: [stubs] Don't pass name to Load/StoreGlobalViaContext stubs. (issue 1259063004 by chunyang....@intel.com)

2015-07-28 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [stubs] Don't pass name to Load/StoreGlobalViaContext stubs. port 5dff4bdff06c0463db1e876af7541af2b715392c (r29886). original commit message: No need to pass the name explicitly to the stubs; the runtime can extract the name from th

[v8-dev] X87: VectorICs: vector [keyed]store ic MISS handling infrastructure. (issue 1257883003 by chunyang....@intel.com)

2015-07-28 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: VectorICs: vector [keyed]store ic MISS handling infrastructure. port a913f4bf5c40ef88c52e7cf821540f0faf5524f9 (r29870). original commit message: BUG= Please review this at https://codereview.chromium.org/1257883003/ Base URL: https://chro

[v8-dev] X87: implement MathPow stub for X87. (issue 1258873002 by chunyang....@intel.com)

2015-07-27 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL. Description: X87: implement MathPow stub for X87. In CL 0fe2fbd173c5e547e021476428001cac6fcdf7a9 the implementation of MathPow for all ports are unified and MathPow stub code is invoked. So we move the direct runtime function call from full-codegen to M

[v8-dev] X87: [stubs] Optimize LoadGlobalViaContextStub and StoreGlobalViaContextStub. (issue 1258513003 by chunyang....@intel.com)

2015-07-24 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [stubs] Optimize LoadGlobalViaContextStub and StoreGlobalViaContextStub. port d6ee366d5c5aef7c6bc550889a33520058b4e33a (r29834). original commit message: This is the initial round of optimizations for the LoadGlobalViaContextStu

[v8-dev] X87: [interpreter] Add basic framework for bytecode handler code generation. (issue 1256783002 by chunyang....@intel.com)

2015-07-24 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [interpreter] Add basic framework for bytecode handler code generation. port 7877c4e0c77b5c2b97678406eab7e9ad6eba4a4d (r29814). original commit message: Adds basic support for generation of interpreter bytecode handler code snippets

[v8-dev] X87: Unify "runtime-style" IC functions with Runtime intrinsics (issue 1252903002 by chunyang....@intel.com)

2015-07-24 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Unify "runtime-style" IC functions with Runtime intrinsics port bc8041dc2b4c8431c5c2476496acd3b7b8b3f61e (r29811). original commit message: Previous to this CL, ICs used a slightly different code idiom to get to C++ code from genera

[v8-dev] X87: HydrogenCodeStubs consume stack arguments via descriptor. (issue 1258553002 by chunyang....@intel.com)

2015-07-24 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: HydrogenCodeStubs consume stack arguments via descriptor. port 3334b830a512eda1f8eed678a0e6fda52b23472a (r20813). original commit message: HydrogenCodeStubs consume stack arguments via descriptor. All of this is controlled by the C

[v8-dev] X87: Eliminate redundant descriptor ElementTransitionAndStoreDescriptor. (issue 1253573004 by chunyang....@intel.com)

2015-07-23 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Eliminate redundant descriptor ElementTransitionAndStoreDescriptor. port 26ffee2c718308bb85be072ed32479e4aa8e7e6b (r29789). original commit message: It's just the same as StoreTransitionDescriptor. BUG= Please review this at https://c

[v8-dev] X87: Fix pushing of register in CallConstructStub outside frame. (issue 1247493004 by chunyang....@intel.com)

2015-07-23 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Fix pushing of register in CallConstructStub outside frame. port 1f295980b7ac309dcef732088ae363722277a408 (r29787). original commit message: This fixes a recent regression where the register holding the original receiver was pushed

[v8-dev] X87: Debugger: prepare code for debugging on a per-function basis. (issue 1249503002 by chunyang....@intel.com)

2015-07-20 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Debugger: prepare code for debugging on a per-function basis. port 35c28ce0a742e58346d2dea009428cacd442040d (r29758). original commit message: Prior to this patch, we enter a global debug mode whenever a break point is set. By enter

[v8-dev] X87: Fix memento initialization when constructing from new call (issue 1229023003 by chunyang....@intel.com)

2015-07-17 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL. Description: X87: Fix memento initialization when constructing from new call port 3285e3bf071a2575a827c5b29fe389a72dbf8966 (r29719). original commit message: Additionally, push the allocation site or undefined independently of creatin BUG= Please rev

[v8-dev] X87: Switch CallConstructStub to take new.target in register. (issue 1235273003 by chunyang....@intel.com)

2015-07-16 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Switch CallConstructStub to take new.target in register. original commit message: This changes the calling convention of the CallConstructStub to take the original constructor (i.e. new.target in JS-speak) in a register instead o

[v8-dev] X87: Debugger: use debug break slots to break at function exit. (issue 1236023007 by chunyang....@intel.com)

2015-07-16 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Debugger: use debug break slots to break at function exit. port fc9c5275c3a747caca709b7d5745579f70e61301 (r29672). original commit message: Debugger: use debug break slots to break at function exit. By not having to patch the retur

[v8-dev] Re: Version 4.5.103.6 (cherry-pick) (issue 1228353003 by chunyang....@intel.com)

2015-07-14 Thread chunyang . dai
Committed patchset #1 (id:1) manually as c5e3a96b83741115bf25847ed23bc20f0daf55f7. https://codereview.chromium.org/1228353003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v

[v8-dev] Version 4.5.103.6 (cherry-pick) (issue 1228353003 by chunyang....@intel.com)

2015-07-14 Thread chunyang . dai
Reviewers: Hablich, Description: Version 4.5.103.6 (cherry-pick) Merged a02e644c50289e4a141799a4a612a3374eeb26ad X87: [turbofan] Add TruncationMode for TruncateFloat64ToInt32. R=habl...@chromium.org BUG= Please review this at https://codereview.chromium.org/1228353003/ Base URL: https://chro

[v8-dev] X87: Fix keyed element access wrt string wrappers (issue 1233033004 by chunyang....@intel.com)

2015-07-13 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Fix keyed element access wrt string wrappers port 01f40e6ad6c8137708955494987857fbe489616b (r29618). original commit message: BUG= Please review this at https://codereview.chromium.org/1233033004/ Base URL: https://chromium.googlesource.c

[v8-dev] X87: Cleanup Generate_JSConstructStubHelper a bit. (issue 1237013002 by chunyang....@intel.com)

2015-07-13 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL> Description: X87: Cleanup Generate_JSConstructStubHelper a bit. port 6ddcd32786dfafc968558ea59c0ca7588c45ebed (r29617) original commit message: Cleanup Generate_JSConstructStubHelper a bit. BUG= Please review this at https://codereview.chromium.org/1237

[v8-dev] X87: [turbofan] Add an InterpreterDispatch linkage type. (issue 1232383003 by chunyang....@intel.com)

2015-07-13 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [turbofan] Add an InterpreterDispatch linkage type. port a0129a25ba2f4d00138887cb2008d5b76e2b0068 (r29591). original commit message: BUG= Please review this at https://codereview.chromium.org/1232383003/ Base URL: https://chromium.googles

[v8-dev] X87: Debugger: record reloc info for debug break slot immediate before the slot. (issue 1228923003 by chunyang....@intel.com)

2015-07-13 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Debugger: record reloc info for debug break slot immediate before the slot. port 0a19e44925301b9c0a554bbec5e3fb5a6cd09efa (r29568) original commit message: If we do it too early, we might get a constant pool between the reloc info

[v8-dev] X87: Remove separate construct stub for new.target users. (issue 1232833002 by chunyang....@intel.com)

2015-07-13 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Remove separate construct stub for new.target users. port e50c861b099b3bd3e1174b5f2843567620cc6842 (r29562) original commit message: BUG= Please review this at https://codereview.chromium.org/1232833002/ Base URL: https://chromium.googles

[v8-dev] X87: Debugger: use debug break slot to break on call. (issue 1233823002 by chunyang....@intel.com)

2015-07-13 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL. Description: X87: Debugger: use debug break slot to break on call. port 8965b683ce39bc3c24ed2466d189323d81a70852 (r29561) original commit message: Break point at calls are currently set via IC. To change this, we need to set debug break slots instea

[v8-dev] X87: Reland: Add unoptimized/optimized variants of MathFloor TF code stub (issue 1235823002 by chunyang....@intel.com)

2015-07-13 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Reland: Add unoptimized/optimized variants of MathFloor TF code stub port 737b8573f80deaa1cbaec98f42ecd3e3b56ba901 (r29539) original commit message: - Add a TurboFanIC class, derived from TurboFanCodeStub, that automatically disti

[v8-dev] X87: [turbofan] Add TruncationMode for TruncateFloat64ToInt32. (issue 1227923003 by chunyang....@intel.com)

2015-07-13 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [turbofan] Add TruncationMode for TruncateFloat64ToInt32. port 4b38c15817033ccd9a65efbb3d038ae2423293c2 (r29527). original commit message: We actually need round to zero truncation to implement the counterpart of LDoubleToI in Turbo

[v8-dev] X87: Debugger: use debug break slots instead of ICs (except for calls). (issue 1227603002 by chunyang....@intel.com)

2015-07-06 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL. Description: X87: Debugger: use debug break slots instead of ICs (except for calls). port a8a4c364c2ad4c1e5f4c6e1f1580d75ff1a35a4f (r29487). original commit message: BUG= Please review this at https://codereview.chromium.org/1227603002/ Base URL: https://

[v8-dev] Re: X87: [turbofan] Enable tail calls for %_CallRuntime. (issue 1228463003 by chunyang....@intel.com)

2015-07-06 Thread chunyang . dai
Committed patchset #1 (id:1) manually as 19e53974c46d41f73f61636be2397b3bc6725375 (presubmit successful). https://codereview.chromium.org/1228463003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] X87: [turbofan] Enable tail calls for %_CallRuntime. (issue 1228463003 by chunyang....@intel.com)

2015-07-05 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL. Description: X87: [turbofan] Enable tail calls for %_CallRuntime. port 1fa4285e1ce16cfadf8c40a0993491ec4e2bbbe0 (r29436). original commit message: This involves: - Enabling the tail call optimization reducer in all cases. - Adding an addition fl

[v8-dev] X87: [strong] Implement strong property access semantics. (issue 1210873007 by chunyang....@intel.com)

2015-07-01 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL. Description: X87: [strong] Implement strong property access semantics. port 7281f8015181736703d3663c9c570be537f008c1 (r29384) Fix a bug in R29384. original commit message: Revert "Revert relanded strong property access CL" Regression issues sh

[v8-dev] X87: Make context register implicit for CallInterfaceDescriptors (issue 1216543004 by chunyang....@intel.com)

2015-07-01 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Make context register implicit for CallInterfaceDescriptors port 7015fd20531ee8498352f82d626c78023a1f6857 (r29402) original commit message: Up until now the context register was listed explicitly in each stub's CallInterfaceDescript

[v8-dev] X87: [turbofan] Add CalleeSavedFPRegisters to CallDescriptor. (issue 1214573006 by chunyang....@intel.com)

2015-07-01 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [turbofan] Add CalleeSavedFPRegisters to CallDescriptor. port b4275a70eb1e6b6dc0f3c77b9be6bcfca3f80c20 (r29378) original commit message: This change makes possible to save and restore the FP registers in the Prologue and Return part

[v8-dev] X87: [es6] Make new.target work in functions. (issue 1217083004 by chunyang....@intel.com)

2015-06-30 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL. Description: X87: [es6] Make new.target work in functions. port 7a63bf77eb7610afdc1a968f7660781e5160ba8d (r29358). original commit message: This makes new.target work in [[Call]] and [[Construct]] of ordinary functions. We achieve this by intro

[v8-dev] X87: VectorICs: Lithium support for vector-based stores. (issue 1213373002 by chunyang....@intel.com)

2015-06-30 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL> Description: X87: VectorICs: Lithium support for vector-based stores. port 8a3cf4ecef1fce76137270845604292bdbdadcd4 (r29310). BUG= Please review this at https://codereview.chromium.org/1213373002/ Base URL: https://chromium.googlesource.com/v8/v8.git@maste

[v8-dev] X87: Unify the stack layout for construct frames. (issue 1219823002 by chunyang....@intel.com)

2015-06-30 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL> Description: X87: Unify the stack layout for construct frames. port 876ae425980f67f489323671f13d2314b0ce0a91 (r29292). original commit message: The stack layout was different for different ports. BUG= Please review this at https://codereview.chromium.o

[v8-dev] X87: Vector ICs: Like megamorphic keyed koads, use a dummy vector for stores. (issue 1212653011 by chunyang....@intel.com)

2015-06-30 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Vector ICs: Like megamorphic keyed koads, use a dummy vector for stores. port 9e7af9efc5857b3c7e23a77d257f3dfbea597753 (r29280). original commit message: It's useful for the megamorphic keyed store case to not require a vector an

[v8-dev] X87: [ic] Record call counts for monomorphic calls made with an IC. (issue 1213723005 by chunyang....@intel.com)

2015-06-30 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL. Description: X87: [ic] Record call counts for monomorphic calls made with an IC. port c1a4f7477f03ebb0c6889bbf8ea6a4c928e0d413 (r29281). original commit message: The idea is that TurboFan can use this information for more intelligent inlining. BUG=

[v8-dev] X87: [turbofan] Add basic support for calling to (a subset of) C functions. (issue 1214903007 by chunyang....@intel.com)

2015-06-30 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [turbofan] Add basic support for calling to (a subset of) C functions. port a58ba8d80179bf5b6b7245590c82e47fda8c8a5e (r29279). original commit message: This introduces some initial building blocks for calling out to C/C++ functions

[v8-dev] X87: Use big-boy Types to annotate interface descriptor parameters. (issue 1210463002 by chunyang....@intel.com)

2015-06-30 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL. Description: X87: Use big-boy Types to annotate interface descriptor parameters. port c019d7f498ce6fbac6659924e20ddb6c59aebeb8 (r29248). original commit message: Use big-boy Types to annotate interface descriptor parameters - Thread Type::FunctionT

[v8-dev] X87: change the float max/min operation. (issue 1214893004 by chunyang....@intel.com)

2015-06-30 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL. Description: X87: change the float max/min operation when operands. This CL fixes the following situations: 1, Operands are -0.0 or 0.0. it always return right value. 1, Operands contains NaN. it always return right value. BUG= Please review this

[v8-dev] X87: Do not add extra argument for new.target. (issue 1207613003 by chunyang....@intel.com)

2015-06-30 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Do not add extra argument for new.target. port 8196c28a94f62dec026f2b564ba81d690a4ed593 (r29238). original commit message: JSConstructStub for subclass constructors instead locates new.target in a known location on the stack. BUG= Ple

[v8-dev] X87: Clean up JSConstructStub. (issue 1210153007 by chunyang....@intel.com)

2015-06-30 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Clean up JSConstructStub. port 882055ff6a58f6b585575229f40f364e5f2a3ad0 (r29082). The original CL covers part of X87 port. This CL addes the missing changes. original commit message: - fix truthfulness of comments - use Initial

[v8-dev] X87: Vector ICs: Turbofan vector store ic support (issue 1195793007 by chunyang....@intel.com)

2015-06-22 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Vector ICs: Turbofan vector store ic support port 17c8ffeaa3e4e1769f0b4d0e7c8a6fb26b5297bd (r29173) original commit message: Vector ICs: Turbofan vector store ic support Turbofan needs to pass vector slots around for named and keye

[v8-dev] X87: Built-in apply() performance benefits from an uninitialized IC. (issue 1199913007 by chunyang....@intel.com)

2015-06-22 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Built-in apply() performance benefits from an uninitialized IC. port 2a3b05758721a2f63a7c611ef22e364ead9ed0f3 (r29175). original commit message: Built-in apply() performance benefits from an uninitialized IC. BUG= Please review this at

[v8-dev] X87: Revert of Revert of [strong] Implement strong mode restrictions on property access. (issue 1197593002 by chunyang....@intel.com)

2015-06-18 Thread chunyang . dai
Reviewers: Toon Verwaest, Weiliang, Message: PTAL Description: X87: Revert of Revert of [strong] Implement strong mode restrictions on property access. port 41405c0470d5b30ec5d22665ed9430c46b33624f (r29122). fix spelling error in r29122. BUG= Please review this at https://codereview.ch

[v8-dev] Re: Version 4.3.61.29 (cherry-pick) (issue 1186043002 by chunyang....@intel.com)

2015-06-15 Thread chunyang . dai
Committed patchset #1 (id:1) manually as 6febfc4f4366f92427b28d825c3dfa94f11736e4. https://codereview.chromium.org/1186043002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v

[v8-dev] Re: X87: enable the X87 turbofan support. (issue 1179763004 by chunyang....@intel.com)

2015-06-14 Thread chunyang . dai
Hello, Danno & Titizer. PTAL. thanks. https://codereview.chromium.org/1179763004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this gro

[v8-dev] X87: enable the X87 turbofan support. (issue 1179763004 by chunyang....@intel.com)

2015-06-14 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL. Description: X87: enable the X87 turbofan support. This patch includes the following changes. 1, Enable the turbofan backend support for X87 platform. It depends on previous CL: 3fdfebd26. 2, Enable the test cases which are disabled because tu

[v8-dev] Version 4.3.61.29 (cherry-pick) (issue 1186043002 by chunyang....@intel.com)

2015-06-14 Thread chunyang . dai
Reviewers: mvstanton, Description: Version 4.3.61.29 (cherry-pick) Merged 9bf64f7e614d55766385c122a99c1e7070cd9d2b X87: Ensure object literal element boilerplates aren't modified. R=mvstan...@chromium.org BUG= Please review this at https://codereview.chromium.org/1186043002/ Base URL: https:

[v8-dev] Re: X87: [strong] Refactor ObjectStrength into a replacement for strong boolean args (issue 1173973002 by chunyang....@intel.com)

2015-06-11 Thread chunyang . dai
Committed patchset #1 (id:1) manually as 7e59d2603fc12fac615f3ae2d5197a52191ee99d (presubmit successful). https://codereview.chromium.org/1173973002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: X87: Vector ICs: ClassLiterals need to allocate a vector slot for home objects. (issue 1178533002 by chunyang....@intel.com)

2015-06-11 Thread chunyang . dai
Committed patchset #1 (id:1) manually as 3df35e3f94c67cd0d08586ef4ad5f931ac3d8017 (presubmit successful). https://codereview.chromium.org/1178533002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: X87: Vector ICs: debugger should save registers for vector store ics. (issue 1173963002 by chunyang....@intel.com)

2015-06-11 Thread chunyang . dai
Committed patchset #1 (id:1) manually as 2dd269f39ae6ceb5bdd040dae3a71980a1e652c2 (presubmit successful). https://codereview.chromium.org/1173963002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: X87: Refactor lexical home object binding. (issue 1173933005 by chunyang....@intel.com)

2015-06-11 Thread chunyang . dai
Committed patchset #1 (id:1) manually as 9afacc320f3f047a187c21e5387d37029bb1e487 (presubmit successful). https://codereview.chromium.org/1173933005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: X87: [date] Refactor the %_DateField intrinsic to be optimizable. (issue 1174913002 by chunyang....@intel.com)

2015-06-11 Thread chunyang . dai
Committed patchset #1 (id:1) manually as c8b7c2496d38a220354a54278a64655fce898b9f (presubmit successful). https://codereview.chromium.org/1174913002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: X87: Disable the test case for X87 since ea2cb139d. (issue 1179763003 by chunyang....@intel.com)

2015-06-11 Thread chunyang . dai
Danno. PTAL. thanks https://codereview.chromium.org/1179763003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiv

[v8-dev] Re: Add API to configure double register number for Turbofan. (issue 1164813007 by chunyang....@intel.com)

2015-06-11 Thread chunyang . dai
hi, Titzer. The reason why I use one API here is that maybe we will change the available double register here in the future if we find solution to support more double register on X87 platform. Then we do not need to touch the common code. We can configure it on X87 specific code. Anyway, I u

[v8-dev] X87: Disable the test case for X87 since ea2cb139d. (issue 1179763003 by chunyang....@intel.com)

2015-06-11 Thread chunyang . dai
Reviewers: conradw, Message: PTAL. Description: X87: Disable the test case for X87 since ea2cb139d. The overwrite-builtins test cases will throw one expected exception and the exception message should include the source position in the JS file. But crankshaft compiler does not

[v8-dev] X87: [strong] Refactor ObjectStrength into a replacement for strong boolean args (issue 1173973002 by chunyang....@intel.com)

2015-06-11 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [strong] Refactor ObjectStrength into a replacement for strong boolean args port dd8544495109804c632bfbcefc3c5c701e0a8c43 (r28839) original commit message: Boolean "is_strong" parameters have begun to proliferate across areas where

[v8-dev] X87: Vector ICs: ClassLiterals need to allocate a vector slot for home objects. (issue 1178533002 by chunyang....@intel.com)

2015-06-11 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL. Description: X87: Vector ICs: ClassLiterals need to allocate a vector slot for home objects. port b27016b78a7dd58dc682eed51500ba603b3e46b0 (r28827). original commit message: BUG= Please review this at https://codereview.chromium.org/1178533002/ Base UR

[v8-dev] X87: Vector ICs: debugger should save registers for vector store ics. (issue 1173963002 by chunyang....@intel.com)

2015-06-11 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL. Description: X87: Vector ICs: debugger should save registers for vector store ics. port bd32a9f711cb14c2b7c34512d43e78bd24960124 (r28825). original commit message: BUG= Please review this at https://codereview.chromium.org/1173963002/ Base URL: https://ch

[v8-dev] X87: Refactor lexical home object binding. (issue 1173933005 by chunyang....@intel.com)

2015-06-11 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: Refactor lexical home object binding. port 345fa142a9fca4b468417350ac26f61101d626e8 (r28802). port of r28769 overwrite some of r28802 so we port them again. original commit message: Before this we had 3 super related lexical bindin

[v8-dev] X87: [date] Refactor the %_DateField intrinsic to be optimizable. (issue 1174913002 by chunyang....@intel.com)

2015-06-11 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL Description: X87: [date] Refactor the %_DateField intrinsic to be optimizable. port e4782a9b468258344d512a5f7dadbf1584928849 (r28782) original commit message: Previously the %_DateField intrinsic would also check the object and throw an exception if

  1   2   3   4   5   >