Addressed feedback, landing.
https://codereview.chromium.org/729913004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
https://codereview.chromium.org/729913004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
On 2016/05/12 17:19:06, dingding wrote:
On 2016/05/12 10:33:04, danno wrote:
> PTAL. I almost accidentally deleted my local copy, so although I'm still
pretty
> ashamed of the .js code, I want to get it somewhere permanent.
Danno, the file referred in index.html
(https://
Reviewers: Michael Starzinger
CL: https://codereview.chromium.org/729913004/
Message:
PTAL. I almost accidentally deleted my local copy, so although I'm still
pretty
ashamed of the .js code, I want to get it somewhere permanent.
Description:
Add a html-based visualizer for TurboFan graphs
Ba
We now have a plan to get coverage on armv8 via the simulator and a bot.
lgtm.
https://codereview.chromium.org/1223613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-
A revert of this CL (patchset #20 id:380001) has been created in
https://codereview.chromium.org/1380863004/ by da...@chromium.org.
The reason for reverting is: Failures on MIPS.
https://codereview.chromium.org/1287383003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.c
Reviewers: akos.palfi.imgtec, Benedikt Meurer, Jarin, paul.l..., titzer,
Message:
Created Revert of Reland: Remove register index/code indirection
Description:
Revert of Reland: Remove register index/code indirection (patchset #20
id:380001
of https://codereview.chromium.org/1287383003/ )
Re
A revert of this CL (patchset #17 id:320001) has been created in
https://codereview.chromium.org/1365073002/ by da...@chromium.org.
The reason for reverting is: Failures on greedy RegAlloc, Fuzzer.
https://codereview.chromium.org/1287383003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
htt
Reviewers: akos.palfi.imgtec, Benedikt Meurer, Jarin, paul.l..., titzer,
Message:
Created Revert of Remove register index/code indirection
Description:
Revert of Remove register index/code indirection (patchset #17 id:320001 of
https://codereview.chromium.org/1287383003/ )
Reason for revert:
Fa
Stray test case change fixed, Jaro, any feedback?
https://codereview.chromium.org/1287383003/diff/31/test/mjsunit/regress/regress-crbug-513507.js
File test/mjsunit/regress/regress-crbug-513507.js (right):
https://codereview.chromium.org/1287383003/diff/31/test/mjsunit/regress/regress-cr
On 2015/09/22 at 17:41:17, bmeurer wrote:
As discussed offline earlier, I'm fine with the patch overall; it'll
simplify
things long-term and I think it's important that we tackle such issues. I'm
not
sure about some of the details, but I feel like I have to see this "in the
wild"
to come up
With the MIPS port complete, I think this is ready for a first review, PTAL
https://codereview.chromium.org/1287383003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev"
On 2015/09/15 at 22:19:32, akos.palfi wrote:
Hi Danno,
We've fixed the remaining bugs, the latest patchset shows no test
failures. I
also had to modify the test-run-native-calls.cc to use the allocatable reg
codes
everywhere instead of the raw indices (on MIPS the 0 and 1 indice
On 2015/09/15 at 02:09:46, paul.lind wrote:
Hey Danno - Akos mentioned the MIPS port CL. We still have bugs in
test-run-native-calls. If you want to land this now, you can add that to the
skip list for mips & mips64:
'test-run-native-calls/*': [SKIP],
Everything else bui
Reviewers: titzer, Benedikt Meurer, Jarin,
Message:
This is cleanup/refactoring that makes it possible to use register codes in
the
register allocator rather than allocation indices.
Although I think the cleanup is useful, it has turned into a bit of a
monster
and would like to get your opi
Feedback addressed. I'll land this when all of the try bots are green.
https://codereview.chromium.org/1261923007/diff/290027/src/compiler/frame.h
File src/compiler/frame.h (right):
https://codereview.chromium.org/1261923007/diff/290027/src/compiler/frame.h#newcode44
src/compiler/frame.h:44: //
Reviewers: Jarin,
Message:
PTAL
Description:
[turbofan]: Fix bug in register hinting
Previously, UsePositions for Phis that are constant LiveRanges which are
also
used
as hints for other USePositions would always force-allocate the first
register
in
the allocatable register file to that r
lgtm
https://codereview.chromium.org/1292743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Benedikt Meurer, Jarin, titzer,
Message:
PTAL, I think it's ready to go
Description:
[turbofan]: Unify referencing of stack slots
Previously, it was not possible to specify StackSlotOperands for all
slots in both the caller and callee stacks. Specifically, the region
of the callee's
lgtm
https://codereview.chromium.org/1269913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Feedback addressed... landing.
https://codereview.chromium.org/1262343002/diff/40001/src/compiler/linkage.h
File src/compiler/linkage.h (right):
https://codereview.chromium.org/1262343002/diff/40001/src/compiler/linkage.h#newcode61
src/compiler/linkage.h:61: class IsRegisterField : public BitFi
Reviewers: Benedikt Meurer, titzer,
Message:
PTAL
Description:
[turbofan]: Add better encapsulation to LinkageLocation
Add factory methods for different types of LinkageLocations, and ensure that
accesses to the underlying data in the location are classified by type and
funneled through explici
Reviewers: Michael Starzinger,
Message:
PTAL
Description:
Tail call from TurboFan into select runtime calls
Please review this at https://codereview.chromium.org/1254073003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+33, -0 lines):
M src/compiler/js-contex
Reviewers: Benedikt Meurer, titzer,
Message:
Not for landing yet, but I'd appreciate feedback before doing the rest of
the
platform ports.
Description:
[turbofan]: Implement tail calls with differing stack parameter counts
WORK IN PROGRESS, I'D APPRECIATE FEEDBACK BEFORE DOING THE OTHER PLAT
lgtm
https://codereview.chromium.org/1255953003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2015/07/27 at 16:21:11, michael_dawson wrote:
On 2015/07/27 16:05:32, mtbrandyberry wrote:
lgtm.
NOT LGTM. I don't see john.yan1...@gmail.com in our CLA signer list, which
is a
prerequisite for committing changes.
If John is contributing as an IBM employee, he should use an ibm.com
lgtm
https://codereview.chromium.org/1245023003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2015/07/24 at 06:02:46, bmeurer wrote:
NOT LGTM. This change is not correct, because the stack pointer is not
constant across a function (at the instruction level). We currently have
explicit Push operations there, and we might have other things in the
future.
Plus we are still not sure whe
On 2015/07/23 at 07:02:32, mvstanton wrote:
ping.
Sorry for the long review, I didn't see it until your ping. My bad.
LGTM with a nit. Go ahead and land the entire CL if you like rather than
breaking it up, it all looks reasonable.
https://codereview.chromium.org/1250563004/
--
--
v8-dev mai
Feedback addressed. Landing.
https://codereview.chromium.org/1248303002/diff/60001/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):
https://codereview.chromium.org/1248303002/diff/60001/src/runtime/runtime-debug.cc#newcode19
src/runtime/runtime-debug.cc:19: RUNTIME_FUNCTI
Reviewers: Michael Starzinger, Yang,
Message:
PTAL
Description:
Unify "runtime-style" IC functions with Runtime intrinsics
Previous to this CL, ICs used a slightly different code idiom
to get to C++ code from generated code than runtime intrinsics,
using an IC_Utility class that in essence prov
Reviewers: jarin, titzer,
Message:
PTAL
Description:
[turbofan]: Elide extra move when accessting stack or frame register
Before this CL, the kFramePointer and kStackPointer IR instructions in
turbo fan
moved the values of the frame and stack pointers into explicitly allocated
temporary regi
On 2015/07/21 at 11:48:52, titzer wrote:
https://codereview.chromium.org/1245523002/diff/11/test/unittests/compiler/linkage-tail-call-unittest.cc
File test/unittests/compiler/linkage-tail-call-unittest.cc (right):
https://codereview.chromium.org/1245523002/diff/11/test/unittests/compi
https://codereview.chromium.org/1245523002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, sen
Feedback addressed. Landing.
https://codereview.chromium.org/1244583003/diff/20001/src/compiler/js-context-relaxation.cc
File src/compiler/js-context-relaxation.cc (right):
https://codereview.chromium.org/1244583003/diff/20001/src/compiler/js-context-relaxation.cc#newcode30
src/compiler/js-cont
Reviewers: titzer,
Message:
PTAL
Description:
[turbofan]: Fix tail calls edge cases and add tests
Please review this at https://codereview.chromium.org/1245523002/
Base URL: https://chromium.googlesource.com/v8/v8.git@1220823004
Affected files (+468, -4 lines):
M src/compiler/linkage.cc
A
Reviewers: Benedikt Meurer, Michael Starzinger,
Message:
PTAL.
This implements the new strategy as we discussed.
Description:
[turbofan]: Add a context relaxation Reducer
In many cases, the context that TurboFan's ASTGraphBuilder or subsequent
reduction operations attaches to nodes does not ne
On 2015/07/13 at 11:29:15, jochen wrote:
the change per se looks good
Danno, should we take this in?
I am willing to give this the OK as soon as we know we have adequate
coverage.
https://codereview.chromium.org/1223613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http
Reviewers: Benedikt Meurer,
Message:
Please take a look
Description:
[turbofan] Use context specialization in code stubs
Please review this at https://codereview.chromium.org/1226503005/
Base URL: https://chromium.googlesource.com/v8/v8.git@1213203007
Affected files (+1, -0 lines):
M src/co
Feedback addressed, landing
https://codereview.chromium.org/1213203007/diff/280001/src/snapshot/serialize.cc
File src/snapshot/serialize.cc (right):
https://codereview.chromium.org/1213203007/diff/280001/src/snapshot/serialize.cc#newcode1194
src/snapshot/serialize.cc:1194: case kNativesStringRe
On 2015/07/10 at 08:18:57, yangguo wrote:
serializer part lgtm with comments.
https://codereview.chromium.org/1213203007/diff/280001/src/snapshot/serialize.cc
File src/snapshot/serialize.cc (right):
https://codereview.chromium.org/1213203007/diff/280001/src/snapshot/serialize.cc#newcode119
Please take another look
https://codereview.chromium.org/1213203007/diff/220001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/1213203007/diff/220001/src/bootstrapper.cc#newcode1106
src/bootstrapper.cc:1106:
On 2015/07/08 08:32:53, Yang wrote:
Do you real
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1220783006/ by da...@chromium.org.
The reason for reverting is: Failure on compiling runtime.js on windows.
https://codereview.chromium.org/1225943002/
--
--
v8-dev mailing list
v8-dev@googlegroups.co
Reviewers: mvstanton, Benedikt Meurer,
Message:
Created Revert of Add unoptimized/optimized variants of MathFloor TF code
stub
Description:
Revert of Add unoptimized/optimized variants of MathFloor TF code stub
(patchset
#4 id:60001 of https://codereview.chromium.org/1225943002/)
Reason f
Feedback addressed.
https://codereview.chromium.org/1225943002/diff/20001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/1225943002/diff/20001/src/code-stubs.h#newcode102
src/code-stubs.h:102: V(MathFloor) \
On 2015/07/08 09:42:29, m
Reviewers: mvstanton, Benedikt Meurer,
Message:
PTAL
Description:
Add unoptimized/optimized variants of MathFloor TF code stub
- Add a TurboFanIC class, derived from TurboFanCodeStub, that
automatically distinguishes between versions of the IC called from
optimized and unoptimized code.
- A
Reviewers: Yang, Benedikt Meurer, Michael Starzinger,
Message:
Please take a look, with special focus on:
- Yang: Serialization changes
- Michi: Boostrapper changes
- Benedikt: Code stub generation changes
Description:
Create a internal native context used only for TF- generated code stubs
Un
Reviewers: Benedikt Meurer,
Message:
PTAL
Description:
[turbofan]: Inline %_FixedArrayGet intrinsic
Please review this at https://codereview.chromium.org/1223583003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+29, -0 lines):
M src/compiler/js-intrinsic-lowe
Reviewers: Benedikt Meurer,
Message:
PTAL
Description:
Enable TailCalls for %_CallRuntime
This involves:
- Enabling the tail call optimization reducer in all cases
- Adding an addition flag to CallFunctionParameters to mark call sites
that can be tail-called enabled.
- Only set the tail-call
Reviewers: Michael Starzinger,
Message:
I should add tests, but it's unclear if they will be anything other than a
trivial copy of the logic that is in the reducer itself.
https://codereview.chromium.org/1220823004/diff/1/src/compiler/context-relaxation.cc
File src/compiler/context-relaxation.c
https://codereview.chromium.org/1211333003/diff/80001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/1211333003/diff/80001/src/code-stubs.h#newcode217
src/code-stubs.h:217: virtual CallInterfaceDescriptor
GetCallInterfaceDescriptor() const = 0;
On 2015/07/01 08:3
Reviewers: mvstanton,
Message:
PTAL
Description:
Make context register implicit for CallInterfaceDescriptors
Up until now the context register was listed explicitly in each stub's
CallInterfaceDescriptor. This was problematic, because it was listed
first in the list of register parameters--whic
Feedback addressed, landing
https://codereview.chromium.org/1197703002/diff/140001/src/code-stubs.cc
File src/code-stubs.cc (right):
https://codereview.chromium.org/1197703002/diff/140001/src/code-stubs.cc#newcode1050
src/code-stubs.cc:1050: Representation RepresentationFromType(Type*
type) {
O
Feedback addressed. Please take another look.
https://codereview.chromium.org/1197703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from th
Let me rework this to use FunctionType, that does seem to make more sense.
https://codereview.chromium.org/1197703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" g
Reviewers: Michael Starzinger, rossberg,
Message:
Please take a look
rossberg: Typer changes
michi: everything else
Description:
Use big-boy Types to annotate interface descriptor parameters
- Add TypeSignature, a specialization of Signature, which tracks
per-parameter Types, and thread TypeS
With Ben and I both traveling, it's probably better that Benedikt or Michi
review this.
https://codereview.chromium.org/1179763004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Grou
Feedback addressed, landing
https://codereview.chromium.org/1146963002/diff/160001/src/compiler/js-intrinsic-lowering.cc
File src/compiler/js-intrinsic-lowering.cc (right):
https://codereview.chromium.org/1146963002/diff/160001/src/compiler/js-intrinsic-lowering.cc#newcode464
src/compiler/js-in
Please take another look
https://codereview.chromium.org/1146963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop rec
Please take another look.
https://codereview.chromium.org/1146963002/diff/20001/src/compiler/js-intrinsic-lowering.cc
File src/compiler/js-intrinsic-lowering.cc (right):
https://codereview.chromium.org/1146963002/diff/20001/src/compiler/js-intrinsic-lowering.cc#newcode470
src/compiler/js-intrin
Reviewers: Benedikt Meurer,
Description:
Type::Internal() should have representation kMachPtr
R=bmeu...@chromium.org
Please review this at https://codereview.chromium.org/1154463004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -0 lines):
M src/compiler/s
I am grateful for this honor! LGTM
https://codereview.chromium.org/1148653005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group an
Reviewers: Michael Starzinger,
Message:
PTAL
Description:
Add %GetCallerJSFunction intrinsic
Only optimized for TF
R=mstarzin...@chromium.org
Please review this at https://codereview.chromium.org/1146963002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+156,
Reviewers: jarin,
Description:
Add constants for FrameState input parameters
R=ja...@chromium.org
Please review this at https://codereview.chromium.org/1144133003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+41, -23 lines):
M src/compiler/frame-states.h
M
Feedback addressed
https://codereview.chromium.org/1140743004/diff/1/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):
https://codereview.chromium.org/1140743004/diff/1/src/compiler/js-inlining.cc#newcode298
src/compiler/js-inlining.cc:298: if (mode_ == kBuiltinsInlining &&
Reviewers: Michael Starzinger,
Message:
PTAL
Description:
Generalize builtins inlining flag to allow forced inlining of any function
Please review this at https://codereview.chromium.org/1140743004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+35, -33 lines):
Feedback addressed. Please take another look
https://codereview.chromium.org/1137703002/diff/11/src/code-stubs.cc
File src/code-stubs.cc (right):
https://codereview.chromium.org/1137703002/diff/11/src/code-stubs.cc#newcode19
src/code-stubs.cc:19: using namespace v8::internal::compiler;
Please take another look
https://codereview.chromium.org/1137703002/diff/60001/src/code-stubs.cc
File src/code-stubs.cc (right):
https://codereview.chromium.org/1137703002/diff/60001/src/code-stubs.cc#newcode462
src/code-stubs.cc:462: static Handle GetFunction(Isolate*
isolate, const char* name
Reviewers: Benedikt Meurer, mvstanton,
Message:
PTAL
Description:
Add a MathFloor stub generated with TurboFan
This stub will be used as the basis of a Math.floor-specific CallIC to
detect and track calls to floor that return -0.
Along the way:
- Create a TurboFanCodeStub super class that the
A revert of this CL (patchset #13 id:230001) has been created in
https://codereview.chromium.org/1115973005/ by da...@chromium.org.
The reason for reverting is: All sorts of performance regressions.
https://codereview.chromium.org/1053143005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
ht
Reviewers: mvstanton, Benedikt Meurer,
Message:
Created Revert of Collect type feedback on result of Math.[round|ceil|floor]
Description:
Revert of Collect type feedback on result of Math.[round|ceil|floor]
(patchset
#13 id:230001 of https://codereview.chromium.org/1053143005/)
Reason for re
lgtm
https://codereview.chromium.org/1123743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Thanks a lot for the patch! I'll integrate it into my patch for the other
platforms.
https://codereview.chromium.org/1127573004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
Feedback addressed. Please take another look.
https://codereview.chromium.org/1053143005/diff/190001/src/arm64/code-stubs-arm64.cc
File src/arm64/code-stubs-arm64.cc (right):
https://codereview.chromium.org/1053143005/diff/190001/src/arm64/code-stubs-arm64.cc#newcode3388
src/arm64/code-stubs-ar
Reviewers: mvstanton, Benedikt Meurer,
Message:
First round of comments addresses, PTAL
https://codereview.chromium.org/1053143005/diff/90001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/1053143005/diff/90001/src/ia32/code-stubs-ia32.cc#
lgtm
https://codereview.chromium.org/1109333003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/413006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1098873002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1094863004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Michael Starzinger,
Message:
PTAL
Description:
[visualizer]: Add types to visualizer output
Please review this at https://codereview.chromium.org/1083083006/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+9, -0 lines):
M src/compiler/graph-visualize
please take another look
https://codereview.chromium.org/985023002/diff/20001/src/compiler/visualizer.cc
File src/compiler/visualizer.cc (right):
https://codereview.chromium.org/985023002/diff/20001/src/compiler/visualizer.cc#newcode824
src/compiler/visualizer.cc:824: std::ostream& operator<<(s
lgtm
https://codereview.chromium.org/960903003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1040183004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1) manually as
901b67916dc2626158f42af5b5c520ede8752da2.
https://codereview.chromium.org/1002353003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v
Reviewers: titzer,
Description:
Version 4.1.0.27 (cherry-pick)
Merged ff89876bb9d362ea4d53d5ee49346d617ee1f5f6
[turbofan] Fix lowering of Math.max for integral inputs.
BUG=chromium:468162
LOG=N
TBR=tit...@chromium.org
Please review this at https://codereview.chromium.org/1002353003/
Base URL
Committed patchset #1 (id:1) manually as
4995dac67abb520e65751c1d3de563864076dc40.
https://codereview.chromium.org/1013853009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v
Reviewers: titzer,
Description:
Version 4.2.77.13 (cherry-pick)
Merged ff89876bb9d362ea4d53d5ee49346d617ee1f5f6
[turbofan] Fix lowering of Math.max for integral inputs.
BUG=chromium:468162
LOG=N
R=tit...@chromium.org
Please review this at https://codereview.chromium.org/1013853009/
Base URL:
lgtm
https://codereview.chromium.org/1033733003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
You have to use your "fe...@indutny.com" address to submit that patch, since
that's the one you used to sign the CLA and our presubmit script is now more
strict about checking that CLA.
https://codereview.chromium.org/1030723003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.go
lgtm
https://codereview.chromium.org/1030723003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1) manually as
c0b3da1f3ab8a478c5d9f4902e65f38b2182648b (tree was closed).
https://codereview.chromium.org/1022013003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to th
Reviewers: Yang,
Description:
Version 4.3.47.1 (cherry-pick)
Merged c622cb637a2831f9c2bf0ec7b80bb65440e9afc4
Introduce explicit constant for per Context debug data set by embedder
BUG=chromium:466631
LOG=N
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/1022013003
lgtm
https://codereview.chromium.org/998883002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
lgtm
https://codereview.chromium.org/1014063002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Michael Starzinger,
Message:
PTAL
Description:
[turbofan] Add schedule to visualizer output
Please review this at https://codereview.chromium.org/985023002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+121, -998 lines):
M src/compiler/basic-block-
Could we please move this discussion to the team group email so that the
motivation behind whatever this CL ends up being is very transparent?
https://codereview.chromium.org/960903003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
lgtm
https://codereview.chromium.org/924823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/920993003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Actually, I've been chatting with Ilya and I think the conditional
interface is
not the way to go. I've asked him to clean up the test to use the style of
#ifdef VERIFY_HEAP + flag checking that is used elsewhere in the runtime for
heap verification.
https://codereview.chromium.org/920993003/
lgtm
https://codereview.chromium.org/908713002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
1 - 100 of 2593 matches
Mail list logo
