Reviewers: iposva, Mads Ager,
Description:
- Added ability to call histograms from within v8
- Changed the StatsRates to use the new HistogramTimers
Please review this at http://codereview.chromium.org/39256
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M
http://codereview.chromium.org/39256/diff/1/6
File src/counters.cc (right):
http://codereview.chromium.org/39256/diff/1/6#newcode61
Line 61: if (!histogram_)
On 2009/03/06 17:24:44, iposva wrote:
> Two things here:
> - GetHistogram() sounds like it returns a value and it does and the
next line
>
Reviewers: iposva,
Message:
My last changeset got messed up on my drive (bad svn entries file). So
I've made the changes suggested in
http://codereview.chromium.org/39256/show and created a new one.
Description:
- Added ability to call histograms from within v8
- Changed the StatsRates to use th
http://codereview.chromium.org/42020/diff/1/2
File include/v8.h (right):
http://codereview.chromium.org/42020/diff/1/2#newcode1916
Line 1916: static void
SetAddHistogramSampleFunction(AddHistogramSampleCallback);
On 2009/03/10 23:34:23, iposva wrote:
> Please add comments documenting these two n
http://codereview.chromium.org/42020/diff/1/7
File src/counters.h (right):
http://codereview.chromium.org/42020/diff/1/7#newcode179
Line 179: // HistogramTimer t = { L"t:foo", NULL, false };
On 2009/03/10 23:34:23, iposva wrote:
> Histograms are not created with a "t:" prefix as far as I can tel
Reviewers: iposva, Kasper Lund,
Description:
Put back compilation cache
Please review this at http://codereview.chromium.org/56185
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/compilation-cache.h
M src/compilation-cache.cc
M src/comp
http://codereview.chromium.org/56185/diff/1/4
File src/compilation-cache.cc (right):
http://codereview.chromium.org/56185/diff/1/4#newcode101
Line 101: // script originates from the same places. This is to avoid
issues
On 2009/04/02 18:24:16, iposva wrote:
> places -> place?
Done.
http://coder
http://codereview.chromium.org/67100
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
http://codereview.chromium.org/67100/diff/1/2
File src/d8.cc (right):
http://codereview.chromium.org/67100/diff/1/2#newcode329
Line 329: Counter* counter = counter_map_->Lookup(name);
On 2009/04/13 23:09:15, iposva wrote:
> I know it should not happen, but you should assert that the counter
you
Reviewers: iposva,
Description:
Make check in GetExternalString a runtime check instead of ASSERT.
This will allow us to remove the separate call to IsExternal() from our
chrome client code, speeding up the combination.
Please review this at http://codereview.chromium.org/113035
SVN Base: http
I also added a change to cache whether we're initialized, allowing us to
inline that and avoid the deadchecks when we are.
http://codereview.chromium.org/113035
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Done
On 2009/05/06 18:04:44, iposva wrote:
> Please update the documentation in include/v8.h as well.
> -Ivan
http://codereview.chromium.org/113035
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~---
Done.
On 2009/05/06 18:20:05, iposva wrote:
> http://codereview.chromium.org/113035/diff/1002/1003
> File src/api.cc (right):
> http://codereview.chromium.org/113035/diff/1002/1003#newcode211
> Line 211: if (IsDeadCheck(location)) return;
> This optimization will not work because the IsDeadCheck
Reviewers: iposva,
Description:
Changed the flags that indicate the status of running vs dead
This allows us to optimized the EnsureInitialized() function
so it doesn't require a function call when we're running
Please review this at http://codereview.chromium.org/113121
SVN Base: http://v8.go
14 matches
Mail list logo
