Can I just open this up? Or do I need to create another CL?
https://codereview.chromium.org/213943002/diff/180001/src/arm64/simulator-arm64.cc
File src/arm64/simulator-arm64.cc (right):
https://codereview.chromium.org/213943002/diff/180001/src/arm64/simulator-arm64.cc#newcode839
src/arm64/simu
Will work on getting this fixed up before Sven gets back.
https://codereview.chromium.org/213943002/diff/160001/src/arm64/simulator-arm64.cc
File src/arm64/simulator-arm64.cc (right):
https://codereview.chromium.org/213943002/diff/160001/src/arm64/simulator-arm64.cc#newcode843
src/arm64/simulat
On 2014/05/22 08:18:57, jbramley wrote:
On 2014/05/22 07:56:42, Sven Panne wrote:
> LGTM from my side, but I'll leave the final word to Jacob and Rodolph
(and
I'm
> on vacation the next week and after that, so it would be nice if you
could
take
> care of Fritz' work in the meantime).
Rig
That should be everything.
Please let me know if anything needs work.
https://codereview.chromium.org/213943002/diff/120001/src/arm64/simulator-arm64.h
File src/arm64/simulator-arm64.h (right):
https://codereview.chromium.org/213943002/diff/120001/src/arm64/simulator-arm64.h#newcode76
src/arm6
Do I need to do anything else to land this?
https://codereview.chromium.org/286193004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this
This should be feature complete. It get's rid of all variable length memcpy
when accessing the registers in the simulator.
https://codereview.chromium.org/213943002/diff/80001/src/arm64/simulator-arm64.cc
File src/arm64/simulator-arm64.cc (right):
https://codereview.chromium.org/213943002/diff
Re: Direction
A little more info.
The main reason I was trying to get a Set/Get without specifying a size was
to
get around the possibility of compiler issues that came about previously
(https://codereview.chromium.org/203263017/).
I was hoping to be able to eventually templatize the Visit*
Thanks for the feedback.
Direction:
I am replacing reg(reg_size, ... functions with either reg or
wreg,
xreg access. Getting rid of reg_size will allow for memcpy calls to have a
constant length, which should be optimized out.
class SimRegisterBase should have the Set/Get (unsigned size) mem
Reviewers: Sven Panne, Rodolph Perfetta (ARM), jbramley,
Description:
ARM64 simulator fix for EXTR
Fixes extract when imms = 0 because a left shift of 64 is not valid.
Please review this at https://codereview.chromium.org/286193004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edg
I've started work on templatizing functions that access registers. This
will
get away from the controversial type punning.
Before going through and doing all the functions, I wanted to get a quick
check
to see if this is an acceptable solution.
I also didn't realize that git cl upload woul
On 2014/03/31 13:32:53, Sven Panne wrote:
Browsing through the simulator code a bit, I think the fundamental
problem is
that passing around the register size at runtime is a bad idea from a
performance point of view. This leads to tons of dynamic checks and the
casting
problem at hand, and we'
On 2014/03/28 11:46:04, Sven Panne wrote:
https://codereview.chromium.org/213943002/diff/20001/src/arm64/simulator-arm64.h
File src/arm64/simulator-arm64.h (right):
https://codereview.chromium.org/213943002/diff/20001/src/arm64/simulator-arm64.h#newcode179
src/arm64/simulator-arm64.h:179: }
On 2014/03/28 07:57:54, Sven Panne wrote:
NOT LGTM. I think we have to approach the whole problem differently...
How would you like to see this done then? The other approach that I can
see is
to change the functions that pass in a size value so that they don't. This
is
more invasive, bu
On 2014/03/28 11:59:58, jbramley wrote:
https://codereview.chromium.org/213943002/diff/20001/src/arm64/simulator-arm64.h
File src/arm64/simulator-arm64.h (right):
https://codereview.chromium.org/213943002/diff/20001/src/arm64/simulator-arm64.h#newcode179
src/arm64/simulator-arm64.h:179: } re
https://codereview.chromium.org/213943002/diff/20001/src/arm64/simulator-arm64.h
File src/arm64/simulator-arm64.h (right):
https://codereview.chromium.org/213943002/diff/20001/src/arm64/simulator-arm64.h#newcode165
src/arm64/simulator-arm64.h:165: ASSERT(size/8 <= kXRegSize);
On 2014/03/27 17:50
Reviewers: Sven Panne, Rodolph Perfetta (ARM), jbramley,
Description:
Change arm64 simulator register backing store.
Use int64_t instead of an array. This allows the use of
unions for Set/Get instead of memcpy.
About a 47% boost.
Before - 5:31
Richards: 77.6
DeltaBlue: 108
Crypto: 64.0
RayTra
Reviewers: Sven Panne, jbramley, Rodolph Perfetta (ARM), Rodolph Perfetta,
https://codereview.chromium.org/203263017/diff/1/src/a64/simulator-a64.h
File src/a64/simulator-a64.h (right):
https://codereview.chromium.org/203263017/diff/1/src/a64/simulator-a64.h#newcode171
src/a64/simulator-a64.h:1
17 matches
Mail list logo
