https://codereview.chromium.org/1237803003/diff/180001/build/vs_toolchain.py
File build/vs_toolchain.py (right):
https://codereview.chromium.org/1237803003/diff/180001/build/vs_toolchain.py#newcode1
build/vs_toolchain.py:1: #!/usr/bin/env python
On 2015/10/30 16:29:41, scottmg wrote:
We should
FYI: This passed our staging bot v8_win64_ninja_rel where goma is enabled
and
the MSVS_VERSION variable is unset.
https://codereview.chromium.org/1237803003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are s
Reviewers: jochen, scottmg
CL: https://codereview.chromium.org/1237803003/
Message:
PTAL. Is there some logics in chromium that'll force a full recompile if the
msvs version changes?
https://codereview.chromium.org/1237803003/diff/180001/build/gyp_v8
File build/gyp_v8 (right):
https://coderevi
Clean up in https://codereview.chromium.org/1341213002/
https://codereview.chromium.org/1327033003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscri
https://codereview.chromium.org/1327033003/diff/60001/tools/run_perf.py
File tools/run_perf.py (right):
https://codereview.chromium.org/1327033003/diff/60001/tools/run_perf.py#newcode463
tools/run_perf.py:463: if self.binary != 'd8' and '--prof' in
self.extra_flags:
Ah crap - didn't catch this.
lgtm with comment:
https://codereview.chromium.org/1327033003/diff/40001/tools/run_perf.py
File tools/run_perf.py (right):
https://codereview.chromium.org/1327033003/diff/40001/tools/run_perf.py#newcode460
tools/run_perf.py:460: # TODO(machenbach): This requires +.exe if run on
windows.
Please
https://codereview.chromium.org/1327033003/diff/20001/tools/run_perf.py
File tools/run_perf.py (right):
https://codereview.chromium.org/1327033003/diff/20001/tools/run_perf.py#newcode651
tools/run_perf.py:651: if profiler_run:
On 2015/09/11 08:22:33, gdeepti1 wrote:
On 2015/09/10 07:49:44, Mich
https://codereview.chromium.org/1317113007/diff/60001/test/js-perf-test/RestParameters/rest.js
File test/js-perf-test/RestParameters/rest.js (right):
https://codereview.chromium.org/1317113007/diff/60001/test/js-perf-test/RestParameters/rest.js#newcode5
test/js-perf-test/RestParameters/rest.js:5
https://codereview.chromium.org/1327033003/diff/20001/tools/run_perf.py
File tools/run_perf.py (right):
https://codereview.chromium.org/1327033003/diff/20001/tools/run_perf.py#newcode651
tools/run_perf.py:651: if profiler_run:
Suggestion: Could you maybe just use the existing extra_flags list? I
Please find more appropriate owner-reviewers.
https://codereview.chromium.org/1303093004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from th
Adding better owners.
https://codereview.chromium.org/1313493005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiv
lgtm with suggestion
https://codereview.chromium.org/1324103003/diff/40001/tools/js2c.py
File tools/js2c.py (right):
https://codereview.chromium.org/1324103003/diff/40001/tools/js2c.py#newcode112
tools/js2c.py:112: lineno = lines.count("\n", 0, start) + 1
Does counting \n lead to a good result
ogressIndicator(ProgressIndicator):
# TODO(machenbach): This stores only the global random seed from the
# context and not possible overrides when using random-seed stress.
"random_seed": self.random_seed,
+ "target_name": test.suite.shell(),
"variant
On 2015/09/05 09:02:50, skomski wrote:
Since it failed on mips should I revert the patchset or should I quickly
submit
a review before monday?
It's on big endian only. No revert needed. And no hurries.
https://codereview.chromium.org/1324453007/
--
--
v8-dev mailing list
v8-dev@googlegroups
Reviewers: danno, Michael Starzinger, Jakob, skomski,
Message:
Created Revert of Speedup stringsearch for two byte strings
Description:
Revert of Speedup stringsearch for two byte strings (patchset #3 id:40001 of
https://codereview.chromium.org/1303033012/ )
Reason for revert:
[Sheriff] Breaks
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1331433002/ by machenb...@chromium.org.
The reason for reverting is: [Sheriff] Breaks fuzzer and msan:
http://build.chromium.org/p/client.v8/builders/V8%20Fuzzer/builds/4773
Repro with:
tools/fuzz-harn
On 2015/09/04 09:49:46, cbruni wrote:
The CQ bit was checked by mailto:cbr...@chromium.org to run a CQ dry run
CQ down - trooper informed.
https://codereview.chromium.org/1330483003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
On 2015/09/04 09:28:19, commit-bot: I haz the power wrote:
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1311123005/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1311123005/1
CQ down - trooper informed.
https://codere
Reviewers: Benedikt Meurer,
Message:
PTAL
Description:
Make gold plugin download more robust.
BUG=chromium:515782
LOG=n
Please review this at https://codereview.chromium.org/1321943004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -0 lines):
M build/down
A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1303053004/ by machenb...@chromium.org.
The reason for reverting is: [Sheriff] Breaks compile on arm:
http://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20builder/builds/6590.
https://coderev
Reviewers: Benedikt Meurer, Jakob, mvstanton,
Message:
Created Revert of Vector ICs: platform support for vector-based stores.
Description:
Revert of Vector ICs: platform support for vector-based stores. (patchset #7
id:120001 of https://codereview.chromium.org/1328603003/ )
Reason for revert:
Reviewers: Jarin, Jakob, Benedikt Meurer,
Message:
Created Revert of [es5] Class of object is "Function" if object has
[[Call]].
Description:
Revert of [es5] Class of object is "Function" if object has [[Call]].
(patchset
#3 id:40001 of https://codereview.chromium.org/1307943013/ )
Reason
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1306303005/ by machenb...@chromium.org.
The reason for reverting is: [Sheriff] Changes several layout test
expectations.
Please fix upstream first if intended. E.g.:
https://build.chromium.org/p/clie
Reviewers: tandrii(chromium), Benedikt Meurer,
Message:
PTAL. Original CL + ignore windows...
https://codereview.chromium.org/1330623002/diff/1/build/download_gold_plugin.py
File build/download_gold_plugin.py (right):
https://codereview.chromium.org/1330623002/diff/1/build/download_gold_plugin
Reviewers: Benedikt Meurer,
Message:
Created Revert of Automatically download gold plugin for cfi builds.
Description:
Revert of Automatically download gold plugin for cfi builds. (patchset #1
id:1
of https://codereview.chromium.org/1303183005/ )
Reason for revert:
Breaks windows.
Original
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1329653004/ by machenb...@chromium.org.
The reason for reverting is: Breaks windows..
https://codereview.chromium.org/1303183005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com
Reviewers: Benedikt Meurer,
Message:
PTAL. Now the gold plugin will be downloaded automatically if cfi is
specified.
The up-to-date check is pinned to clang's version.
A bit hacky - nicer would be if the gold plugin had its own stamp and
version
file - or an md5 hash checked in to which it
Tentative lgtm. Adding more accurate owner.
https://codereview.chromium.org/1318933004/diff/1/tools/tickprocessor.js
File tools/tickprocessor.js (right):
https://codereview.chromium.org/1318933004/diff/1/tools/tickprocessor.js#newcode517
tools/tickprocessor.js:517: }
nit: indentation of } and }
On 2015/09/02 12:58:28, Yang OOO until mid October wrote:
On 2015/09/02 12:33:53, rmcilroy wrote:
> lgtm with a question for Hannes.
>
> https://codereview.chromium.org/1310503006/diff/1/src/objects-inl.h
> File src/objects-inl.h (right):
>
>
https://codereview.chromium.org/1310503006/diff/1/sr
lgtm
https://codereview.chromium.org/1324813003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1302413007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM - please clobber the lint cache and run this locally to ensure we're
not
picking up formerly untested rules.
https://codereview.chromium.org/1325833005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are s
On 2015/09/01 12:57:53, Hablich wrote:
On 2015/09/01 12:54:40, Michael Achenbach wrote:
> TBR - this keeps the original outcomes - skip wherever the original is
pass/fail
This means if the original outcome is PASS and the result is PASS or
TIMEOUT
the
test is green? If the result is FAILED
Reviewers: Hablich,
Message:
TBR - this keeps the original outcomes - skip wherever the original is
pass/fail
Description:
[test] Fix skipping slow tests.
TBR=habl...@chromium.org
NOTRY=true
Please review this at https://codereview.chromium.org/1320443008/
Base URL: https://chromium.google
On 2015/09/01 11:11:22, commit-bot: I haz the power wrote:
Patchset 1 (id:??) landed as
https://crrev.com/76fb022fd257ebb9d1d31c9ec4d08332b9a86d48
Cr-Commit-Position: refs/heads/master@{#30505}
lgtm - fair enough - we should have presubmit checking the syntax of all our
python scripts... so tha
Reviewers: Benedikt Meurer,
Message:
TBR
This is still/again failing on android_arm and causing costly retries...
Description:
[test] Increase simdjs test timeout on arm.
BUG=
Please review this at https://codereview.chromium.org/1308563010/
Base URL: https://chromium.googlesource.com/v8/v8.
Reviewers: Jarin, Benedikt Meurer, Mircea Trofin,
Message:
Created Revert of [turbofan] greedy: heuristic for memory operands
Description:
Revert of [turbofan] greedy: heuristic for memory operands (patchset #2
id:40001
of https://codereview.chromium.org/1306823005/ )
Reason for revert:
[She
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/1311813005/ by machenb...@chromium.org.
The reason for reverting is: [Sheriff] Breaks test with greedy allocator:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20greedy%20all
Reviewers: Benedikt Meurer,
Message:
PTAL
Description:
Port enabling rtti for cfi.
Partially port https://codereview.chromium.org/1243373003/
BUG=chromium:515782
LOG=n
NOTRY=true
Please review this at https://codereview.chromium.org/1329553002/
Base URL: https://chromium.googlesource.com/v8/
Reviewers: Hablich,
Message:
TBR
Description:
[test] Skip slow tests.
TBR=habl...@chromium.org
NOTRY=true
Please review this at https://codereview.chromium.org/1307123003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+9, -0 lines):
M test/mozilla/mozilla.sta
Reviewers: Dan Ehrenberg, Benedikt Meurer, bradnelson, bbudge, gdeepti1,
Message:
Created Revert of [simd.js] Disable SIMD polyfill.
Description:
Revert of [simd.js] Disable SIMD polyfill. (patchset #2 id:20001 of
https://codereview.chromium.org/1305923005/ )
Reason for revert:
Breaks simdjs pe
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1308003003/ by machenb...@chromium.org.
The reason for reverting is: Breaks simdjs performance tests. See:
https://paste.googleplex.com/5883927122149376.
https://codereview.chromium.org/1305923005/
--
lgtm - note that this string is just used for printing in the end. It makes
no
functional difference.
https://codereview.chromium.org/1298973007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to
Reviewers: Benedikt Meurer,
Message:
PTAL. Blocks clang roll:
https://codereview.chromium.org/1308393008/
Description:
[test] Remove unused code.
BUG=
Please review this at https://codereview.chromium.org/1313213007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files
On 2015/08/31 11:04:44, Hablich wrote:
On 2015/08/31 10:19:01, Michael Achenbach (OOO) wrote:
> PTAL
lgtm, although wasn't it something like regress-30* too?
I take those as a basis:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/4285/steps/Check/lo
lgtm
https://codereview.chromium.org/1303393004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
@cbruni: Could you maybe check what was wrong with the original CL as
Yang's OOO
now?
https://codereview.chromium.org/1314193003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Grou
Reviewers: Yang, Hablich, vogelheim,
Message:
PTAL
Description:
[test] Skip slow test on no18n bot.
BUG=
Please review this at https://codereview.chromium.org/1321063004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+6, -0 lines):
M test/mjsunit/mjsunit.stat
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1314193003/ by machenb...@chromium.org.
The reason for reverting is: This breaks builds without i18n support.
Bisected
locally. See builder:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-
Reviewers: cbruni, Yang,
Message:
Created Revert of Native context: install array methods via runtime import.
Description:
Revert of Native context: install array methods via runtime import.
(patchset #1
id:1 of https://codereview.chromium.org/1324483002/ )
Reason for revert:
This breaks bui
Guess this breaks layout test expectations:
http://build.chromium.org/p/client.v8.fyi/console?branch=master
Please revert or adapt blink-upstream asap.
https://codereview.chromium.org/1286383005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You re
On 2015/08/17 07:37:08, Michael Achenbach (OOO) wrote:
If you want to land a CL like this, please go ahead. This was not ready
yet.
I'd
wanna add the following things:
- Make coverage=1 imply clang=0
- Properly unset any -O1/2/3 cflags - I think right now we end up with two
flags
set, e.g. "
On 2015/08/17 07:37:08, Michael Achenbach (OOO) wrote:
If you want to land a CL like this, please go ahead. This was not ready
yet.
I'd
wanna add the following things:
- Make coverage=1 imply clang=0
- Properly unset any -O1/2/3 cflags - I think right now we end up with two
flags
set, e.g. "
Reviewers: cbruni,
Message:
If you want to land a CL like this, please go ahead. This was not ready
yet. I'd
wanna add the following things:
- Make coverage=1 imply clang=0
- Properly unset any -O1/2/3 cflags - I think right now we end up with two
flags
set, e.g. "-O3 -O0", which is a bit m
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1283593005/ by machenb...@chromium.org.
The reason for reverting is: Some bots that don't run tests (by design)
don't
return the test results json anymore which makes the infrastructure side
fail
now..
Reviewers: Jakob, adamk,
Message:
Created Revert of Make run-tests.py warn when it's not testing anything
Description:
Revert of Make run-tests.py warn when it's not testing anything (patchset #1
id:1 of https://codereview.chromium.org/1283513003/ )
Reason for revert:
Some bots that don't run t
lgtm
https://codereview.chromium.org/1283513003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1279613005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
FYI: Fixing gatekeeper now: https://codereview.chromium.org/1275323003/
https://codereview.chromium.org/1280903002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" grou
This works now after the fix in https://codereview.chromium.org/1273403002/
https://codereview.chromium.org/1267773004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev"
Reviewers: jochen, Benedikt Meurer,
Message:
PTAL - this now matches chromium's version again. This was probably blocking
https://codereview.chromium.org/1267773004/ .
Should binutils not be moved into the buildtools third_party repo, so that
we
get automatic updates on changes?
Description:
A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/1280903002/ by machenb...@chromium.org.
The reason for reverting is: [Sheriff] Lacks one test expectation for
http://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/4573
http://build.chromi
Reviewers: adamk, Dan Ehrenberg,
Message:
Created Revert of Test262 roll
Description:
Revert of Test262 roll (patchset #9 id:160001 of
https://codereview.chromium.org/1268553003/ )
Reason for revert:
[Sheriff] Lacks one test expectation for
http://build.chromium.org/p/client.v8/builders/V8%20Li
self.tests = []
@@ -370,6 +371,11 @@ class JsonTestProgressIndicator(ProgressIndicator):
"result": test.suite.GetOutcome(test),
"expected": list(test.outcomes or ["PASS"]),
"duration": test.duration,
+
+ # TODO(machenbach): This stores o
Reviewers: Jakob,
Message:
PTAL
Description:
[test] Make test filters platform-independent.
Use the same path separator for test cases on the cmd-line
on all platforms as in testcase.GetLabel, which is used to
report failures.
BUG=chromium:511215
LOG=n
NOTRY=true
Please review this at https:/
FYI: I added the v8: prefix to the BUG= line. Otherwise it points into
chromium
land.
https://codereview.chromium.org/1272733002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Grou
lgtm - thanks for fixing!
https://codereview.chromium.org/1272733002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop re
On 2015/08/05 12:05:55, Michael Achenbach wrote:
On 2015/07/31 21:43:30, pcc1 wrote:
> On 2015/07/31 21:36:18, krasin wrote:
> > On 2015/07/31 21:26:13, Michael Achenbach wrote:
> > > On 2015/07/31 15:41:52, krasin wrote:
> > > > Michael,
> > > >
> > > > the internal error looks familiar. See
> >
On 2015/07/31 21:43:30, pcc1 wrote:
On 2015/07/31 21:36:18, krasin wrote:
> On 2015/07/31 21:26:13, Michael Achenbach wrote:
> > On 2015/07/31 15:41:52, krasin wrote:
> > > Michael,
> > >
> > > the internal error looks familiar. See
> > > https://crbug.com/513074
> > > https://codereview.chromium
lgtm
https://codereview.chromium.org/1272123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
/cctest.status
+++ b/test/cctest/cctest.status
@@ -130,6 +130,9 @@
# TODO(machenbach, mvstanton): Flaky in debug on all platforms.
'test-lockers/LockerUnlocker': [PASS, ['mode == debug', FLAKY]],
+
+ # BUG(4141).
+ 'test-alloc/CodeRange':
On 2015/07/31 15:41:52, krasin wrote:
Michael,
the internal error looks familiar. See
https://crbug.com/513074
https://codereview.chromium.org/1249273003/
Thank you for working on this!
There might well be a connection. What puzzles me though is that the CL you
refer to is already include
Nice try, thought CQ might be smart... well, please land this manually.
https://codereview.chromium.org/1266233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" grou
lgtm
https://codereview.chromium.org/1266233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2015/07/31 12:23:51, Benedikt Meurer wrote:
lgtm
More details about the failure I'm getting:
After calling ld.gold with --verbose --debug all, I'm seeing this in the
end:
.../v8/third_party/binutils/Linux_x64/Release/bin/ld.gold: 0 running
task
Plugin_hook
.../v8/third_party/binutil
Reviewers: jochen, Benedikt Meurer, krasin1,
Message:
PTAL - this ports cfi configs for x64. Not fully there yet. Run locally:
https://paste.googleplex.com/4925378871164928
Anybody an idea?
https://codereview.chromium.org/1267773004/diff/20001/build/download_gold_plugin.py
File build/download_
Could we speed up this test even more? see:
http://build.chromium.org/p/client.v8/builders/V8%20Arm%20GC%20Stress/builds/924
Or please skip for gc stress on arm.
https://codereview.chromium.org/1261123003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-
lgtm
https://codereview.chromium.org/1264913003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Jakob, Hablich,
Message:
Created Revert of [cq] Increase commit burst delay.
Description:
Revert of [cq] Increase commit burst delay. (patchset #1 id:1 of
https://codereview.chromium.org/1258193003/)
Reason for revert:
Committing more than one CL at a time led to some odd buildbot be
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1263183002/ by machenb...@chromium.org.
The reason for reverting is: Committing more than one CL at a time led to
some
odd buildbot behavior on the console (probably an independent bug)..
https://codere
Reviewers: Jakob, Hablich,
Message:
PTAL
Description:
[cq] Increase commit burst delay.
TBR=jkumme...@chromium.org, habl...@chromium.org
NOTRY=true
NOTREECHECKS=true
Please review this at https://codereview.chromium.org/1258193003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
On 2015/07/28 19:52:39, Michael Achenbach wrote:
On 2015/07/28 16:14:06, Jakob wrote:
> Yes, I like this approach much better. LGTM.
>
> What's up with the v8_linux_rel bot? Looks like it doesn't have
test262-es6.
Worse, that's another bug that requires fixing. There's a some problem in
test
On 2015/07/28 16:14:06, Jakob wrote:
Yes, I like this approach much better. LGTM.
What's up with the v8_linux_rel bot? Looks like it doesn't have
test262-es6.
Worse, that's another bug that requires fixing. There's a some problem in
test262-es6's testcfg and python throws an error on load.
lgtm
https://codereview.chromium.org/1258763004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
PTAL. I'm back to dictionaries and implemented your suggestion of filtering
names first and letting the test suite turn the names into flags by a custom
method. The generator class stayed to capture the state and the
precomputation
in there.
My measurements show that the dictionary lookups are
Reviewers: Yang,
Message:
TBR
Description:
[test] Skip slow test in novfp3 mode.
TBR=yang...@chromium.org
NOTRY=true
Please review this at https://codereview.chromium.org/1264443002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+6, -0 lines):
M test/cctest/c
On 2015/07/28 05:39:03, mvstanton wrote:
Hi Michael, it's pretty unlikely that those OSR failures are due to this.
It
only changes code behind a flag that is turned off in the build.
https://codereview.chromium.org/1255883002/diff/1/src/ic/ia32/ic-ia32.cc
File src/ic/ia32/ic-ia32.cc (right):
On 2015/07/27 20:31:29, Michael Achenbach wrote:
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1257223002/ by
mailto:machenb...@chromium.org.
The reason for reverting is: [Sheriff] Breaks several layout tests, e.g.:
http://build.chromium.org
Reviewers: vogelheim,
Message:
PTAL
https://codereview.chromium.org/1257583005/diff/1/test/webkit/fast/js/excessive-comma-usage-expected.txt
File test/webkit/fast/js/excessive-comma-usage-expected.txt (left):
https://codereview.chromium.org/1257583005/diff/1/test/webkit/fast/js/excessive-comma
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1257223002/ by machenb...@chromium.org.
The reason for reverting is: [Sheriff] Breaks several layout tests, e.g.:
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2032/builds/1067
Se
Reviewers: Benedikt Meurer, Hannes Payer, Jarin (OOO - vacation),
mvstanton, jochen,
Message:
Created Revert of Remove ExternalArray, derived types, and element kinds
Description:
Revert of Remove ExternalArray, derived types, and element kinds (patchset
#5
id:80001 of https://codereview.ch
This from here?
http://build.chromium.org/p/client.v8/builders/V8%20GC%20Stress%20-%201/builds/4380
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20gc%20stress/builds/3024
https://codereview.chromium.org/1255883002/
--
--
v8-dev mailing list
v8-dev@googlegro
Wouldn't the following design simplify things:
- let each test suite provide a default list of named variants (just the
names,
not the corresponding flag lists)
- let the command-line args filter those default variants as needed
- let each test case, by means of the status file, further filter t
Reviewers: ulan,
Message:
PTAL
Description:
[test] Replace android_commands in v8 perf runner.
BUG=chromium:267773
LOG=n
NOTRY=true
Please review this at https://codereview.chromium.org/1255183002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+10, -17 lines):
Reviewers: Jakob,
Message:
PTAL
https://codereview.chromium.org/1245623005/diff/40001/test/benchmarks/testcfg.py
File test/benchmarks/testcfg.py (left):
https://codereview.chromium.org/1245623005/diff/40001/test/benchmarks/testcfg.py#oldcode189
test/benchmarks/testcfg.py:189: return [[], ["--t
lgtm, but note that there's no coverage on the bots yet
https://codereview.chromium.org/1259693003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscri
On 2015/07/24 14:14:45, commit-bot: I haz the power wrote:
Patchset 2 (id:??) landed as
https://crrev.com/0cae607ff33725e868a217556a88ac4478774210
Cr-Commit-Position: refs/heads/master@{#29848}
This causes a cctest to hang with novfp3 (bisected):
http://build.chromium.org/p/client.v8/builders/V
lgtm
https://codereview.chromium.org/1256693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
This seems to work now, thanks!
https://codereview.chromium.org/1242863003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
Repro instructions:
git checkout 477d651
gclient sync --nohooks
GYP_GENERATORS=ninja GYP_DEFINES="target_arch=x64 v8_target_arch=x64
use_goma=1
embed_script=/path/to/v8/test/mjsunit/mjsunit.js v8_enable_slow_dchecks=1
v8_optimized_debug=1" gclient runhooks
ninja -j1000 -C out/Debug d8
out/Debug
1 - 100 of 2476 matches
Mail list logo
