[v8-dev] Tracking string creations

So I compiled V8 and D8 on my Windows machine and I have some very big javascript code that is pretty obfuscated and which I can run on my machine perfectly fine. I want to recompile my V8 so that I can track creation of certain string inside of this javascript. For example, I want to see if an

[v8-dev] RE: IDEA World Convention Attendees Email List-2023

I appreciate your time. Looking forward to your response. Kind Regards, Harris mark Marketing Coordinator -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev&q

Re: [v8-dev] Can I start working on issue 13187?

the bug and posted some considerations on it including its probable cause. I think I can fix this issue, but I should wait for a member's response, right? On Monday, October 17, 2022 at 2:47:09 PM UTC+9 les...@chromium.org wrote: > Hi Mark, > > Thanks for taking this on. In genera

[v8-dev] Can I start working on issue 13187?

Hi. I'm new to v8 development. I scanned a list of bugs and found the one that seems easy for me to handle: Issue 13187 . Can I start working on this issue? Since its status is labeled as "Untriaged", I feel like I should wait until a project

[v8-dev] Groeten

aanvulling van de dag, heb je mijn vorige bericht ontvangen? -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving e

Re: [v8-dev] Background script streaming thread for async scripts

rvice Workers, since they allow a site to be explicit about what it > wants cached, etc. This is not merely an implementation detail, though, and > may require some greater rework on your side. Honestly, I'm not sure what > the current status of ServiceWorkers is, though. > Facebo

[v8-dev] Background script streaming thread for async scripts

as just the first weird thing I stumbled across, given the importance of parsing in general on complex, JS-heavy sites like Facebook, any additional info related to how V8 does parsing and how sites might be able to take advantage of that would be very helpful. Thanks! -Mark Hahnenberg

[v8-dev] Re: [native-client-dev] Re: [chromium-dev] Is the --lib32 flag for build/install-build-deps.sh used?

oved in Ubuntu Trusty so that they work again, but I haven't checked. Or maybe Chromium no longer depends on packages that we used to need multilib versions of (such as Gtk). Cheers, Mark -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You

[v8-dev] Urgent Order

Hello Sir/madam Am Mark.Bruce, i will like to know if you do carry propane heater in stock for sale.if you do i will like you to email me with the sizes and prices and also an attachment to each of the (propane heater) also i will like to know if you do accept credit cards as a form of payment

Re: [v8-dev] Re: Make Object.freeze/seal/preventExtensions observable (issue 47703003)

>> > this > >> crank semantics where you can still change a data property from writable >> to >> non-writable, even if it's allegedly non-configurable. 8/ >> > > Hehe... we had the exact same discussion yesterday on IM before we > remembered >

Re: [v8-dev] Re: Don't use StoreIC_ArrayLength on frozen arrays (issue 19115002)

newcode1672> > src/ic.cc:1672: !receiver->map()->is_frozen()) { > On 2013/07/12 21:08:02, Mark Miller wrote: > >> Gotcha. Thanks for the clarification. >> > > Does that mean that a cheaper workaround for browsers predating this >> > fix would >

Re: [v8-dev] Re: Issue 2469 in v8: Array.prototype.sort, Array.prototype.pop etc. are non-strict.

This goes to a spec oversight issue not specific to Array.prototype.*, but rather all built-in functions. Built-in functions are neither strict nor non-strict. Altogether, there are four kinds of functions in ES5: built-in, strict, non-strict, and bound. We got caller safe on strict and bound, and

Re: [v8-dev] Re: Fixed Array.prototype.reverse() behavior when array is frozen or array elements are not writable an… (issue 10453009)

On Fri, May 25, 2012 at 1:48 AM, wrote: > I don't think V8 has support for fast access of property attributes at the > moment. But I have the feeling that duplicating all of the attribute > checks in > the builtin functions is the wrong approach since we are able do them in > the ICs > already. >

Re: [v8-dev] Re: Limit the number of arguments in a function call to 32766. (issue7054074)

What was the security reason? On Mon, Jun 6, 2011 at 9:24 AM, wrote: > The parameter limit was introduced for security reasons that don't seem to > apply > here > > > http://codereview.chromium.org/7054074/ > > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://groups.google.com/group/v

[v8-dev] Re: Don't exchange null and undefined with the global object in function.prototype.{call, apply} for ... (issue6902104)

So ({}).valueOf.call(document.all) === document.all ? If so, I agree that's probably better than making this an error. On Thu, Apr 28, 2011 at 12:13 PM, wrote: > Since Safari isn't already doing something, we are free to do what we want > with > document.all. > I think the right thing is

[v8-dev] Re: Fix fast TLS support on Mac. (issue6706018)

I’ve tested this now and it works as advertised. LGTM as-is if you prefer, your Check should be sufficient. http://codereview.chromium.org/6706018/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Fix fast TLS support on Mac. (issue6706018)

I’m going to test this patch shortly. http://codereview.chromium.org/6706018/diff/2002/src/platform-macos.cc File src/platform-macos.cc (right): http://codereview.chromium.org/6706018/diff/2002/src/platform-macos.cc#newcode546 src/platform-macos.cc:546: // 11.x.x (Lion) changed the offset. Perh

[v8-dev] Re: Fix fast TLS support on Mac. (issue6706018)

I haven’t tested this yet. http://codereview.chromium.org/6706018/diff/1/src/platform-tls-mac.h File src/platform-tls-mac.h (right): http://codereview.chromium.org/6706018/diff/1/src/platform-tls-mac.h#newcode48 src/platform-tls-mac.h:48: asm("movl %%gs:(%1), %0;" It seems like you should be ab

[v8-dev] Add missing #ifdef to lithium-gap-resolver-ia32.cc (issue6728035)

Reviewers: Vitaly Repeshko, Description: Add missing #ifdef to lithium-gap-resolver-ia32.cc. This fixes the GYP-based 64-bit Mac build. Please review this at http://codereview.chromium.org/6728035/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/ia32/

[v8-dev] Re: Fixed lol SetProperty() calls to specify the needed strict mode. (issue6615006)

Normally, I would build either: scons liveobjectlist=on d8 Or run: ./tools/test.py -S"liveobjectlist=on" That will include the lol functionality into the builds. Thanks. Mark On 3/2/11 10:22 PM, "mm...@chromium.org" wrote: > Hi Mark, thanks for fixing this. Is ther

[v8-dev] Fixed lol SetProperty() calls to specify the needed strict mode. (issue6615006)

Reviewers: Søren Gjesse, Message: Søren, here's a small CL to update the calls to SetProperty() from inside lol code to specify the needed strict modes. Can you take a look please? Thanks. Description: Fixed lol SetProperty() calls to specify the needed strict mode. Please review this at

[v8-dev] Re: Adding debugger interface and runtime functions hooks for supporting... (issue6351007)

I've addressed Søren's comments below, and would like to defer the requested changes as part of the debugger/runtime vs lol core isolation that I'll submit in a later CL. The only change in the code since last time is the #include of liveobjectlist-inl.h instead of liveobjectlist.h. Please ta

[v8-dev] Re: Adding files for LiveObjectList implementation. (issue6357005)

Here is the update that addresses all the comments except for 3 issue left to be addressed in a future CL: 1. "rewind" Capture() if allocation fails. 2. refactor lol core and debugger/runtime parts into 2 components. 3. add unit tests. Please take a look. Thanks. http://codereview.chromium.

[v8-dev] Small fix for when not building with OBJECT_PRINT defined. (issue6602034)

Reviewers: Mikhail Naganov (Chromium), Message: Small fix for an oversight from previous refactoring of this code. Please take a look. Thanks. Description: Small fix for when not building with OBJECT_PRINT defined. Please review this at http://codereview.chromium.org/6602034/ SVN Base: ht

[v8-dev] Re: Refactored PathTracer in heap.cc.... (issue6541044)

3rd time's the charm ... hopefully. =) http://codereview.chromium.org/6541044/diff/4003/src/heap.h File src/heap.h (right): http://codereview.chromium.org/6541044/diff/4003/src/heap.h#newcode2161 src/heap.h:2161: class PathTracer: public ObjectVisitor { On 2011/02/21 18:08:28, Mikhail Naganov (

[v8-dev] Re: Refactored PathTracer in heap.cc.... (issue6541044)

I've addressed all your comments except for the one in heap.cc about using 2 constructors. Can you please provide some clarification on that (see my response to the comment)? Thanks. BTW, the unsigned int counter changes came from another CL when I svn up on bleeding edge. They're not part of

[v8-dev] Re: Bug: OS::MemoryMappedFile::open() should not truncate a pre-existing file. (issue6543039)

On 2011/02/21 10:37:56, Mikhail Naganov (Chromium) wrote: http://codereview.chromium.org/6543039/diff/1/src/platform-linux.cc File src/platform-linux.cc (right): http://codereview.chromium.org/6543039/diff/1/src/platform-linux.cc#newcode330 src/platform-linux.cc:330: FILE* file = fopen(name, "

[v8-dev] Bug: OS::MemoryMappedFile::open() should not truncate a pre-existing file. (issue6543039)

Reviewers: Mikhail Naganov (Chromium), Søren Gjesse, Message: While testing LOL code, I see that OS::MemoryMappedFile::open() which I introduced previously had a bug. In the unix ports, it was truncating the file that it opens. In the win32 port, it was opening the file only if it pre-existe

[v8-dev] Re: Refactored PathTracer in heap.cc.... (issue6541044)

I've updated the CL with a bug fix for the kFindFirst mode of operation. This breaks the previous found_target_ flag into found_target_ and found_target_in_trace_ flags. http://codereview.chromium.org/6541044/diff/1003/src/heap.h File src/heap.h (right): http://codereview.chromium.org/65410

[v8-dev] Refactored PathTracer in heap.cc.... (issue6541044)

ts at various places to let you know what and why I made those changes where relevant. Please take a look. Thanks. Mark http://codereview.chromium.org/6541044/diff/1/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/6541044/diff/1/src/heap.cc#newcode5186 src/heap.cc:5

Re: [v8-dev] Added gdb-jit interface support for ARM. Compressed .debug_line table by 1)... (issue6287015)

Hi Mads, Shasank's contribution is covered under the agreement that HP signed. He is contributing as a member of HP's webOS v8 team. Thanks. Regards, Mark On 1/31/11 12:56 AM, "Mads Sig Ager" wrote: > Shasank, could you make sure that you (or your company) has s

[v8-dev] Re: Adding files for LiveObjectList implementation. (issue6357005)

On 2011/01/21 13:19:47, Michail Naganov wrote: Heap::InSpace accepts addresses and doesn't assume that the address is in V8's heap. If it's true that !OS::IsOutsideAllocatedSpace implies that an address lies in one of the spaces, then your logic can be used, otherwise not. Soeren, can you t

[v8-dev] Re: Adding files for LiveObjectList implementation. (issue6357005)

Mikhail, I've addressed all your comments. Please take another look and let me know if you disagree with my resolutions. Thanks. http://codereview.chromium.org/6357005/diff/6001/src/liveobjectlist-inl.h File src/liveobjectlist-inl.h (right): http://codereview.chromium.org/6357005/diff/6001

[v8-dev] Script changes so that we can build debug/release with... (issue6267007)

options['inspector'] = 'on' +options['objectprint'] = 'on' def ParseEnvOverrides(arg, imports): Index: src/SConscript === --- src/SConscript (revision 6419) +++ src/SConscript

[v8-dev] Re: Adding build script changes to support LiveObjectList functionality. (issue6364002)

Build issue with mode=release liveobjectlist=on is fixed here: http://codereview.chromium.org/6267007/ http://codereview.chromium.org/6364002/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Fixed SConscript to allow both mode=debug and objectprint=on to be specified... (issue6278005)

Will replace this with another changelist. http://codereview.chromium.org/6278005/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Adding GC hooks to support LiveObjectList functionality. (issue6287004)

http://codereview.chromium.org/6287004/diff/1/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/6287004/diff/1/src/heap.cc#newcode38 src/heap.cc:38: #include "liveobjectlist-inl.h" On 2011/01/19 08:41:33, Søren Gjesse wrote: This suggests that the actual lol implementation la

[v8-dev] Stubbed out empty liveobjectlist files. (issue6335009)

Reviewers: Søren Gjesse, Description: Stubbed out empty liveobjectlist files. Please review this at http://codereview.chromium.org/6335009/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: A src/liveobjectlist-inl.h A src/liveobjectlist.h A src/l

[v8-dev] Stubbed out empty liveobjectlist files. (issue6335009)

Reviewers: Søren Gjesse, Description: Stubbed out empty liveobjectlist files. Please review this at http://codereview.chromium.org/6335009/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: A src/liveobjectlist-inl.h A src/liveobjectlist.h A src/l

[v8-dev] Adding build script changes to support LiveObjectList functionality. (issue6364002)

] == 'release'): + # Print a warning that liveobjectlist will implicitly enable the debugger + print "Warning: forcing debuggersupport on for liveobjectlist" + options['debuggersupport']

[v8-dev] Re: Adding build script changes to support LiveObjectList functionality. (issue6338009)

I've addressed the issues, but for some reason, my gcl configuration is messed up, and I was not able to upload the updated files. So, I cleaned it and uploaded a separate CL at: http://codereview.chromium.org/6364002 http://codereview.chromium.org/6338009/diff/1/SConstruct File SConstruct (r

[v8-dev] Re: Adding debugger interface and runtime functions hooks for supporting... (issue6351007)

I'll prepare stubbed out lol headers in a separate CL (coming soon). http://codereview.chromium.org/6351007/diff/1/src/d8.js File src/d8.js (right): http://codereview.chromium.org/6351007/diff/1/src/d8.js#newcode592 src/d8.js:592: // Remember the handle requested in a global variable. On 2011/0

[v8-dev] Adding build script changes to support LiveObjectList functionality. (issue6338009)

, 'default': 'off', Index: src/SConscript === --- src/SConscript (revision 6379) +++ src/SConscript (working copy) @@ -89,6 +89,7 @@ lithium-allocator.cc lithium.cc liveedit.cc +liveobjectlist.cc

[v8-dev] Adding debugger interface and runtime functions hooks for supporting... (issue6351007)

Reviewers: Søren Gjesse, Michail Naganov, Message: Adding debugger interface and runtime functions hooks for supporting LiveObjectList functionality. Description: Adding debugger interface and runtime functions hooks for supporting LiveObjectList functionality. Please review this at http://code

[v8-dev] Adding GC hooks to support LiveObjectList functionality. (issue6287004)

Reviewers: Søren Gjesse, Michail Naganov, Description: Adding GC hooks to support LiveObjectList functionality. Please review this at http://codereview.chromium.org/6287004/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/heap.cc M src/mark

[v8-dev] Adding files for LiveObjectList implementation. (issue6357005)

Reviewers: Søren Gjesse, Michail Naganov, Description: Adding files for LiveObjectList implementation. Please review this at http://codereview.chromium.org/6357005/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/flag-definitions.h A src/liveobj

Re: [v8-dev] [v8] r6374 committed - Revert strict mode (Mozilla test failure).

amedPropertyAssigmentFinder this_property_assignment_finder; > - bool directive_prologue = true; // Parsing directive prologue. > - > while (peek() != end_token) { > -if (directive_prologue && peek() != Token::STRING) { > - directive_prologue = false; > -} > - > -Scan

[v8-dev] Adding inspector module and macro-ized object type list. (issue6261012)

Reviewers: Michail Naganov, Søren Gjesse, Description: Adding inspector module and macro-ized object type list. Please review this at http://codereview.chromium.org/6261012/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M SConstruct M src/SConscrip

[v8-dev] Re: Adding SearchableList for implementing a list with fast search capability. (issue6265002)

Hi Søren, I've made the necessary changes and addressed your comments. I've also added the globals.h change that should be part of this CL. However, while investigating the use case for Sort() and Contains(), I discovered that this SearchableList isn't actually in use in my lol implementation

[v8-dev] Re: Introducing MemoryMappedExternalResource for creating an external... (issue6240002)

http://codereview.chromium.org/6240002/diff/15001/src/utils.cc File src/utils.cc (right): http://codereview.chromium.org/6240002/diff/15001/src/utils.cc#newcode301 src/utils.cc:301: if (file_) { On 2011/01/18 10:13:34, Michail Naganov wrote: Please use explicit comparison: if (file_ != NULL). S

[v8-dev] Fixed SConscript to allow both mode=debug and objectprint=on to be specified... (issue6278005)

@@ mark-compact.cc messages.cc objects.cc +objects-printer.cc objects-visiting.cc oprofile-agent.cc parser.cc @@ -233,10 +234,9 @@ 'os:win32': ['platform-win32.cc'], 'mode:release': [], 'mode:debug': [ -

[v8-dev] Fixed typo in calling Thread::set_name() on freebsd. (issue6313003)

Reviewers: Søren Gjesse, Message: Fixed typo in calling Thread::set_name() on freebsd. This addresses the compilation error reported in issue 1051 that is due to a typo in my previous contribution. I understand that the other 2 compilation errors are already being addressed bu issue 966. Descr

[v8-dev] Re: Adding support for live object list heap debugging feature.... (issue6174007)

e wrote: Please add a short description of what lol is. Done. http://codereview.chromium.org/6174007/diff/29002/src/mark-compact.cc File src/mark-compact.cc (right): http://codereview.chromium.org/6174007/diff/29002/src/mark-compact.cc#newcode1657 src/mark-compact.cc:1657: #ifdef LIVE_OBJECT_LIS

[v8-dev] Re: Adding BSearchList for implementing a list with fast search capability. (issue6265002)

Mikhail, Søren, I've incorporated Søren's suggested changes. Please take a look. Thanks. http://codereview.chromium.org/6265002/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Introducing MemoryMappedExternalResource for creating an external... (issue6240002)

http://codereview.chromium.org/6240002/diff/1/src/platform-win32.cc File src/platform-win32.cc (right): http://codereview.chromium.org/6240002/diff/1/src/platform-win32.cc#newcode919 src/platform-win32.cc:919: Win32MemoryMappedFile(HANDLE file, HANDLE file_mapping, void* memory, On 2011/01/16 10

[v8-dev] Re: Adding BSearchList for implementing a list with fast search capability. (issue6265002)

Mikhail, FYI, I just got some feedback from Søren on the list implementation and other bits. I'll incorporate all these changes and then upload the updates. I'll let you know when the revised changes are ready. Thanks. http://codereview.chromium.org/6265002/ -- v8-dev mailing list v8-dev

[v8-dev] Introducing MemoryMappedExternalResource for creating an external... (issue6240002)

Reviewers: Michail Naganov, Description: Introducing MemoryMappedExternalResource for creating an external resource from a memory mapped file for creating strings. Please review this at http://codereview.chromium.org/6240002/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affe

[v8-dev] Adding BSearchList for implementing a list with fast search capability. (issue6265002)

Reviewers: Michail Naganov, Description: Adding BSearchList for implementing a list with fast search capability. Please review this at http://codereview.chromium.org/6265002/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/list-inl.h M src/list

[v8-dev] Re: Adding support for live object list heap debugging feature.... (issue6174007)

On 1/13/11 7:39 AM, "mnaga...@chromium.org" wrote: > Hi Mark, > > I looked at the code, and I think I built up an understanding of > your approach, and it looks great. For the purpose of > committing, please separate your CL into smaller pieces and try > to write so

[v8-dev] Adding support for live object list heap debugging feature.... (issue6174007)

iveobjectlist.h A src/liveobjectlist.cc M src/mark-compact.cc M src/platform-freebsd.cc M src/platform-linux.cc M src/platform-macos.cc M src/platform-nullos.cc M src/platform-openbsd.cc M src/platform-posix.cc M src/platform-solaris.cc M src

[v8-dev] Added a few new debugger tests. (issue6035016)

Reviewers: Søren Gjesse, Message: Hi Søren, Here are 2 new debugger unit tests that test the functionality of listbreakpoints and setexceptionbreak. In rev 6180, I only modified the implementation of listbreakpoints by adding the status of the break on exception states. However, I didn't see a

[v8-dev] Update debugger test to expect new default break on exceptions settings. (issue6086010)

Reviewers: Søren Gjesse, Message: Søren, here is the test changes needed to ensure that r6180 (debugger enhancements) do not fail the tests. I will look into adding additional tests for the other enhancements later. Description: Update debugger test to expect new default break on exceptions

[v8-dev] Instanceof slow case bind is incorrect.... (issue6107001)

Reviewers: Erik Corry, Message: My co-worker found this while merging 3.0.5. I'm not sure about the correctness of the push instruction which appears to push r0 and r1 while the Instanceof builtin seems to expect only a single arg word. However, the location of where the binding of the sl

[v8-dev] Re: Misc debugger enhancements and bug fixes.... (issue5980006)

I've made all the necessary changes except for breaking up long lines which are purely due to long strings in d8.js. I had a question regarding that in my comments below. Please let me know what the preferred practice is there and I'll make the remaining change. Thanks. FYI, I also svn up to

[v8-dev] Re: Added labelled thread names to help with some debugging activity. Right now,... (issue6070009)

FYI, the changes for SConstruct is now removed because we're no longer doing a conditional flag to set DEBUG_THREAD_NAME. http://codereview.chromium.org/6070009/diff/33001/SConstruct File SConstruct (right): http://codereview.chromium.org/6070009/diff/33001/SConstruct#newcode129 SConstruct:12

[v8-dev] Changed #define symbols in test to OBJECT_PRINT from PRINT_OBJECT... (issue6037015)

Reviewers: Søren Gjesse, Description: Changed #define symbols in test to OBJECT_PRINT from PRINT_OBJECT because this is actually what is being used. Please review this at http://codereview.chromium.org/6037015/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M

[v8-dev] Re: Misc debugger enhancements and bug fixes.... (issue5980006)

"step" command now defaults to "step in" (just like how gdb does it) as opposed to "step next". I hope that that's an acceptable change of behavior. Thanks. Mark http://codereview.chromium.org/5980006/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Misc debugger enhancements and bug fixes.... (issue5980006)

ggers a full mark-compact GC. The command also returns the before and after sizes of the heap. 7. Added trace json, and flags commands that are not published in help. trace json is used for tracing the debugger packets send from and received by d8. flags is for setting v8 flags. T

[v8-dev] Added context sensitive prompt for remote debugger. It now shows "> "... (issue5966004)

Reviewers: Søren Gjesse, Description: Added context sensitive prompt for remote debugger. It now shows "> " when the debuggee is running, and "dbg> " when the debuggee is stopped. Please review this at http://codereview.chromium.org/5966004/ SVN Base: http://v8.googlecode.com/svn/branches/ble

[v8-dev] Added labelled thread names to help with some debugging activity. Right now,... (issue6070009)

Reviewers: Søren Gjesse, Message: Søren, I'm not sure you're the right person for this review. If not, can you please pass this on to the right person? Thanks. This change is a small change to add names to threads so that they can be identified by external tools when debugging v8 activity i

[v8-dev] Refactoring out object printing functions into objects-printer.cc. (issue6083001)

Reviewers: Søren Gjesse, Message: Refactored object printing functions into objects-printer.cc. The review error check says there are 10 errors in objects-printer.cc, but looking at the file, I see that it is identical to objects-debug.cc as far as the reported issues are concerned. I assume

[v8-dev] Re: 1. Added support for object printing for release mode using the... (issue5998001)

On 2010/12/17 13:44:03, Søren Gjesse wrote: LGTM, with comment addressed. When this is landed please make the refactoring of all the printing into objects-printer.cc as suggested. Will do. Do you want me to factor out the inline printer functions in objects.h into a objects-printer-inl.h

[v8-dev] 1. Added support for object printing for release mode using the... (issue5998001)

Reviewers: Søren Gjesse, Message: Søren, can you have a look at this change, please? The bulk of this change is to split out object printing functions under the OBJECT_PRINT #define symbol instead of DEBUG. This allows us to enable this functionality in release builds if desired. Ideally, these

[v8-dev] Re: Adding Date::ResetCache() API so that the cache values in the Date object... (issue5978001)

Søren, I've update the changes. Please take another look to see if the comment in v8.h is adequate. Thanks. http://codereview.chromium.org/5978001/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Adding Date::ResetCache() API so that the cache values in the Date object... (issue5978001)

http://codereview.chromium.org/5978001/diff/1/include/v8.h File include/v8.h (right): http://codereview.chromium.org/5978001/diff/1/include/v8.h#newcode1359 include/v8.h:1359: /** On 2010/12/17 10:54:55, Søren Gjesse wrote: Please start the comment with something like this "Notification that t

[v8-dev] Adding Date::ResetCache() API so that the cache values in the Date object... (issue5978001)

Reviewers: Søren Gjesse, Description: Adding Date::ResetCache() API so that the cache values in the Date object can be reset to allow DST / timezone changes to be re-cached and reflected in the Date object. Please review this at http://codereview.chromium.org/5978001/ SVN Base: http://v8.googl

[v8-dev] Heap::gc_count_, last_gc_count, and kGCsBetweenCleanup should be unsigned... (issue5966001)

eenCleanup) { number_idle_notifications = Min(number_idle_notifications + 1, kMaxIdleCount); } else { Index: src/heap.h === --- src/heap.h (revision 6057) +++ src/heap.h (working copy) @@ -1141,7 +1141,7 @@ sta

[v8-dev] This patch fixes Heap::ClearJSFunctionResultCaches() the same way... (issue4187007)

Reviewers: Vyacheslav Egorov, Description: This patch fixes Heap::ClearJSFunctionResultCaches() the same way that Heap::ClearNormalizedMapCache() was implemented in r5654. The existing code effectively does not clear the JSFunctionResultCaches at all. With this patch, the caches are now cleared

[v8-dev] Re: Link all global contexts into a weak list. (issue3764011)

Drive by comment: http://codereview.chromium.org/3764011/diff/1/6 File src/mark-compact.cc (right): http://codereview.chromium.org/3764011/diff/1/6#newcode2277 src/mark-compact.cc:2277: updating_visitor.VisitPointer(&Heap::global_contexts_list_); For consistency, shouldn't this be mad

[v8-dev] Re: Clear normalized map caches in all global contexts. (issue3828011)

LGTM. http://codereview.chromium.org/3828011/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Added USE_SIMULATOR macro that explicitly indicates that we wish to use the s... (issue3825001)

Reviewers: Søren Gjesse, Message: Søren, can you review this change please? Thanks. Description: Added USE_SIMULATOR macro that explicitly indicates that we wish to use the simulator as the execution engine. For example, this allows us to run with the ARM simulator on ARM. Please review this

[v8-dev] Re: Various improvements to oom_dump and instance type lists. (issue3119023)

LGTM http://codereview.chromium.org/3119023/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Various improvements to oom_dump and instance type lists. (issue3119023)

LGTM. Much better, thanks! http://codereview.chromium.org/3119023/diff/1/5 File tools/oom_dump/README (right): http://codereview.chromium.org/3119023/diff/1/5#newcode26 tools/oom_dump/README:26: (Additionally you can control v8 working copy dir, but default should work.) “but the default” http

[v8-dev] Re: Initial implementation of oom_dump utility. (issue3170015)

Mostly cross-architecture programming questions and gotchas. http://codereview.chromium.org/3170015/diff/8001/9001 File tools/oom_dump/README (right): http://codereview.chromium.org/3170015/diff/8001/9001#newcode1 tools/oom_dump/README:1: oom_dump extracts useful information from Google Chrome

Re: [v8-dev] Re: Allow build-time selection between ia32 and x86_64 in the GYP/Xcode Mac Chromium build (issue2133003)

using a 32-bit application but is probably capable of running the 64-bit one. These are informative but not nearly as compelling as the plugin problem (and its solution). Mark -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Allow build-time selection between ia32 and x86_64 in the GYP/Xcode Mac Chromium build (issue2133003)

meaningful concept of “v8_target_arch” on the Mac - in order for everything to work properly, there can’t be any target architecture selection until compilation time. Mark a...@chromium.org wrote: > Mark, I might be missing something here, but selecting the right files to > compile seems like som

[v8-dev] Allow build-time selection between ia32 and x86_64 in the GYP/Xcode Mac Chromium build (issue2133003)

Reviewers: iposva, Message: Most of this, except for the very last file, is mechanical. The #ifdef guards all follow the same V8_TARGET_ARCH_* scheme, except the choice between src/arm/assembler-{arm|thumb2}.cc is handled by checking V8_ARM_VARIANT_* in addition to V8_TARGET_ARCH_ARM. Descri

[v8-dev] Fix dtoa for the LP64 model on 64-bit systems, where long is 64 bits (issue2106007)

Reviewers: iposva, Description: Fix dtoa for the LP64 model on 64-bit systems, where long is 64 bits. dtoa.c:69 states: #define Long int on machines with 32-bit ints and 64-bit longs. This change was made in Chromium's version of dtoa in r21901. I don't know why this apparently hasn't caused a p

[v8-dev] Re: Remove quotes around "44" when checking gcc_version in v8.gyp....

This is correct. LGTM. --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---

[v8-dev] Merge r2895 from bleeding_edge to trunk

Reviewers: iposva, Description: Merge r2895 from bleeding_edge to trunk for immediate use by Chromium. Remove explicit include of Chromium's common.gypi from v8.gyp. Explicit includes of common.gypi are being deprecated. Chromium will include the .gypi files that it needs by asking GYP to fo

[v8-dev] Remove explicit include of Chromium's common.gypi from v8.gyp

Reviewers: iposva, Description: Remove explicit include of Chromium's common.gypi from v8.gyp. Explicit includes of common.gypi are being deprecated. Chromium will include the .gypi files that it needs by asking GYP to force-include them into each .gyp file that it loads. See http://coderevi

[v8-dev] Re: Use SSE2 instructions when available on ia32 platform.

I'm familiar with x86 but much less so with V8 internals, so these questions may be off base. http://codereview.chromium.org/197057/diff/4001/4002 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/197057/diff/4001/4002#newcode6745 Line 6745: FloatingPointHelper::CheckFloatOp

[v8-dev] Enable -fstrict-aliasing in the GYP build of V8 for the Mac in Release mode

Reviewers: Kasper Lund, Description: Enable -fstrict-aliasing in the GYP build of V8 for the Mac in Release mode. -fstrict-aliasing is enabled by mainline gcc at -O2 and higher, but in Apple gcc, it must be enabled explicitly. This results in a 1.5% improvement in V8 benchmark scores. This also

[v8-dev] Re: Don't use -fomit-frame-pointer to build Mac V8

they share the same Breakpad crash reporter core that we use, they're also very interested in being able to use this optimization. Mark --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---

[v8-dev] Don't use -fomit-frame-pointer to build Mac V8

Reviewers: Kasper Lund, Description: Don't use -fomit-frame-pointer to build Mac V8. The Chrome crash reporting system can't currently process stacks produced by gcc -fomit-frame-pointer properly. The drawback outweighs the 2% performance improvement. Once the crash reporting system is able to

[v8-dev] Re: Don't put static variables inline

ed that the rest of v8 is OK, at least on ia32. Mark --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---

[v8-dev] Re: Don't put static variables inline

I filed Apple bug 7070016 for this. I wrote: > I spent a little bit more time with this to be able to come up with a > reduced testcase.  The plan is to file a bug with Apple on the > toolchain part of the issue.  Eventually, I realized that all four of > the cases were the same toolchain issue.

[v8-dev] Re: Don't put static variables inline

the best way to work around this bug. I just wanted to make clear to everyone that the old code was not wrong, it just happened to trigger a bug in the Apple toolchain Mark --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---

[v8-dev] Don't put static variables inline

Reviewers: Yury Semikhatsky, Kasper Lund, iposva, Message: You guys have some pretty creative uses of inlining and static variables in here... There are really two bugs here. I wound up tracing most of this back to static variables within inlined code. When the inlined code comes from a header

[v8-dev] Re: Add gyp file to v8 repository....

This looks good. Thanks, Mads. Mark Mads wrote: > I am committing the following in the v8 repository now.  I'll push > this to chromium ASAP to hopefully solve this issue.  Thanks for > bringing it to my attention. > > -- Mads > > a...@redex:~/v8/v8$ svn diff > >

  1   2   >