[v8-dev] Re: Fix invalid cast of heap constant object. (issue 1323863003 by p...@chromium.org)

2015-08-31 Thread pcc
Did you miss this one? https://codereview.chromium.org/1323863003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Fix invalid cast of heap constant object. (issue 1323863003 by p...@chromium.org)

2015-08-31 Thread pcc via v8-dev
On 2015/09/01 04:17:40, pcc1 wrote: Did you miss this one? Looks like this is redundant with https://codereview.chromium.org/1314473007; closing. https://codereview.chromium.org/1323863003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You

[v8-dev] Re: Use correct template parameters when casting RHS of operator comparison. (issue 1309903005 by p...@chromium.org)

2015-08-31 Thread pcc
On 2015/09/01 04:17:11, commit-bot: I haz the power wrote: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/9312) Looks like this is redundant with https://codereview.chromium.org/1314473007;

[v8-dev] Re: Re-enable LLVM LTO for ARM. (issue 1295673002 by p...@chromium.org)

2015-08-28 Thread pcc
Ping. https://codereview.chromium.org/1295673002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Port cfi configuration from chromium. (issue 1267773004 by machenb...@chromium.org)

2015-07-31 Thread pcc
On 2015/07/31 21:36:18, krasin wrote: On 2015/07/31 21:26:13, Michael Achenbach wrote: On 2015/07/31 15:41:52, krasin wrote: Michael, the internal error looks familiar. See https://crbug.com/513074 https://codereview.chromium.org/1249273003/ Thank you for working on this! There

[v8-dev] Re: Use a different variant of CpuFeatures::FlushICache asm with clang. (issue 986643004 by p...@chromium.org)

2015-03-17 Thread pcc
bmeurer: Ping. https://codereview.chromium.org/986643004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving

[v8-dev] Re: Use a different variant of CpuFeatures::FlushICache asm with clang. (issue 986643004 by p...@chromium.org)

2015-03-09 Thread pcc via v8-dev
On 2015/03/09 10:14:26, jbramley wrote: I'm curious about the constant-pool problem, though. Clang will use constant pools itself, so it must have some way of handling them. Clang will emit constant pools for ldr= at the end of the .text section. With LTO, the .text section could be large

[v8-dev] Re: Use a different variant of CpuFeatures::FlushICache asm with clang. (issue 986643004 by p...@chromium.org)

2015-03-07 Thread pcc
https://codereview.chromium.org/986643004/diff/1/src/arm/cpu-arm.cc File src/arm/cpu-arm.cc (right): https://codereview.chromium.org/986643004/diff/1/src/arm/cpu-arm.cc#newcode51 src/arm/cpu-arm.cc:51: register uint32_t scno asm(r7) = __ARM_NR_cacheflush; On 2015/03/07 18:34:49, bnoordhuis

[v8-dev] Use a different variant of CpuFeatures::FlushICache asm with clang. (issue 986643004 by p...@chromium.org)

2015-03-06 Thread pcc
Reviewers: jbramley, Benedikt Meurer, Description: Use a different variant of CpuFeatures::FlushICache asm with clang. This variant avoids a constant pool entry, which can be problematic when LTO'ing. It is also slightly shorter. According to the description of