Reviewers: Yury Semikhatsky, Yang, Søren Thygesen Gjesse,
Description:
Debugger: naive implementation of "step into Function.prototype.bind".
Please review this at https://chromiumcodereview.appspot.com/9705018/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
Regarding only changing the script source in OnBeforeCompile you could
add a
flag to the Script object and set that when leaving OnBeforeCompile.
Done.
Maybe it even makes sense to use BitField to merge
Type, CompilationType and this new freeze flag into one 32-bit int so that
they
only oc
https://chromiumcodereview.appspot.com/9677043/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
We should check here that the script source is not changed after
BeforeCompile.
I would like to do this, but I did not find a reliable way of telling we are
processing BeforeCompile from within the native runtime.
https://chromiumcodereview.appspot.com/9677043/
--
v8-dev mailing list
v8-dev@go
Reviewers: Yury Semikhatsky,
Description:
Debugger: add ability to set script source from within OnBeforeCompile.
Please review this at https://chromiumcodereview.appspot.com/9677043/
SVN Base: http://v8.googlecode.com/svn/trunk/
Affected files:
M src/mirror-debugger.js
M src/runti
http://codereview.chromium.org/8873053/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
I'll defer it to Søren and Peter since they are the ones to look after the
V8
protocol.
We should really make node work with the WebKit protocol though.
http://codereview.chromium.org/8873053/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
s/following change/following case/
http://codereview.chromium.org/3444011/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
I don't see it working for the following change:
function foo() {
function a() {
b();
}
function b() {
c();
}
function c() {
console.trace(); console.log(new Error().stack); as
}
a();
}
window.eval("(" + foo.toString() + ")(); //@ sourceUR
Reviewers: Søren Gjesse,
Description:
Make following ES5 function work with undetectable parameter/target
(document.all):
ObjectIsPrototypeOf
ObjectDefineGetter
ObjectLookupGetter
ObjectDefineSetter
ObjectLookupSetter
ObjectKeys
ObjectGetPrototypeOf
ObjectGetOwnPropertyDescriptor
ObjectGetOwnPro
Changed my mind - I'd rather through appropriate exception here. Client fix
has
already landed in the WebCore upstream.
http://codereview.chromium.org/1284001
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-
Reviewers: Michail Naganov,
Description:
Experimental bots layout tests fix: handle access to the frame 0 in case
there
are no javascript frames on the stack.
Please review this at http://codereview.chromium.org/1284001
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affecte
Thanks for the review!
http://codereview.chromium.org/1025004/diff/1/4
File include/v8-debug.h (right):
http://codereview.chromium.org/1025004/diff/1/4#newcode249
include/v8-debug.h:249: */
On 2010/03/18 07:31:13, Søren Gjesse wrote:
Please extend the comment here to say that the receiver will
http://codereview.chromium.org/1025004
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: sgjesse_chomium.org,
Description:
Expose debug context into the native code. This change is doing several
things:
1) Exposes Local v8::Debug::GetDebugContext().
Rationale: We can already get debugger context instance using various
workarounds,
so exposing it explicitly in the
Reviewers: Søren Gjesse,
Description:
Object.getOwnPropertyNames should return string names for indexed
properties.
Please review this at http://codereview.chromium.org/596117
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/v8natives.js
M te
http://codereview.chromium.org/565007
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Looks interesting. Couple of questions:
0) Could you send it to Vitaly to get his review?
1) Will this generate AFTER_COMPILE event?
2) Can we act as Eclipse for the cases when new script does not compile?
(replace body with "throw 'Syntax error: ...';" )
http://codereview.chromium.org/546125/di
There are couple of drive-by fixes for preconditions on Object constructor
property functions as well.
I looked into the order issue a bit, but then decided that we already have
enough problems with for-in. Spec does not say anything about the order.
http://codereview.chromium.org/549050/diff/1
Thanks for the review. I will merge into the bleeding edge, address the
comments
and update the patch.
To answer your question, order of the getOwnPropertyNames is not defined. I
am
sticking to whatever is in WebKit nightly.
http://codereview.chromium.org/549050
--
v8-dev mailing list
v8-d
On 2010/01/14 15:02:06, Mads Ager wrote:
Oh, and please perform this change in branches/bleeding_edge instead of
trunk.
Yes, that was supposed to be Soren and yes, I know it should be against
bleeding
edge. Just tell me it looks reasonable (does the right thing, has ok tests,
etc.) and I ge
Reviewers: Mads Ager, sgk,
Message:
I just moved some code around (renamed methods I needed from Debug* to
Get*).
Does this look as expected?
Description:
Implement Object.getOwnPropertyNames constructor property [ES5 section
15.2.3.4].
Please review this at http://codereview.chromium.org/5
LGTM, but please wait for the official one from Soren :)
http://codereview.chromium.org/141041
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
LGTM
http://codereview.chromium.org/126271
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
http://codereview.chromium.org/87026/diff/4007/3015
File test/cctest/test-debug.cc (left):
http://codereview.chromium.org/87026/diff/4007/3015#oldcode3571
Line 3571: queue.Put(Message::NewHostDispatch(new TestClientData()));
On 2009/04/22 14:06:08, Yury Semikhatsky wrote:
> please insert some ot
http://codereview.chromium.org/87026/diff/16/1011
File src/debug.cc (right):
http://codereview.chromium.org/87026/diff/16/1011#newcode1807
Line 1807: if (!command_received_->Wait(100) &&
Debugger::host_dispatch_handler_) {
On 2009/04/21 15:01:58, Søren Gjesse wrote:
> I think we should have an V8
Reviewers: Søren Gjesse, Yury Semikhatsky,
Description:
DevTools: Add support for eventless host message dispatching.
Please review this at http://codereview.chromium.org/87026
SVN Base: http://v8.googlecode.com/svn/trunk/
Affected files:
M include/v8-debug.h
M src/debug.h
M
LGTM
http://codereview.chromium.org/67180
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
LGTM
http://codereview.chromium.org/20491
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
29 matches
Mail list logo
