On 2015/06/29 11:15:32, Sven Panne wrote:
lgtm
Just a side note: The example in
https://chromiumcodereview.appspot.com/10414072/ looks like a bug in MSVC,
not
like undefined behavior. If you simply do
#define FOO
FOO is of course defined, but its expansion is empty. That's fundamentally
di
lgtm
https://codereview.chromium.org/1212163003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
DBC
https://codereview.chromium.org/1207433002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
On 2015/06/24 13:40:01, Jakob wrote:
The style guide forbids non-const references. Either use a const
reference, or
use a pointer, which would have the additional benefit that you can
forward-declare Log::MessageBuilder (and drop the log-utils.h include).
Just a quick note: There seems to be
lgtm
https://codereview.chromium.org/1216833002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM with a nit.
https://codereview.chromium.org/1218443002/diff/1/src/compiler/common-operator-reducer.cc
File src/compiler/common-operator-reducer.cc (right):
https://codereview.chromium.org/1218443002/diff/1/src/compiler/common-operator-reducer.cc#newcode102
src/compiler/common-operator-redu
lgtm
https://codereview.chromium.org/1205353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1205353002/diff/1/src/macros.py
File src/macros.py (right):
https://codereview.chromium.org/1205353002/diff/1/src/macros.py#newcode194
src/macros.py:194: macro CHECK_DATE(arg) = if (!%_IsDate(arg))
%_ThrowNotDateError();
Hopefully not followed by an "else"... :-]
lgtm
https://codereview.chromium.org/1208003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1205023002/diff/80001/test/cctest/compiler/test-run-machops.cc
File test/cctest/compiler/test-run-machops.cc (right):
https://codereview.chromium.org/1205023002/diff/80001/test/cctest/compiler/test-run-machops.cc#newcode5160
test/cctest/compiler/test-run-machops.c
LGTM with nits + more test coverage
https://codereview.chromium.org/1205023002/diff/40001/src/compiler/arm/instruction-codes-arm.h
File src/compiler/arm/instruction-codes-arm.h (right):
https://codereview.chromium.org/1205023002/diff/40001/src/compiler/arm/instruction-codes-arm.h#newcode96
src/
lgtm
https://codereview.chromium.org/1209513002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2015/06/22 07:59:35, titzer wrote:
That sounds like a refactoring that would make sense in a different CL,
separate
from the functionality introduced here.
Yep, see http://martinfowler.com/articles/workflowsOfRefactoring/#2hats :-)
Alas, we normally don't follow that general advice...
ht
DBC
https://codereview.chromium.org/1201783003/diff/1/src/scanner.cc
File src/scanner.cc (right):
https://codereview.chromium.org/1201783003/diff/1/src/scanner.cc#newcode1436
src/scanner.cc:1436: bool Scanner::ContainsDot() {
Instead of using caveman-style loops, the right way to implement this
lgtm
https://codereview.chromium.org/1196623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Hmmm, I'm not sure if this is the right way to proceed: With this CL, we
effectively just shut up the compiler without fixing the underlying
adventurous/creative use of C++'s dark corners. IIRC, OpParameter and/or the
related classes should change or vanish, but I can't remember the details.
If
Reviewers: Benedikt Meurer,
Description:
Replace OFFSET_OF with offsetof as far as possible.
The remaining uses need some non-mechanical work:
* non-standard-layout type, probably due to mixed access control
* extended field designators
Please review this at https://codereview.chromium.or
https://codereview.chromium.org/249183003/diff/1/src/base/macros.h
File src/base/macros.h (right):
https://codereview.chromium.org/249183003/diff/1/src/base/macros.h#newcode39
src/base/macros.h:39: // Here we simply use the non-zero value 4, which
seems to work.
On 2015/06/16 21:02:46, Nico wrot
lgtm
https://codereview.chromium.org/1183123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1186713003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1182303003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM if my nit is addressed, BTW :-)
https://codereview.chromium.org/1178403004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group
https://codereview.chromium.org/1178403004/diff/20001/src/compiler/simplified-lowering.cc
File src/compiler/simplified-lowering.cc (right):
https://codereview.chromium.org/1178403004/diff/20001/src/compiler/simplified-lowering.cc#newcode75
src/compiler/simplified-lowering.cc:75:
info_(zone->NewA
Quick DBC...
https://codereview.chromium.org/1157663007/diff/160001/src/compiler/register-allocator.h
File src/compiler/register-allocator.h (right):
https://codereview.chromium.org/1157663007/diff/160001/src/compiler/register-allocator.h#newcode969
src/compiler/register-allocator.h:969: if (a_
LGTM with a nit (didn't really look at the platform-dependent parts)
https://codereview.chromium.org/1133163005/diff/220001/src/base/platform/time.cc
File src/base/platform/time.cc (right):
https://codereview.chromium.org/1133163005/diff/220001/src/base/platform/time.cc#newcode114
src/base/plat
lgtm
https://codereview.chromium.org/1174693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1170723003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1155043005/diff/20001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/1155043005/diff/20001/src/api.cc#newcode7256
src/api.cc:7256: COMPILE_ASSERT(i::FIRST_SPACE == 0,
first_space_assumed_to_be_zero);
Sorry for chiming in so late, but IMHO this
lgtm
https://codereview.chromium.org/1151523014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1164933005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1163143005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1157053007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1153233004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
You need to use your <*@*.ibm.com> email address, otherwise the CL will
complain...
https://codereview.chromium.org/1153413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "
lgtm
https://codereview.chromium.org/1153413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Hmmm, this really looks like an omission on the C++ side, but I'm not 100%
sure.
@Toon: Could you have a look, please?
Another thing is the ".Check()" part: I don't think that crashing is an
option
here, returning e.g. MaybeHandle() is probably better.
Regarding the failure on the v8_linux_
lgtm
https://codereview.chromium.org/1159743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: mvstanton,
Description:
JavaScript stubs have access to their calling convention and minor key now.
First steps only, the TurboFan compilation is still triggered from C++ land.
Includes some simplifications/cleanups, too.
Please review this at https://codereview.chromium.org/1150263
Reviewers: Benedikt Meurer,
Description:
Unbreak %DebugPrint output.
Please review this at https://codereview.chromium.org/1155773003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -2 lines):
M src/runtime/runtime-test.cc
Index: src/runtime/runtime-test.c
Reviewers: mvstanton,
Description:
Add a TurboFan skeleton for StringAddStub.
Currently the stub simply calls out to the runtime, this will be
improved in a later CLs. The current state at least avoids bit-rot and
later merging horror.
Contains quite a few tiny cleanups in stub-land, too.
Plea
DBC...
https://codereview.chromium.org/1146963002/diff/20001/test/mjsunit/get-caller-js-function.js
File test/mjsunit/get-caller-js-function.js (right):
https://codereview.chromium.org/1146963002/diff/20001/test/mjsunit/get-caller-js-function.js#newcode8
test/mjsunit/get-caller-js-function.js:8
lgtm
https://codereview.chromium.org/1147923002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1133243006/diff/20001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1133243006/diff/20001/src/heap/heap.h#newcode1084
src/heap/heap.h:1084: if (sizeof(int) < sizeof(int64_t) && total >
kMaxInt) {
On 2015/05/19 14:23:25, Jakob wrote:
LGTM. IMHO a regression test is not really necessary, it was just a dumb
typo
and there are probably 1 similar things in api.cc which would need such
a
test. But if you're bored, feel free... :-D
https://codereview.chromium.org/1138723003/
--
--
v8-dev mailing list
v8-dev@googlegroups.co
Reviewers: Hannes Payer,
Message:
This should fix the problems encountered while trying to debug
chromium:489006...
Description:
Fixed various simulator-related space leaks.
Alas, this involved quite a bit of copy-n-paste between the
architectures, but this is caused by the very convoluted
rela
Reviewers: Hannes Payer,
Description:
Use USE_SIMULATOR when appropriate.
Please review this at https://codereview.chromium.org/1142043003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -27 lines):
M src/isolate.h
Index: src/isolate.h
diff --git a/src/iso
https://codereview.chromium.org/1112123002/diff/40001/test/unittests/compiler/typer-unittest.cc
File test/unittests/compiler/typer-unittest.cc (right):
https://codereview.chromium.org/1112123002/diff/40001/test/unittests/compiler/typer-unittest.cc#newcode307
test/unittests/compiler/typer-unittes
On 2015/05/13 07:43:03, dougc wrote:
[...] Yes this sounds good and improved testing performance. Note the
test is
still
slow - more testing has been added. The test takes around 5 seconds here.
If
you
can give me a realistic time then testing can be scaled to fit? [...]
5 seconds are rou
On 2015/05/11 07:56:18, wingo wrote:
What do you want to do with these, Sven? I can always build locally with
-Werror off, we can change the DCHECK_EQ somehow, or I can continue to
submit
these. As you like, let me know.
[ Better late than never... ;-) ]
The underlying problem here is the
lgtm
https://codereview.chromium.org/1116923002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1105363003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1116853002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1115763003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
LGTM, but in future CLs please use "nullptr" instead of "NULL", the later is
so... old-skool! ;-)
https://codereview.chromium.org/1112883002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to
Test added, PTAL...
https://codereview.chromium.org/1108563002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivin
Feedback addressed, platform ports added, PTAL...
https://codereview.chromium.org/1108563002/diff/60001/src/compiler/instruction-selector.cc
File src/compiler/instruction-selector.cc (right):
https://codereview.chromium.org/1108563002/diff/60001/src/compiler/instruction-selector.cc#newcode1046
On 2015/04/29 09:29:36, Erik Corry wrote:
If you cast the pointer to unintptr_t then the subsequent downcast to
unsigned
(not int) will be well defined, not implementation defined.
It won't, in practice, make any difference to anything, because none of
the
compilers we care about define thi
PTAL, as discussed offline: Let's land this first and add the spill marking
phase in the register allocator separately.
https://codereview.chromium.org/1053123006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you a
Late DBC...
https://codereview.chromium.org/1108313003/diff/60001/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/1108313003/diff/60001/src/x64/lithium-codegen-x64.cc#newcode5174
src/x64/lithium-codegen-x64.cc:5174: DeoptimizeIf(not_ze
Reviewers: Benedikt Meurer,
Message:
Currently x64 port only and no test, just to get an initial round of review
comments.
Description:
Detect simple tail calls
This CL contains the first steps towards tail call optimization:
* Structurally detect tail calls during instruction selection,
On 2015/04/28 07:28:15, titzer wrote:
On 2015/04/28 06:00:13, Sven Panne wrote:
> NOT LGTM. Funny multi-stage initialization of objects is an
anti-pattern,
the
> right way to do handle the case at hand would be C++11's brace-or-equal
> initializers (see https://codereview.chromium.org/9139930
lgtm
https://codereview.chromium.org/733002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
NOT LGTM. Funny multi-stage initialization of objects is an anti-pattern,
the
right way to do handle the case at hand would be C++11's brace-or-equal
initializers (see https://codereview.chromium.org/913993004/#ps20001).
Alas, the
ARM toolchain has some bugs, at least the last time I tried, so
LGTM (rubber-stamped :-} )
https://codereview.chromium.org/1103533002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop r
lgtm
https://codereview.chromium.org/1107883002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
DBC
https://codereview.chromium.org/1105693002/diff/1/src/heap/identity-map.h
File src/heap/identity-map.h (right):
https://codereview.chromium.org/1105693002/diff/1/src/heap/identity-map.h#newcode68
src/heap/identity-map.h:68: return static_cast((raw_address >> 11)
^ raw_address);
On 2015/04/2
On 2015/04/23 14:11:52, wingo wrote:
No idea why these checks are causing warnings and the above "if
(value==0) {}"
check isn't, but so it is. [...]
The DCHECK_FOO macros are totally fragile because they highly depend on the
complex interaction between integral promotion, candidate selection
lgtm
https://codereview.chromium.org/1105653002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1087133004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM. Bonus points for trimming the #includes back. :-)
https://codereview.chromium.org/1104453006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscri
Reviewers: dcarney,
Description:
Simplified 'return' handling in the instruction selector.
The RawMachineAssembler now behaves like the rest of TurboFan,
removing the need for some special cases.
Please review this at https://codereview.chromium.org/1090393003/
Base URL: https://chromium.googl
lgtm
https://codereview.chromium.org/1056063004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
st/mjsunit/mjsunit.status
diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status
index
997fdbaa486c3dac60e645071db4bb5ce80f7401..265e8dfb88470d9bd70a126374a8fbd212f51181
100644
--- a/test/mjsunit/mjsunit.status
+++ b/test/mjsunit/mjsunit.status
@@ -396,9 +396,6 @@
'big-array-literal': [SKIP],
'big-o
lgtm
https://codereview.chromium.org/1100713003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: dcarney,
Description:
Removed src/{isolate,property-details,utils}-inl.h
Baby steps towards saner #includes...
Please review this at https://codereview.chromium.org/1051393003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+76, -151 lines):
M BUILD.
On 2015/04/21 01:40:22, rmacnak wrote:
On 2015/03/18 10:19:27, I haz the power (commit-bot) wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/15f8213809a57c2a163b500a732c9ffe5160a41a
> Cr-Commit-Position: refs/heads/master@{#27263}
This change is responsible for a 70% drop in the Parser
Tiny DBC...
https://codereview.chromium.org/1092353002/diff/40001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/1092353002/diff/40001/src/code-stubs.h#newcode1251
src/code-stubs.h:1251: BinaryOpICStub(Isolate* isolate, Token::Value op,
bool strong)
Boolean para
Feedback addressed, landing...
https://codereview.chromium.org/1098863003/diff/1/src/compiler/arm/instruction-selector-arm.cc
File src/compiler/arm/instruction-selector-arm.cc (right):
https://codereview.chromium.org/1098863003/diff/1/src/compiler/arm/instruction-selector-arm.cc#newcode1103
src
Reviewers: Michael Starzinger,
Description:
Import Reversed adapter from Chromium and use it in v8.
Please review this at https://codereview.chromium.org/1098863003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+88, -48 lines):
M BUILD.gn
A src/base/adapters
Reviewers: dcarney,
Message:
Just as a basis for discussions/initial feedback about the approach. We
need to
move this around a bit (into the register allocator), as discussed. Probably
split off the adapters.h addition into a separate CL.
Description:
Calculate blocks needing a frame and fra
lgtm
https://codereview.chromium.org/1051213005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
DBN (drive-by nit ;-)
https://codereview.chromium.org/1089363002/diff/1/src/messages.cc
File src/messages.cc (right):
https://codereview.chromium.org/1089363002/diff/1/src/messages.cc#newcode188
src/messages.cc:188: unsigned int i = 0;
Actually, this should be size_t...
https://codereview.chro
lgtm
https://codereview.chromium.org/1058533007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1058533007/diff/1/src/arm64/lithium-codegen-arm64.cc
File src/arm64/lithium-codegen-arm64.cc (right):
https://codereview.chromium.org/1058533007/diff/1/src/arm64/lithium-codegen-arm64.cc#newcode4319
src/arm64/lithium-codegen-arm64.cc:4319: DCHECK((right > -kMaxInt
https://codereview.chromium.org/1058533007/diff/1/src/arm64/lithium-codegen-arm64.cc
File src/arm64/lithium-codegen-arm64.cc (right):
https://codereview.chromium.org/1058533007/diff/1/src/arm64/lithium-codegen-arm64.cc#newcode4319
src/arm64/lithium-codegen-arm64.cc:4319: DCHECK((right > -kMaxInt
Reviewers: Benedikt Meurer,
Description:
Added Donald Stence to PPC owners.
Please review this at https://codereview.chromium.org/1065443004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -0 lines):
M src/compiler/ppc/OWNERS
M src/ic/ppc/OWNERS
M src/pp
DBC
https://codereview.chromium.org/1063703005/diff/1/src/v8natives.js
File src/v8natives.js (right):
https://codereview.chromium.org/1063703005/diff/1/src/v8natives.js#newcode234
src/v8natives.js:234: if (%_Likely(harmony_tostring)) {
Just a small warning about %_Likely/%_Unlikely support:
DBC, couldn't resist. :-D
https://codereview.chromium.org/1080023002/diff/20001/src/compiler/js-graph.h
File src/compiler/js-graph.h (right):
https://codereview.chromium.org/1080023002/diff/20001/src/compiler/js-graph.h#newcode34
src/compiler/js-graph.h:34: for (size_t i = 0; i < kNumCachedNode
lgtm
https://codereview.chromium.org/1084853002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1087533002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1085623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1078453002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Benedikt Meurer,
https://codereview.chromium.org/1070723002/diff/20001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://codereview.chromium.org/1070723002/diff/20001/src/x64/code-stubs-x64.cc#newcode1543
src/x64/code-stubs-x64.cc:1543: __ sarp(rdx, Immediate(
LGTM, too. IIRC, my change was only shifting around things a bit to get rid
of
the Isolate*.
https://codereview.chromium.org/1069423003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Goog
lgtm
https://codereview.chromium.org/1072743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM with a nit
https://codereview.chromium.org/1066393002/diff/60001/src/compiler/machine-operator.h
File src/compiler/machine-operator.h (right):
https://codereview.chromium.org/1066393002/diff/60001/src/compiler/machine-operator.h#newcode202
src/compiler/machine-operator.h:202: // Floating p
Reviewers: Michael Starzinger,
Description:
[TurboFan] Fixed handling of CallIC return type.
Although all this code might be moved around later, it's a good idea
to unhackify it now. :-)
Please review this at https://codereview.chromium.org/1067193004/
Base URL: https://chromium.googlesource.c
lgtm
https://codereview.chromium.org/1069633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2015/04/07 20:59:51, caitp wrote:
On 2015/04/07 20:59:28, caitp wrote:
> How about CallRuntime vs CallJSRuntime? (since I aded the
EmitLoadJSRuntime
and
> EmitCallJSRuntime bits un full-codegen, the name seems to make sense)
But, that's sort of out of scope for this CL I think =)
Yep,
On 2015/04/07 13:15:03, caitp wrote:
On 2015/04/07 13:14:21, caitp wrote: [...]
> In ParseV8Intrinsics(), `Runtime::Function* function =
> Runtime::FunctionForName(name->string());` will evaluate to nullptr. If
the
> identifier starts with an underscore, a "not_defined" error is reported.
> Ot
1 - 100 of 3070 matches
Mail list logo
