lgtm
https://chromiumcodereview.appspot.com/473913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving email
Ulan, friendly ping.
https://chromiumcodereview.appspot.com/363553005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop r
So the sourceURL is not available in the "before compile" debug event.
See the test fix. aandrey@, is this okay from the dev tools side? (yurys@
said
previously that the dev tools side should be okay as long as cctest
passes,
and
it does now).
AFAIK DevTools only uses BeforeCompile event
Friendly ping
https://codereview.chromium.org/264333007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving email
https://codereview.chromium.org/264333007/diff/150001/src/parser.cc#newcode3863
> > src/parser.cc:3863: isolate()->Throw(*result, &location);
> > Won't Debug::OnException trigger as well? The call to
Debug::OnCompileError
> > doesn't actually contain the syntax error location, right? So you
w
lgtm
https://codereview.chromium.org/264333007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Looks good to me.
yurys@, yangguo@, Could you please take a look on that?
https://chromiumcodereview.appspot.com/264333007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-
Looks good to me.
https://chromiumcodereview.appspot.com/264333007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop rece
https://codereview.chromium.org/316173002/diff/120001/src/scanner.cc#newcode318
src/scanner.cc:318: // Magic comments are of the form
\s*name\s*=\s*value\s*.*
and this function
We might need to allow only single whitespace between @ and sourceURL=
and no
space between sourceURL and =:
..
The result seems unchanged why the tests would break?
Oh, I didn't get it, you are right, this is fine.
https://codereview.chromium.org/316173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
https://codereview.chromium.org/316173002/diff/120001/src/messages.js#oldcode561
src/messages.js:561: if (this.hasCachedNameOrSourceURL) {
This should be done in a separate patch, otherwise v8 roll is going to
break
blink (blink can not migrate to new way of getting source_url before the
rol
https://codereview.chromium.org/316173002/diff/120001/src/messages.js
File src/messages.js (left):
https://codereview.chromium.org/316173002/diff/120001/src/messages.js#oldcode561
src/messages.js:561: if (this.hasCachedNameOrSourceURL) {
This should be done in a separate patch, otherwise v8 roll
FYI: Here is a blink side patch. It seems to pass all the tests.
https://codereview.chromium.org/323523004/
https://codereview.chromium.org/316173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
https://chromiumcodereview.appspot.com/264333007/diff/20001/include/v8-debug.h
File include/v8-debug.h (right):
https://chromiumcodereview.appspot.com/264333007/diff/20001/include/v8-debug.h#newcode25
include/v8-debug.h:25: ScriptFailedToParse = 9
SyntaxError
https://chromiumcodereview.appspot.
The latest patch set parses both sourceURL and sourceMappingURL, and
allows
them
in the middle of the script too (the later one overrides the previous
one, if
there are several instances of the same value).
Great, thank you!
I'm not sure if you'd need more plumbing than this, for example,
s
function bar() {}
?
I don't like this syntax and would prefer if we didn't support it, but I we
support it in our current implementation
and it is possible that some of our users would be upset if we change that.
We can still change it later (I hope the diff wouldn't be big)
vsevi
I believe we should consider only sourceURL that are at the end of file.
If
there is something like
function foo(){}
//@ sourceURL = url.js
function bar(){}
we should skip the url as far as I remember.
This is not quite so. For example we want to support a case when the script
has
both s
Now that I looked closer at this API, I see (if I'm not mistaken) two
ways to
get the script name of where the exception was thrown:
- Through the script in the Message object, like exposed in this CL.
- Through the stack trace in the Message object. The top most function in
the
stack trace c
Yeah, you are right. We discussed this with Vsevolod and it seems that
what we
actually need in debugger is a public API to v8::internal::Script object
that
contains all the data.
After discussion with the V8 team it seems that there is no plans to change
API
to support this case.
Do you th
https://chromiumcodereview.appspot.com/306463002/diff/60001/src/isolate.cc
File src/isolate.cc (left):
https://chromiumcodereview.appspot.com/306463002/diff/60001/src/isolate.cc#oldcode1157
src/isolate.cc:1157: if
(!is_catchable_by_javascript(pending_exception())) {
Looking at this once again I
yangguo@, Could you please have a look on this?
https://chromiumcodereview.appspot.com/306463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe
lgtm
https://chromiumcodereview.appspot.com/306463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
https://chromiumcodereview.appspot.com/306463002/diff/20001/src/isolate.cc
File src/isolate.cc (right):
https://chromiumcodereview.appspot.com/306463002/diff/20001/src/isolate.cc#newcode1730
src/isolate.cc:1730: bool has_externaly_caught = HasExternallyCaught();
has_external_try_catch
https://c
Can we add a test?
https://chromiumcodereview.appspot.com/306463002/diff/1/src/isolate.cc
File src/isolate.cc (right):
https://chromiumcodereview.appspot.com/306463002/diff/1/src/isolate.cc#newcode1727
src/isolate.cc:1727: // Return true. if we don't pending message and can
remove it
Either com
Yury, could you please take a look?
https://chromiumcodereview.appspot.com/265593002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this g
https://codereview.chromium.org/265593002/diff/40001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/265593002/diff/40001/include/v8.h#newcode1134
include/v8.h:1134: * Returns the resource name for the script from where
the function causing
Returns the resource name or so
Reviewers: yurys, dcarney,
Message:
yurys@, could you please take a look?
dcarney@, could you please OWNER review this?
Description:
Stack trace string should use dynamic script sourceURL if present.
BUG=v8:2342
R=yurys
Please review this at https://codereview.chromium.org/143283015/
SVN Base
Reviewers: Yury Semikhatsky, Toon Verwaest,
Message:
yurys@: Could you please review this change?
verwaest@: Could you please OWNER review this change?
Description:
Add scriptId to StackTrace frames.
BUG=v8:2865
Please review this at https://codereview.chromium.org/23536007/
SVN Base: git:
https://codereview.chromium.org/16035027/diff/17001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/16035027/diff/17001/src/compiler.cc#newcode1188
src/compiler.cc:1188: Handle name =
GetScriptNameOrSourceURL(script);
Can you just do GetScriptNameOrSourceURL here?
W
Reviewers: Yury Semikhatsky,
Description:
Add support for //# sourceURL similar to deprecated //@ sourceURL one.
BUG=v8:2702
Please review this at https://codereview.chromium.org/15859010/
SVN Base: git://github.com/v8/v8.git@master
Affected files:
M include/v8.h
M src/messages.js
M tes
Reviewers: Yury Semikhatsky,
Message:
Please take another look
Description:
Supported sourceURL comments for scripts having a name.
sourceURL comment is now preferred script name for all scripts except
for those with non zero start position (e.g. inline scripts in HTML).
BUG=2342
Please rev
31 matches
Mail list logo
