Reviewers: kozyatinskiy, Yang,
Description:
Postpone interrupts while dipatching debugger events to listeners
The interrupts are already postponed in message handlers [1]. This CL aligns
debug event listener (the mechanism that is actually used in Chrome
DevTools)
implementation with that.
Yang, please take a look.
In next CL I'm going to extract common code from
OnBeforeCompile/OnAfrerCompile/OnCompileError. There is too much
duplication at
the moment.
https://codereview.chromium.org/1321263002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: ,
https://codereview.chromium.org/1316213005/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):
https://codereview.chromium.org/1316213005/diff/1/src/debug/debug.cc#newcode1978
src/debug/debug.cc:1978: if (in_nested_debug_scope) {
It is unfortunate that we cannot simply call
https://codereview.chromium.org/1316213005/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):
https://codereview.chromium.org/1316213005/diff/1/src/debug/debug.cc#newcode1978
src/debug/debug.cc:1978: if (in_nested_debug_scope) {
It is unfortunate that we cannot simply call
lgtm
https://codereview.chromium.org/1304873011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1308123006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1308123006/diff/1/src/json-parser.h
File src/json-parser.h (right):
https://codereview.chromium.org/1308123006/diff/1/src/json-parser.h#newcode249
src/json-parser.h:249: isolate()-debug()-OnAfterCompile(script);
Can you add a test for this please?
Reviewers: dgozman, Yang,
Description:
Remove RestartFrame from live edit API
There is already non-throwing version FrameMirror.restart and RestartFrame
in
the livedit-debugger.js just adds a throwing wrapper around it.
Chromium side was fixed in https://codereview.chromium.org/1249013002/
Reviewers: jochen,
Description:
Add convenience method for converting v8::PersistentBase to v8::Local
The CL addes convenienve method that allows to write code like the following
v8::Localv8::Object local = v8::Localv8::Object::New(global, isolate);
in a more concise way:
v8::Localv8::Object
+caseq
https://codereview.chromium.org/988893003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
LGTM. Thanks for keeping us posted and good to hear that try-catch are
going to
be optimizable.
https://codereview.chromium.org/1213113007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the
lgtm
https://codereview.chromium.org/1182703003/diff/1/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (right):
https://codereview.chromium.org/1182703003/diff/1/test/cctest/test-debug.cc#newcode3839
test/cctest/test-debug.cc:3839:
Function.call.apply(bar);
Can you add one more
On 2015/06/15 11:44:15, ulan wrote:
On 2015/03/16 09:49:35, commit-bot: I haz the power wrote:
Patchset 1 (id:??) landed as
https://crrev.com/f92c8a36709efb1514846b3bb672c40e4fb4c672
Cr-Commit-Position: refs/heads/master@{#27208}
When removing deprecated functions in future, please add in
lgtm
https://codereview.chromium.org/1129363003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1132643004/diff/1/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/1132643004/diff/1/src/debug.cc#newcode903
src/debug.cc:903: PreserveDebugState state(this);
I wonder how evaluating breakpoint condition can change the stepping
state. The
Well, I think if there is e.g. debugger; statement in the condition
expression
we will stop above on the stack and may well adjust debugger state.
Restoring it
completely may be confusing.
https://codereview.chromium.org/1132643004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
On 2015/05/15 22:06:18, Yang wrote:
On 2015/05/15 22:04:42, yurys_slow wrote:
https://codereview.chromium.org/1132643004/diff/1/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/1132643004/diff/1/src/debug.cc#newcode903
src/debug.cc:903: PreserveDebugState
@yangguo, friendly ping?
https://codereview.chromium.org/1126103006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Reviewers: haraken, Yang, kozyatinskiy,
https://codereview.chromium.org/1136733002/diff/1/test/mjsunit/regress/regress-3960.js
File test/mjsunit/regress/regress-3960.js (right):
https://codereview.chromium.org/1136733002/diff/1/test/mjsunit/regress/regress-3960.js#newcode5
Blink-side change if you're curious.
https://codereview.chromium.org/1126103006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group
Blink-side change if you're curious:
https://codereview.chromium.org/1141553003/
https://codereview.chromium.org/1126103006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
https://codereview.chromium.org/1126103006/diff/20001/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):
https://codereview.chromium.org/1126103006/diff/20001/src/runtime/runtime-debug.cc#newcode248
src/runtime/runtime-debug.cc:248: if
https://codereview.chromium.org/1126103006/diff/1/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):
https://codereview.chromium.org/1126103006/diff/1/src/runtime/runtime-debug.cc#newcode223
src/runtime/runtime-debug.cc:223: result-set(0,
Reviewers: Yang,
Message:
This is exact copy of
https://crrev.com/bdeb0de88c8cf5f2c78f261b45314138f525110d
with fix for gcmole applied in PS#2
Description:
Provide accessor for object internal properties that doesn't require
debugger to
be active
Some of the DevTools' clients need to
Reviewers: Yang, pfeldman_ooo_may11, kozyatinskiy,
Description:
Provide accessor for object internal properties that doesn't require
debugger to
be active
Some of the DevTools' clients need to inspect JS objects without enabling
debugger. This CL allows to inspect object's internal
Yang, please take a look
https://codereview.chromium.org/1126103006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Yeah, this code doesn't work well with chrome sandbox. I see the following
errors in the console and the renderer crashes on start.
../../sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc:**CRASHING**:seccomp-bpf
failure in syscall 0229
On 2015/05/07 12:54:34, noordhuis wrote:
On 2015/05/07 10:17:20, yurys wrote:
Yeah, this code doesn't work well with chrome sandbox. I see the
following
errors in the console and the renderer crashes on start.
../../sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc:**CRASHING
https://codereview.chromium.org/1118533003/diff/20001/src/cpu-profiler.cc
File src/cpu-profiler.cc (right):
https://codereview.chromium.org/1118533003/diff/20001/src/cpu-profiler.cc#newcode140
src/cpu-profiler.cc:140: #if V8_OS_WIN
On 2015/04/30 05:06:01, Benedikt Meurer wrote:
I don't really
: #if V8_OS_WIN
On 2015/04/30 08:10:02, yurys wrote:
On 2015/04/30 05:06:01, Benedikt Meurer wrote:
I don't really like this special casing for Windows here. Is there no
alternative to Sleep on Windows which would work for our purpose?
Would Multimedia Timers work here?
They have 1ms resolution at best
lgtm, looks like this is the simplest way to get a meaningful location
location
for the errors occurred at EOS.
https://codereview.chromium.org/1100993003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
https://codereview.chromium.org/1100993003/diff/1/src/messages.js
File src/messages.js (right):
https://codereview.chromium.org/1100993003/diff/1/src/messages.js#newcode404
src/messages.js:404: if (position - 1 line_ends[upper]) {
I'd rather v8 highlighted position of the last token before EOS
Looks like heap profiler needs update to treat references from
weak_stack_trace_list (or probabli WeakFixedArray in general) as weak.
https://codereview.chromium.org/1103843002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
:
On 2015/03/30 20:33:15, yurys wrote:
unsigned int - unsigned
I think that size_t is the right type here, isn't it? It might be the
case that
we have wrong types internally, but at least we should get things
right on the
external API.
Agree, size_t would be even better.
https
https://codereview.chromium.org/1045753002/diff/70001/include/v8-profiler.h
File include/v8-profiler.h (right):
https://codereview.chromium.org/1045753002/diff/70001/include/v8-profiler.h#newcode25
include/v8-profiler.h:25: unsigned int position;
unsigned
https://codereview.chromium.org/1045753002/diff/90001/include/v8-profiler.h
File include/v8-profiler.h (right):
https://codereview.chromium.org/1045753002/diff/90001/include/v8-profiler.h#newcode25
include/v8-profiler.h:25: unsigned int position;
unsigned int - unsigned
: !isolate-stack_guard()-CheckDebugBreak();
On 2015/03/26 19:44:48, yurys wrote:
RequestDebugBreak can be called on another thread. It means that in the
beginning of this method CheckDebugBreak could be false while here it is
already
true and is_debugger_statement will be false even though this method
On 2015/03/27 08:50:33, Dmitry Lomov (chromium) wrote:
On 2015/03/26 19:44:49, yurys wrote:
https://codereview.chromium.org/1032353002/diff/20001/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):
https://codereview.chromium.org/1032353002/diff/20001/src/runtime
LGTM. Thanks for explaining this, Dmitry!
https://codereview.chromium.org/1032353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
https://codereview.chromium.org/1032353002/diff/20001/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):
https://codereview.chromium.org/1032353002/diff/20001/src/runtime/runtime-debug.cc#newcode24
src/runtime/runtime-debug.cc:24:
!isolate-stack_guard()-CheckDebugBreak();
lgtm
https://codereview.chromium.org/1036863002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: alph, jochen,
Description:
Remove v8::Isolate::ClearInterrupt
The method was deprecated a while ago:
https://crrev.com/87e4bba31eabfd3b12e42b5886dc9da08d2daf13
LOG=Y
BUG=None
Please review this at https://codereview.chromium.org/1032623007/
Base URL:
@jochen: please do OWNERS review
https://codereview.chromium.org/1032623007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
On 2015/03/25 14:27:01, Yang wrote:
On 2015/03/25 14:24:20, yurys wrote:
@jochen: please do OWNERS review
drive-by lgtm.
thanks!
https://codereview.chromium.org/1032623007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received
I'm going to wait with landing Blink code that uses the new API until
Chrome is
branched to avoid possible problems with reverting bad V8 rolls.
https://codereview.chromium.org/1037803002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Reviewers: alph, loislo, Yang,
Description:
Return timestamp of the last recorded interval to the caller of
HeapProfiler::GetHeapStats
Before this patch the embedder could assign timestamp to the last interval
after
calling GetHeapStats. This would be slightly different from the timstamps
https://codereview.chromium.org/1019813004/diff/20001/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/1019813004/diff/20001/src/heap-snapshot-generator.cc#newcode2949
src/heap-snapshot-generator.cc:2949: JSON_S(timstamp_ms) ,
On
On 2015/03/20 10:24:59, Yang wrote:
On 2015/03/20 08:30:41, yurys wrote:
https://codereview.chromium.org/1019813004/diff/20001/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/1019813004/diff/20001/src/heap-snapshot-generator.cc
Yang: please do OWNERS review.
https://codereview.chromium.org/1019813004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Reviewers: alph, loislo,
Description:
Save heap object tracking data in heap snapshot
Every time embedder calls v8::HeapProfiler::GetHeapStats we store next
unuassigned heap object id and timestamp of the request. This patch
serializes
all that data into heap snapshot so that embedder can
https://codereview.chromium.org/1019813004/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/1019813004/diff/1/src/heap-snapshot-generator.cc#newcode3080
src/heap-snapshot-generator.cc:3080:
Yang: please do OWNERS review.
https://codereview.chromium.org/1019813004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Reviewers: jochen (slow), Yang,
Description:
Introduce explicit constant for per Context debug data set by embedder
It's value is hardwired in gin[1] and is referenced in Blink[2]. Since it is
treated specially by v8 debugger it should be defined in v8 API and
referenced
in gin and blink..
On 2015/03/17 11:07:00, nduca wrote:
Hmm! I think this is actually an interesting use case to get right, if
possible...
I'm open to storing an isolate id or world id on every trace event that
comes
in from v8 or blink. For instance, we could add to
base/debug/trace_event* a
iid
field on
Reviewers: aandrey, dcarney, Yang,
Description:
Provide method for getting Isolate by v8::Message
v8::Message::GetIsolate will allow to avoid v8::Isolate::GetCurrent calls in
Blink message listeners.
BUG=None
LOG=Y
Please review this at https://codereview.chromium.org/1015643002/
Base URL:
On 2015/03/17 09:16:02, dcarney wrote:
On 2015/03/17 09:14:05, dcarney wrote:
lgtm
it would be preferred to pass the isolate in the messagecallback, would
that
be
okay? if so, i'll prepare a cl to change the callback instead
It would work either way, I don't have strong opinion on
On 2015/03/17 10:25:25, dcarney wrote:
It would work either way, I don't have strong opinion on that. I'd
rather
incorporate error object passed as a separate parameter to
MessageCallback
into
Message object and have MessageCallback accept single parameter. What's
the
advantage of
lgtm
https://codereview.chromium.org/1013753007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2015/03/17 10:31:01, dcarney wrote:
On 2015/03/17 10:30:12, yurys wrote:
On 2015/03/17 10:25:25, dcarney wrote:
It would work either way, I don't have strong opinion on that. I'd
rather
incorporate error object passed as a separate parameter to
MessageCallback
into
Message
https://codereview.chromium.org/995183005/diff/1/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/995183005/diff/1/src/compiler.cc#newcode291
src/compiler.cc:291: if (FLAG_hydrogen_track_positions) {
!script-source()-IsUndefined()
lgtm
https://codereview.chromium.org/995183005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
This patch seems to be doing too many things at once. Can you split it?
https://codereview.chromium.org/1012633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
lgtm
https://codereview.chromium.org/1011733002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1011733005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1002263004/diff/20001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1002263004/diff/20001/src/preparser.h#newcode2320
src/preparser.h:2320: done = (peek() == Token::RPAREN);
On 2015/03/16 07:24:33, Yang wrote:
I think it's cleaner
Reviewers: Yang, jochen (slow), kozyatinskiy,
Message:
A couple of layout tests that currently expect
Uncaught SyntaxError: Unexpected end of input
output will likely need to be updated before landing this change.
Description:
Beautify syntax error for unterminated argument list
https://codereview.chromium.org/919653002/diff/160001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/919653002/diff/160001/src/objects.cc#newcode10334
src/objects.cc:10334: String* debug_name = NULL;
You should avoid raw pointers in methods that may cause GC. In
On 2015/03/13 13:45:29, yurys wrote:
On 2015/03/13 11:41:37, Yang wrote:
On 2015/03/13 11:35:29, I haz the power (commit-bot) wrote:
Try jobs failed on following builders:
v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders
On 2015/03/13 11:41:37, Yang wrote:
On 2015/03/13 11:35:29, I haz the power (commit-bot) wrote:
Try jobs failed on following builders:
v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/2403)
I think you
Reviewers: alph, loislo, Yang,
Description:
Remove obsolete TakeHeapSnapshot method from API
BUG=chromium:465651
LOG=Y
Please review this at https://codereview.chromium.org/997583004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -16 lines):
M
Reviewers: alph, dgozman, yangguo,
Description:
Remove uid and title from HeapSnapshot
None of these fields is used in Blink. Embedder always can implement them
using
existing API.
BUG=chromium:465651
Please review this at https://codereview.chromium.org/983833006/
Base URL:
wrote:
On 2015/03/10 10:23:57, yurys wrote:
On 2015/03/10 10:23:26, alph wrote:
V8_DEPRECATED
I will need to fix Blink side first.
Please add a TODO.
Done.
https://codereview.chromium.org/983833006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Yang or Sven, please take a look.
https://codereview.chromium.org/992193002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Yang or Sven, please take a look.
https://codereview.chromium.org/983833006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
lgtm
https://codereview.chromium.org/919653002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: loislo, Yang,
Description:
Remove deprecated CpuProfiler methods
BUG=None
LOG=Y
Please review this at https://codereview.chromium.org/992193002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -30 lines):
M include/v8-profiler.h
M src/api.cc
https://codereview.chromium.org/983833006/diff/20001/include/v8-profiler.h
File include/v8-profiler.h (right):
https://codereview.chromium.org/983833006/diff/20001/include/v8-profiler.h#newcode453
include/v8-profiler.h:453: const HeapSnapshot* TakeHeapSnapshot(
On 2015/03/10 10:23:26, alph
Can you provide more details on which tests are flaky for the purpose of
documentation so that we don't need to search them next time?
https://codereview.chromium.org/987553005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
https://codereview.chromium.org/919653002/diff/60001/src/messages.js
File src/messages.js (right):
https://codereview.chromium.org/919653002/diff/60001/src/messages.js#newcode837
src/messages.js:837: if (IS_STRING(name)) {
Is it supposed to return in case of empty string?
https://codereview.chromium.org/917743002/diff/20001/src/isolate.cc
File src/isolate.cc (right):
https://codereview.chromium.org/917743002/diff/20001/src/isolate.cc#newcode557
src/isolate.cc:557: if (fun_name.is_null() || !fun_name-IsString())
Can it ever be null?
lgtm,
but would it be possible to first enable these tests?
https://codereview.chromium.org/978203002/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/978203002/diff/1/test/cctest/test-cpu-profiler.cc#newcode59
Reviewers: kozyatinskiy, yangguo, pfeldman,
Message:
Yang, please take a look.
Description:
Allow passing sourceMapUrl when compiling scripts
According to Source Map specification [1] source map url can be passed
either as
a magic comment at the end of script or as SourceMap http header. We
lgtm provided the list of flaky tests is complete.
https://codereview.chromium.org/976203003/diff/20001/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/976203003/diff/20001/test/cctest/test-cpu-profiler.cc#newcode1141
lgtm
https://codereview.chromium.org/917743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/959203002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
looks good, but someone more familiar with the code should review this.
https://codereview.chromium.org/962593005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
https://codereview.chromium.org/959203002/diff/20001/src/assembler.cc
File src/assembler.cc (right):
https://codereview.chromium.org/959203002/diff/20001/src/assembler.cc#newcode1663
src/assembler.cc:1663: int raw_position = position.IsUnknown() ? 0 :
position.raw();
Can we change
https://codereview.chromium.org/941973002/diff/20001/src/cpu-profiler.h
File src/cpu-profiler.h (right):
https://codereview.chromium.org/941973002/diff/20001/src/cpu-profiler.h#newcode243
src/cpu-profiler.h:243: virtual void SharedFunctionInfoMoveEvent(Address
from, Address to) {}
Can we remove
https://codereview.chromium.org/941973002/diff/11/src/profile-generator.cc
File src/profile-generator.cc (right):
https://codereview.chromium.org/941973002/diff/11/src/profile-generator.cc#newcode351
src/profile-generator.cc:351: function_ids_.Lookup(code_entry,
code_entry-GetHash(),
Also please update issue's description as its main purpose is to make
CallUid
actually unique and eliminate SharedFunctionInfo motion events.
https://codereview.chromium.org/941973002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received
lgtm,
I believe we don't need StringStorage for CPU profiler and could eliminate
its
usages there.
https://codereview.chromium.org/945873002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to
lgtm
https://codereview.chromium.org/940593002/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/940593002/diff/1/test/cctest/test-cpu-profiler.cc#newcode1789
test/cctest/test-cpu-profiler.cc:1789: v8::Localv8::Context env
Reviewers: Dmitry Lomov (chromium), fqian,
Message:
@fqian: my understanding is that this change shouldn't regress Blink
implementation of V8Window::toStringMethodCustom [1]. Please confirm that
as you
are the author of the FIXME comment for that code.
[1]
lgtm
https://codereview.chromium.org/922153002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/919953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/919653002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/910773002/diff/120001/src/arm64/deoptimizer-arm64.cc
File src/arm64/deoptimizer-arm64.cc (right):
https://codereview.chromium.org/910773002/diff/120001/src/arm64/deoptimizer-arm64.cc#newcode135
src/arm64/deoptimizer-arm64.cc:135: __ Mov(x3,
On 2015/02/04 19:15:42, dcarney wrote:
On 2015/02/04 15:16:54, yurys wrote:
The error looks weird to me. C4251 warning disabled in several build
configurations [1], should we do the same for v8? Otherwise I would
have to
somehow instantiate v8::UniquePersistentv8::Object in v8.h and mark
Reviewers: jochen (slow), Michael Starzinger, rossberg, dcarney,
Message:
This patch is a reworked version of r26425. It was modified in accord with
dcarney's comments. Instead of embedding UniquePersistent field
NativeWeakMap
has been turned into a heap object. This should vanish MSVS
Reviewers: jochen (slow), Michael Starzinger, rossberg,
Message:
This patch is slightly modified version of
https://crrev.com/37d4c57630636f21e3add8d3d1c7c978ff5fc8e0 which was
reverted
due to component build failure.
The differences are:
1) WeakMap has been renamed to WeakKeyMap to avoid
1 - 100 of 1157 matches
Mail list logo
