[v8-dev] Fix build.

Reviewers: Kasper Lund, Description: Fix build. Please review this at http://codereview.chromium.org/8144 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/objects-debug.cc Index: src/objects-debug.cc =

[v8-dev] Fix build

Reviewers: Kevin Millikin, Description: Fix build tbr=kmilli...@chromium.org Please review this at http://codereview.chromium.org/52013 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/virtual-frame.h Index: src/virtual-frame.h =

[v8-dev] Fix build. (issue1334001)

Reviewers: William Hesse, Description: Fix build. Some old names reappeared due to some merge problem. tbr=whe...@chromium.org, Committed: http://code.google.com/p/v8/source/detail?r=4271 Please review this at http://codereview.chromium.org/1334001 SVN Base: http://v8.googlecode.com/svn/bran

[v8-dev] Fix build. (issue6688032)

Reviewers: Vitaly Repeshko, Message: I'll investigate why it hadn't been caught by the tests. Description: Fix build. TBR=vita...@chromium.org Please review this at http://codereview.chromium.org/6688032/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src

[v8-dev] Fix build problems. (issue543087)

Reviewers: =erik.corry_gmail.com, Description: Fix build problems. Please review this at http://codereview.chromium.org/543087 Affected files: M test/cctest/test-serialize.cc M test/mjsunit/regress/regress-crbug-3184.js -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.

[v8-dev] Fix build. (issue 10829075)

Reviewers: Jakob, Description: Fix build. R=jkumme...@chromium.org BUG= TEST= Please review this at https://chromiumcodereview.appspot.com/10829075/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/conversions.h Index: src/conversions.h diff --git a/s

[v8-dev] Fix build. (issue 7977020)

Reviewers: , Description: Fix build. Last minute cleanup lost a '*'. TBR=ri...@chromium.org BUG= TEST= Please review this at http://codereview.chromium.org/7977020/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/runtime.cc Index: src/runtime.cc diff

[v8-dev] Fix build (issue 15881004)

Reviewers: Jakob, Message: PTAL Description: Fix build Please review this at https://chromiumcodereview.appspot.com/15881004/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/code-stubs-hydrogen.cc M src/hydrogen.h M src/hydrogen.cc Index: src/code-

[v8-dev] Fix build problem in Win.

Reviewers: Christian Plesner Hansen, Message: Bugfix review Description: Builds on Windows too. Please review this at http://codereview.chromium.org/12864 Affected files: M src/runtime.cc Index: src/runtime.cc diff --git a/src/runtime.cc b/src/runtime.cc index 5512f8323a99e42769fff93167

[v8-dev] Fix build problem on ARM.

Reviewers: Erik Corry, Message: Quick review. Description: Move reference to variable that isn't used on ARM. Please review this at http://codereview.chromium.org/53048 Affected files: M src/jsregexp.cc Index: src/jsregexp.cc diff --git a/src/jsregexp.cc b/src/jsregexp.cc index 7e40d7b0

[v8-dev] Fix build errors. (issue 10832061)

Reviewers: Michael Starzinger, Description: Fix build errors. R=mstarzin...@chromium.org BUG= TEST= Please review this at https://chromiumcodereview.appspot.com/10832061/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M test/cctest/test-utils.cc Index: te

[v8-dev] Fix build on FreeBSD. (issue6960003)

LGTM. Thanks for fixing this! I'll land. -- Vitaly http://codereview.chromium.org/6960003/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Fix build on x64 (issue7284011)

Reviewers: Søren Gjesse, Message: PTAL. Description: Fix build on x64 Please review this at http://codereview.chromium.org/7284011/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M test/cctest/test-compiler.cc Index: test/cctest/test-compiler.cc diff --git

[v8-dev] Fix build error. (issue 8117002)

Reviewers: Rico, Description: Fix build error. Please review this at http://codereview.chromium.org/8117002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/regexp-macro-assembler-tracer.cc Index: src/regexp-macro-assembler-tracer.cc diff --git a/src/r

[v8-dev] Fix build errors. (issue 11364231)

Reviewers: Jakob, Description: Fix build errors. R=jkumme...@chromium.org BUG= Please review this at https://chromiumcodereview.appspot.com/11364231/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M test/cctest/test-parsing.cc Index: test/cctest/test-pars

[v8-dev] Fix build warnings. (issue 11669020)

Reviewers: dcarney_chromium.org, Description: Fix build warnings. TBR=dcar...@chromium.org BUG= Please review this at https://chromiumcodereview.appspot.com/11669020/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/objects.cc M src/string-stream.cc

[v8-dev] Fix build on arm and x64.

Reviewers: Kevin Millikin, Description: Fix build on arm and x64. Note to self: remember all platforms. Please review this at http://codereview.chromium.org/115399 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/arm/register-allocator-arm.cc M

[v8-dev] Fix build after r16890. (issue 23969011)

Reviewers: machenbach, Message: Committed patchset #1 manually as r16895 (presubmit successful). Description: Fix build after r16890. TBR=machenb...@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16895 Please review this at https://codereview.chromium.org/23969011/ SVN

[v8-dev] Fix build again after renaming. (issue1335001)

Reviewers: William Hesse, Description: Fix build again after renaming. tbr=whe...@chromium.org, Committed: http://code.google.com/p/v8/source/detail?r=4275 Please review this at http://codereview.chromium.org/1335001 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected fil

[v8-dev] Fix build break on Mac. (issue6816012)

Reviewers: Søren Gjesse, Mads Ager, Message: For some reason Mac GCC is confused about the ASSERT_EQ. Per chat with Mads switching to ASSERT. Thanks! Martin Description: Fix build break on Mac. BUG= TEST= Please review this at http://codereview.chromium.org/6816012/ SVN Base: https://v8.go

Re: [v8-dev] Fix build on x64 (issue7284011)

Or even simpler: Use the %p conversion specifier, without any need for ugly casting... On Wed, Jun 29, 2011 at 16:27, wrote: > Reviewers: Søren Gjesse, > > Message: > PTAL. > > Description: > Fix build on x64 > > > Please review this at > http://codereview.chromium.**org/7284011/

[v8-dev] Fix build problem on arm compiler. (issue975005)

Reviewers: plesner, Message: Tiny review. Description: Fix build problem on arm compiler. Please review this at http://codereview.chromium.org/975005 Affected files: M src/runtime.cc Index: src/runtime.cc diff --git a/src/runtime.cc b/src/runtime.cc index fdea88ae2425cc6f42f03b8acd40a13e

[v8-dev] Fix build with disassembler=on (issue 10834063)

Reviewers: Jakob, Message: PTAL Description: R=jkumme...@chromium.org Fixed build with disassembler=on Please review this at http://codereview.chromium.org/10834063/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M build/common.gypi Index: build/common

[v8-dev] * Fix build errors on FreeBSD 8.2... (issue6673045)

Reviewers: Lasse Reichstein, Description: * Fix build errors on FreeBSD 8.2 * Fix Crankshaft on FreeBSD. * Partially fix profiling on FreeBSD. * Remove bash-isms from tick processor script. Please review this at http://codereview.chromium.org/6673045/ SVN Base: http://v8.googlecode.com/svn/bran

[v8-dev] Fix build borkage due to r7575 (issue6823065)

Reviewers: Vitaly Repeshko, Message: TBR=vitalyr Original patch: http://codereview.chromium.org/6822042/ Description: Fix build borkage due to r7575 (landing for Dmitry Lomov) Please review this at http://codereview.chromium.org/6823065/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding

[v8-dev] Fix build with debuggersupport=off. (issue 8073020)

Reviewers: Jakob, Message: Please take a look. Description: Fix build with debuggersupport=off. BUG=v8:899 Please review this at http://codereview.chromium.org/8073020/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/d8-debug.cc M src/d8.cc M src/f

[v8-dev] Fix build breakage after 15630 (issue 18812005)

Reviewers: Benedikt Meurer, Description: Fix build breakage after 15630 Use EXTRA_CALL_FRAME rather than NO_EXTRA_FRAME in ElementsTransitionAndStoreIC_Miss. TBR=bmeu...@chromium.org Please review this at https://codereview.chromium.org/18812005/ SVN Base: https://v8.googlecode.com/svn/branch

[v8-dev] Fix build on OpenBSD/i386. (issue 10919314)

Reviewers: , Message: LGTM. Description: Fix build on OpenBSD/i386. BUG=v8:1445 Please review this at http://codereview.chromium.org/10919314/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/atomicops.h M src/platform.h Index: src/atomicops.h diff

[v8-dev] Fix build on x64 after compare stub change.

Reviewers: William Hesse, Description: Fix build on x64 after compare stub change. Please review this at http://codereview.chromium.org/150022 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/x64/codegen-x64.cc Index: src/x64/codegen-x64.cc

[v8-dev] Fix build failure introduced by r10380 (issue 9190002)

Reviewers: Michael Starzinger, Description: Fix build failure introduced by r10380 TBR=mstarzin...@chromium.org Please review this at http://codereview.chromium.org/9190002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M test/cctest/test-heap.cc Index: t

[v8-dev] Fix build failure on Windows since r14116. (issue 13464010)

Reviewers: Yang, Description: Fix build failure on Windows since r14116. TBR=yang...@chromium.org Please review this at https://codereview.chromium.org/13464010/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/ast.h M src/d8.h M src/d8.cc Index: s

[v8-dev] Fix build failures on Win64 since r14215. (issue 14075006)

Reviewers: Sven Panne, Description: Fix build failures on Win64 since r14215. R=svenpa...@chromium.org Please review this at https://codereview.chromium.org/14075006/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/global-handles.cc M src/heap-snapsho

[v8-dev] Fix build failures on Win64 since r14354. (issue 14246034)

Reviewers: ulan_chromium.prg, wingo, Description: Fix build failures on Win64 since r14354. R=u...@chromium.prg Please review this at https://codereview.chromium.org/14246034/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/runtime.cc Index: src/runtim

[v8-dev] Fix build failure on Win64 since r14458. (issue 14143008)

Reviewers: Jakob, Description: Fix build failure on Win64 since r14458. R=jkumme...@chromium.org Please review this at https://codereview.chromium.org/14143008/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/frames-inl.h Index: src/frames-inl.h diff -

[v8-dev] Fix build failure on Win64 since r14458. (issue 14150019)

Reviewers: Dmitry Lomov (chromium), Description: Fix build failure on Win64 since r14458. R=dslo...@chromium.org Please review this at https://codereview.chromium.org/14150019/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/runtime.cc Index: src/runti

[v8-dev] Fix build failure on Linux since r14681. (issue 14969025)

Reviewers: danno, Description: Fix build failure on Linux since r14681. R=da...@chromium.org Please review this at https://codereview.chromium.org/14969025/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M test/cctest/test-conversions.cc Index: test/cctest/

[v8-dev] Fix build error on Win32, fix spelling of DebugerStatementStub. (issue570001)

Reviewers: Søren Gjesse, Description: Fix build error on Win32, fix spelling of DebugerStatementStub. Please review this at http://codereview.chromium.org/570001 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/arm/codegen-arm.cc M src/codegen.h

[v8-dev] Fix build problems on Windows 64-bit by casting. (issue1539033)

Reviewers: Søren Gjesse, Message: Lots of simple casts and uses of StrLength. Description: Fix build problems on Windows 64-bit by casting. Please review this at http://codereview.chromium.org/1539033/show Affected files: M src/circular-queue-inl.h M src/circular-queue.cc M src/heap.cc

[v8-dev] Fix build for disassembler=on and objectprint=off. (issue 10830088)

Reviewers: Jakob, Description: Fix build for disassembler=on and objectprint=off. R=jkumme...@chromium.org Please review this at https://chromiumcodereview.appspot.com/10830088/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/objects.cc Index: src/obj

[v8-dev] Fix build for ARM in release mode after r10531. (issue 9225022)

lgtm https://chromiumcodereview.appspot.com/9225022/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Fix build and test failures from packed array optimizations. (issue 10332317)

Reviewers: Jakob, Message: PTAL Description: Fix build and test failures from packed array optimizations. R=jkumme...@chromium.org Please review this at http://codereview.chromium.org/10332317/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/x64/macro-

[v8-dev] Fix build by fixing a typo in codegen-x64.cc. (issue2824002)

Reviewers: William Hesse, Description: Fix build by fixing a typo in codegen-x64.cc. tbr=whe...@chromium.org Please review this at http://codereview.chromium.org/2824002/show SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/x64/codegen-x64.cc Index:

[v8-dev] Fix build-breakage on Mac. Initial variable in unreachable branch. (issue3471001)

LGTM. http://codereview.chromium.org/3471001/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Fix build (and fix brown paper bug as well...). (issue 11419115)

Reviewers: Jakob, Description: Fix build (and fix brown paper bug as well...). BUG= Please review this at https://chromiumcodereview.appspot.com/11419115/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/hydrogen.cc Index: src/hydrogen.cc diff --git a/

[v8-dev] Fix build bot. Force instantiation of templatized SweepConservatively method. (issue 12079075)

Reviewers: Michael Starzinger, Description: Fix build bot. Force instantiation of templatized SweepConservatively method. BUG= Please review this at https://chromiumcodereview.appspot.com/12079075/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/mar

[v8-dev] Fix build error in debug mode by making sure the tracer has the...

Reviewers: Mads Ager, Description: Fix build error in debug mode by making sure the tracer has the new method too. Fix spacing in tracer. Please review this at http://codereview.chromium.org/12806 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/regex

[v8-dev] Fix build (someone tell gcc you can't take the address of a static...

Reviewers: Christian Plesner Hansen, Description: Fix build (someone tell gcc you can't take the address of a static const int and someone tell MSVC it's OK to define a static const int in a .cc file). Please review this at http://codereview.chromium.org/13656 SVN Base: http://v8.googlecode.com

[v8-dev] - Fix build break due to warning about control reaching end of non-void...

Reviewers: Mikhail Naganov, Message: TBR=mikhail.naganov Description: - Fix build break due to warning about control reaching end of non-void function. Please review this at http://codereview.chromium.org/115245 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected fil

[v8-dev] Fix build with GCC 4.7, which fails with "narrowing conversion of (issue 8724003)

Reviewers: Steven, Message: The patch unbreaks compilation of src/full-codegen.cc with GCC 4.7. The build fails due to -Werror=narrowing stating: Error: narrowing conversion of »id« from »int« to »unsigned int« inside { } is ill-formed in C++11 The solution is to change "int" to "unsigned"

[v8-dev] - Fix build break on Mac OS X by using the proper formatting for pointers....

Reviewers: Dean McNamee, Description: - Fix build break on Mac OS X by using the proper formatting for pointers. Verified that this works on both ia32 and x64 on Linux and Mac OS X. Please review this at http://codereview.chromium.org/115252 SVN Base: http://v8.googlecode.com/svn/branches/b