https://codereview.chromium.org/1307223002/diff/1/src/ast.cc
File src/ast.cc (right):
https://codereview.chromium.org/1307223002/diff/1/src/ast.cc#newcode437
src/ast.cc:437: bool is_simple = boilerplate_properties_ != 0 ||
properties()-length() == 0;
On 2015/08/24 16:04:40, wingo wrote:
I am
lgtm
https://codereview.chromium.org/1307223002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1307223002/diff/1/src/ast.cc
File src/ast.cc (right):
https://codereview.chromium.org/1307223002/diff/1/src/ast.cc#newcode437
src/ast.cc:437: bool is_simple = boilerplate_properties_ != 0 ||
properties()-length() == 0;
I am missing a bit of context. Is
https://codereview.chromium.org/1307223002/diff/40001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/1307223002/diff/40001/src/ast.h#newcode1493
src/ast.h:1493: return boilerplate_properties_ == 0
properties_-length() 0;
I don't think the LHS of this expression is correct:
On 2015/08/24 18:14:29, adamk wrote:
https://codereview.chromium.org/1307223002/diff/40001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/1307223002/diff/40001/src/ast.h#newcode1493
src/ast.h:1493: return boilerplate_properties_ == 0
properties_-length()
0;
On
https://codereview.chromium.org/1307223002/diff/40001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/1307223002/diff/40001/src/ast.h#newcode1493
src/ast.h:1493: return boilerplate_properties_ == 0
properties_-length() 0;
On 2015/08/24 18:00:53, adamk wrote:
I don't think
https://codereview.chromium.org/1307223002/diff/40001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/1307223002/diff/40001/src/ast.h#newcode1493
src/ast.h:1493: return boilerplate_properties_ == 0
properties_-length() 0;
On 2015/08/24 18:14:29, adamk wrote:
On 2015/08/24
On 2015/08/24 18:17:17, caitp wrote:
On 2015/08/24 18:14:29, adamk wrote:
https://codereview.chromium.org/1307223002/diff/40001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/1307223002/diff/40001/src/ast.h#newcode1493
src/ast.h:1493: return boilerplate_properties_ == 0
On 2015/08/24 18:29:50, caitp wrote:
On 2015/08/24 18:17:17, caitp wrote:
On 2015/08/24 18:14:29, adamk wrote:
https://codereview.chromium.org/1307223002/diff/40001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/1307223002/diff/40001/src/ast.h#newcode1493
