On 2015/09/16 15:25:35, adamk wrote:
lgtm
Sorry for the delay, I was expecting a ping from your end when you
uploaded a
new patch.
My bad, maybe I'm too used to Bugzilla reporting uploaded attachments by
email
automatically, by default.
https://codereview.chromium.org/1328083002/
--
On 2015/09/08 23:35:13, caitp wrote:
Sounds good to me. I'll have a patchset later tonight
https://codereview.chromium.org/1328083002/diff/40001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1328083002/diff/40001/src/preparser.h#newcode2663
lgtm
Sorry for the delay, I was expecting a ping from your end when you uploaded
a
new patch.
https://codereview.chromium.org/1328083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1328083002/160001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1328083002/160001
https://codereview.chromium.org/1328083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Committed patchset #8 (id:160001)
https://codereview.chromium.org/1328083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group
Patchset 8 (id:??) landed as
https://crrev.com/b444da41ad9ef32cea08fd24fd89eab258cd1360
Cr-Commit-Position: refs/heads/master@{#30769}
https://codereview.chromium.org/1328083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
I agree that some refactoring here would be helpful for readability, but
I'm not
sure the switch statement you landed on was it. So I'd suggest going with a
minimal fix and dealing with the refactoring separately.
https://codereview.chromium.org/1328083002/diff/40001/src/preparser.h
File
Sounds good to me. I'll have a patchset later tonight
https://codereview.chromium.org/1328083002/diff/40001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1328083002/diff/40001/src/preparser.h#newcode2663
src/preparser.h:2663: goto shorthand_property;
On
https://codereview.chromium.org/1328083002/diff/80001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1328083002/diff/80001/src/preparser.h#newcode2614
src/preparser.h:2614: if (!in_class && !is_generator) {
I reorganized ParsePropertyDefinition because it was
