[v8-dev] Re: [perf] narrow improvements to ObjectToString (issue 1063703005 by caitpotte...@gmail.com)

2015-04-15 Thread caitpotter88
On 2015/04/14 14:53:44, caitp wrote: I made a little benchmark, the results aren't super-promising: ``` === With @@toStringTag in prototype === Runs: 10 Total: 655.399000385ms Average: 0.00655399000385ms === No @@toStringTag === Runs: 10 T

[v8-dev] Re: [perf] narrow improvements to ObjectToString (issue 1063703005 by caitpotte...@gmail.com)

2015-04-14 Thread caitpotter88
I made a little benchmark, the results aren't super-promising: ``` === With @@toStringTag in prototype === Runs: 10 Total: 655.399000385ms Average: 0.00655399000385ms === No @@toStringTag === Runs: 10 Total: 180.2279993367ms Average: 0.00180

[v8-dev] Re: [perf] narrow improvements to ObjectToString (issue 1063703005 by caitpotte...@gmail.com)

2015-04-14 Thread caitpotter88
On 2015/04/14 13:31:17, Sven Panne wrote: DBC https://codereview.chromium.org/1063703005/diff/1/src/v8natives.js File src/v8natives.js (right): https://codereview.chromium.org/1063703005/diff/1/src/v8natives.js#newcode234 src/v8natives.js:234: if (%_Likely(harmony_tostring)) { Just a small

[v8-dev] Re: [perf] narrow improvements to ObjectToString (issue 1063703005 by caitpotte...@gmail.com)

2015-04-14 Thread svenpanne
DBC https://codereview.chromium.org/1063703005/diff/1/src/v8natives.js File src/v8natives.js (right): https://codereview.chromium.org/1063703005/diff/1/src/v8natives.js#newcode234 src/v8natives.js:234: if (%_Likely(harmony_tostring)) { Just a small warning about %_Likely/%_Unlikely support: