[v8-dev] Re: ARM64: Clean up support for explicit literal load. (issue 318773009)

2014-06-09 Thread rodolph . perfetta
https://codereview.chromium.org/318773009/diff/1/src/arm64/assembler-arm64.cc File src/arm64/assembler-arm64.cc (right): https://codereview.chromium.org/318773009/diff/1/src/arm64/assembler-arm64.cc#newcode1482 src/arm64/assembler-arm64.cc:1482: Emit(LoadLiteralOpFor(rt) | ImmLLiteral(imm19) |

[v8-dev] Re: ARM64: Clean up support for explicit literal load. (issue 318773009)

2014-06-09 Thread rmcilroy
lgtm https://codereview.chromium.org/318773009/diff/1/src/arm64/assembler-arm64.cc File src/arm64/assembler-arm64.cc (right): https://codereview.chromium.org/318773009/diff/1/src/arm64/assembler-arm64.cc#newcode1482 src/arm64/assembler-arm64.cc:1482: Emit(LoadLiteralOpFor(rt) |

[v8-dev] Re: ARM64: Clean up support for explicit literal load. (issue 318773009)

2014-06-09 Thread rodolph . perfetta
Committed patchset #1 manually as r21723 (presubmit successful). https://codereview.chromium.org/318773009/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: ARM64: Clean up support for explicit literal load. (issue 318773009)

2014-06-06 Thread rmcilroy
Lgtm with a couple of suggestions. Thanks. https://codereview.chromium.org/318773009/diff/1/src/arm64/assembler-arm64.cc File src/arm64/assembler-arm64.cc (right): https://codereview.chromium.org/318773009/diff/1/src/arm64/assembler-arm64.cc#newcode1482 src/arm64/assembler-arm64.cc:1482:

[v8-dev] Re: ARM64: Clean up support for explicit literal load. (issue 318773009)

2014-06-05 Thread ulan
Ross, could you please take over this? I'll be out of office until Tuesday. https://codereview.chromium.org/318773009/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev