Committed patchset #7 (id:130001)
https://codereview.chromium.org/1322773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group
Patchset 7 (id:??) landed as
https://crrev.com/546d9a70ace27ccecbf4adaad44bdeee6de135b7
Cr-Commit-Position: refs/heads/master@{#30520}
https://codereview.chromium.org/1322773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
https://codereview.chromium.org/1322773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1322773002/130001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1322773002/130001
https://codereview.chromium.org/1322773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Will do a similar switch on the other AstVisitors in another CL.
https://codereview.chromium.org/1322773002/diff/110001/src/typing-asm.cc
File src/typing-asm.cc (right):
https://codereview.chromium.org/1322773002/diff/110001/src/typing-asm.cc#newcode44
src/typing-asm.cc:44:
lgtm with comment
https://codereview.chromium.org/1322773002/diff/110001/src/typing-asm.cc
File src/typing-asm.cc (right):
https://codereview.chromium.org/1322773002/diff/110001/src/typing-asm.cc#newcode44
src/typing-asm.cc:44: AsmTyper::AsmTyper(CompilationInfo* info)
Can we make this take a
PTAL
https://codereview.chromium.org/1322773002/diff/40001/src/typing-asm.cc
File src/typing-asm.cc (right):
https://codereview.chromium.org/1322773002/diff/40001/src/typing-asm.cc#newcode59
src/typing-asm.cc:59: #define RECURSE_EXPR(expr, expected_type, msg)
\
On 2015/08/31
https://codereview.chromium.org/1322773002/diff/60001/src/typing-asm.cc
File src/typing-asm.cc (right):
https://codereview.chromium.org/1322773002/diff/60001/src/typing-asm.cc#newcode343
src/typing-asm.cc:343: RECURSE(VisitWithExpectation(stmt->cond(),
cache_.kInt32,
Is this also true? I
PTAL
https://codereview.chromium.org/1322773002/diff/60001/src/typing-asm.cc
File src/typing-asm.cc (right):
https://codereview.chromium.org/1322773002/diff/60001/src/typing-asm.cc#newcode343
src/typing-asm.cc:343: RECURSE(VisitWithExpectation(stmt->cond(),
cache_.kInt32,
On 2015/08/31
https://codereview.chromium.org/1322773002/diff/40001/src/typing-asm.cc
File src/typing-asm.cc (right):
https://codereview.chromium.org/1322773002/diff/40001/src/typing-asm.cc#newcode59
src/typing-asm.cc:59: #define RECURSE_EXPR(expr, expected_type, msg)
\
Can these four macros be
10 matches
Mail list logo
