Committed patchset #8 manually as r20162 (presubmit successful).
https://codereview.chromium.org/203463011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
https://codereview.chromium.org/203463011/diff/110001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/203463011/diff/110001/src/runtime.cc#newcode11875
src/runtime.cc:11875: if (scope_info->scope_type() != EVAL_SCOPE &&
Considering the comment above: "we only provide
PTAL.
Changed runtime.cc to not to add nested scope_info for GLOBAL_SCOPE (along
with
EVAL_SCOPE), otherwise a debug test was failing.
if (scope_info->scope_type() != EVAL_SCOPE &&
scope_info->scope_type() != GLOBAL_SCOPE) {
nested_scope_chain_.Add(scope_info);
}
https://codereview.chr
lgtm
https://codereview.chromium.org/203463011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/203463011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
PTAL
https://codereview.chromium.org/203463011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
On 2014/03/20 13:43:32, ulan wrote:
On 2014/03/20 13:22:17, aandrey wrote:
> On 2014/03/20 13:13:08, ulan wrote:
> > Thanks for fixing. Something seems to be wrong with the Patch Set 4:
it
> changes
> > unrelated lines. Did you accidentally upload with incorrect base?
>
> Seems OK to me:
>
h
On 2014/03/20 13:22:17, aandrey wrote:
On 2014/03/20 13:13:08, ulan wrote:
> Thanks for fixing. Something seems to be wrong with the Patch Set 4: it
changes
> unrelated lines. Did you accidentally upload with incorrect base?
Seems OK to me:
https://codereview.chromium.org/203463011/diff2/40001
On 2014/03/20 13:13:08, ulan wrote:
Thanks for fixing. Something seems to be wrong with the Patch Set 4: it
changes
unrelated lines. Did you accidentally upload with incorrect base?
Seems OK to me:
https://codereview.chromium.org/203463011/diff2/40001:60001/src/runtime.cc
https://codereview.
Thanks for fixing. Something seems to be wrong with the Patch Set 4: it
changes
unrelated lines. Did you accidentally upload with incorrect base?
https://codereview.chromium.org/203463011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You receive
https://codereview.chromium.org/203463011/diff/40001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/203463011/diff/40001/src/runtime.cc#newcode11737
src/runtime.cc:11737: bool fast = false)
On 2014/03/20 12:11:49, ulan wrote:
fast => ignore_nested_scopes
Done.
ht
One more place remaining:
https://codereview.chromium.org/203463011/diff/40001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/203463011/diff/40001/src/runtime.cc#newcode11737
src/runtime.cc:11737: bool fast = false)
fast => ignore_nested_scopes
https://codereview.c
https://codereview.chromium.org/203463011/diff/20001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/203463011/diff/20001/src/runtime.cc#newcode12263
src/runtime.cc:12263: // args[3]: boolean: fast bit
On 2014/03/20 08:15:29, ulan wrote:
Could you give it a more desc
Looks good, one comment:
https://codereview.chromium.org/203463011/diff/20001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/203463011/diff/20001/src/runtime.cc#newcode12263
src/runtime.cc:12263: // args[3]: boolean: fast bit
Could you give it a more descriptive nam
14 matches
Mail list logo
