[v8-dev] Re: Added support for running tests in parallel.

2008-09-30 Thread christian . plesner . hansen
http://codereview.chromium.org/6010/diff/1/2 File tools/test.py (right): http://codereview.chromium.org/6010/diff/1/2#newcode60 Line 60: self.queue.put_nowait(case) This call should always succeed, but in case it doesn't I prefer 'put_nowait' because it fails with an exception rather than 'put'

[v8-dev] Re: Added support for running tests in parallel.

2008-09-30 Thread deanm
Overall LGTM. http://codereview.chromium.org/6010/diff/1/2 File tools/test.py (right): http://codereview.chromium.org/6010/diff/1/2#newcode60 Line 60: self.queue.put_nowait(case) Do you really want put_nowait, and not just put() ? http://codereview.chromium.org/6010/diff/1/2#newcode79 Line 79: