[v8-dev] Re: Don't switch left/right operand when they are double value (issue 23717039)

2013-09-10 Thread weiliang . lin2
On 2013/09/09 19:08:22, Jakob wrote: This does not lgtm. It is very unintuitive why Double vs. Int32 representation would have anything to do with whether operands are better swapped or not. Probably this benchmark just happens to create a situation where our heuristic makes the wrong decisi

[v8-dev] Re: Don't switch left/right operand when they are double value (issue 23717039)

2013-09-09 Thread weiliang . lin2
On 2013/09/09 14:39:02, Benedikt Meurer wrote: What is the benefit? Avoid unnecessary register move. For example, it brings more than 40% improve for misc-basic-fpops.js on IA32 in awfy http://www.arewefastyet.com/#machine=11&view=breakdown&suite=misc https://codereview.chromium.org/2371703

[v8-dev] Re: Don't switch left/right operand when they are double value (issue 23717039)

2013-09-09 Thread jkummerow
This does not lgtm. It is very unintuitive why Double vs. Int32 representation would have anything to do with whether operands are better swapped or not. Probably this benchmark just happens to create a situation where our heuristic makes the wrong decision. Maybe Better{Left,Right}Operand()

[v8-dev] Re: Don't switch left/right operand when they are double value (issue 23717039)

2013-09-09 Thread Weiliang Lin
Avoid unnecessary register move. For example, it brings more than 40% improve for misc-basic-fpops.js on IA32 in awfy* *http://www.arewefastyet.com/#machine=11&view=breakdown&suite=misc On Mon, Sep 9, 2013 at 10:39 PM, wrote: > What is the benefit? > > https://codereview.chromium.**org/23717039

[v8-dev] Re: Don't switch left/right operand when they are double value (issue 23717039)

2013-09-09 Thread bmeurer
What is the benefit? https://codereview.chromium.org/23717039/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving