[v8-dev] Re: ES6: Add support for Map and Set Iterator (issue 259883002)

2014-06-02 Thread mstarzinger
LGTM from my end. Just a couple of remarks. https://codereview.chromium.org/259883002/diff/160001/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/259883002/diff/160001/src/bootstrapper.cc#newcode2020 src/bootstrapper.cc:2020: INSTALL_EXPERIMENTAL_NATIVE(i,

[v8-dev] Re: ES6: Add support for Map and Set Iterator (issue 259883002)

2014-06-02 Thread rossberg
https://codereview.chromium.org/259883002/diff/160001/test/mjsunit/harmony/collection-iterator.js File test/mjsunit/harmony/collection-iterator.js (right): https://codereview.chromium.org/259883002/diff/160001/test/mjsunit/harmony/collection-iterator.js#newcode20

Re: [v8-dev] Re: ES6: Add support for Map and Set Iterator (issue 259883002)

2014-06-02 Thread Erik Arvidsson
Thanks. Traveling and TC39 this week but I think I'll have time tomorrow to update this. Normally a typo like this would be caught by a unit test. In this case the unit test framework is deficient. I'll update it to add an arguments length check in another CL. On Jun 2, 2014 7:53 AM,

[v8-dev] Re: ES6: Add support for Map and Set Iterator (issue 259883002)

2014-06-02 Thread arv
All fixed https://codereview.chromium.org/259883002/diff/160001/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/259883002/diff/160001/src/bootstrapper.cc#newcode2020 src/bootstrapper.cc:2020: INSTALL_EXPERIMENTAL_NATIVE(i, collections,

[v8-dev] Re: ES6: Add support for Map and Set Iterator (issue 259883002)

2014-06-02 Thread adamk
Committed patchset #9 manually as r21615 (presubmit successful). https://codereview.chromium.org/259883002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: ES6: Add support for Map and Set Iterator (issue 259883002)

2014-05-29 Thread arv
PTAL https://codereview.chromium.org/259883002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it,

[v8-dev] Re: ES6: Add support for Map and Set Iterator (issue 259883002)

2014-05-28 Thread arv
This is now ready for review again. The big difference from before is that the Create* functions have been removed from C++ and the instance are created using `new MapIterator`. MapIterator is only available to builtins. PTAL https://codereview.chromium.org/259883002/ -- -- v8-dev

[v8-dev] Re: ES6: Add support for Map and Set Iterator (issue 259883002)

2014-05-28 Thread adamk
Mostly looks fine to me, happy to see some C++ code die. Only nits from me. https://codereview.chromium.org/259883002/diff/120001/src/collection-iterator.js File src/collection-iterator.js (right): https://codereview.chromium.org/259883002/diff/120001/src/collection-iterator.js#newcode1