[v8-dev] Re: Enable debug builds with some optimizations turned on. (issue 18516012)

2013-07-16 Thread thakis
fyi: https://codereview.chromium.org/18516012/diff/19001/build/toolchain.gypi File build/toolchain.gypi (right): https://codereview.chromium.org/18516012/diff/19001/build/toolchain.gypi#newcode513 build/toolchain.gypi:513: 'GCC_STRICT_ALIASING': 'YES', Note that strict aliasing is only done at

[v8-dev] Re: Enable debug builds with some optimizations turned on. (issue 18516012)

2013-07-10 Thread machenbach
Committed patchset #4 manually as r15599 (presubmit successful). https://codereview.chromium.org/18516012/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Enable debug builds with some optimizations turned on. (issue 18516012)

2013-07-10 Thread machenbach
On 2013/07/10 13:24:54, Jakob wrote: still LGTM https://codereview.chromium.org/18516012/diff/15001/build/toolchain.gypi File build/toolchain.gypi (right): https://codereview.chromium.org/18516012/diff/15001/build/toolchain.gypi#newcode526 build/toolchain.gypi:526: '-O0', I don't see why t

[v8-dev] Re: Enable debug builds with some optimizations turned on. (issue 18516012)

2013-07-10 Thread jkummerow
still LGTM https://codereview.chromium.org/18516012/diff/15001/build/toolchain.gypi File build/toolchain.gypi (right): https://codereview.chromium.org/18516012/diff/15001/build/toolchain.gypi#newcode526 build/toolchain.gypi:526: '-O0', I don't see why this change makes sense. https://coderevie

[v8-dev] Re: Enable debug builds with some optimizations turned on. (issue 18516012)

2013-07-10 Thread machenbach
On 2013/07/09 16:47:07, Jakob wrote: LGTM with comments. https://codereview.chromium.org/18516012/diff/4001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/18516012/diff/4001/build/common.gypi#newcode507 build/common.gypi:507: 'msvs_settings': { Keeping th

[v8-dev] Re: Enable debug builds with some optimizations turned on. (issue 18516012)

2013-07-09 Thread jkummerow
LGTM with comments. https://codereview.chromium.org/18516012/diff/4001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/18516012/diff/4001/build/common.gypi#newcode507 build/common.gypi:507: 'msvs_settings': { Keeping the msvs_settings section where it was saves

[v8-dev] Re: Enable debug builds with some optimizations turned on. (issue 18516012)

2013-07-09 Thread machenbach
On 2013/07/09 12:21:06, Jakob wrote: What about Windows and Mac? There you go. PTAL. https://codereview.chromium.org/18516012/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups

[v8-dev] Re: Enable debug builds with some optimizations turned on. (issue 18516012)

2013-07-09 Thread jkummerow
What about Windows and Mac? https://codereview.chromium.org/18516012/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop re