[v8-dev] Re: Extract common macros and start a base library (issue 249183003)

https://codereview.chromium.org/249183003/diff/1/src/base/macros.h File src/base/macros.h (right): https://codereview.chromium.org/249183003/diff/1/src/base/macros.h#newcode39 src/base/macros.h:39: // Here we simply use the non-zero value 4, which seems to work. On 2015/06/16 21:02:46, Nico wrot

[v8-dev] Re: Extract common macros and start a base library (issue 249183003)

https://codereview.chromium.org/249183003/diff/1/src/base/macros.h File src/base/macros.h (right): https://codereview.chromium.org/249183003/diff/1/src/base/macros.h#newcode39 src/base/macros.h:39: // Here we simply use the non-zero value 4, which seems to work. Is this really still needed? Othe

[v8-dev] Re: Extract common macros and start a base library (issue 249183003)

Committed patchset #1 manually as r20905 (presubmit successful). https://codereview.chromium.org/249183003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] Re: Extract common macros and start a base library (issue 249183003)

https://codereview.chromium.org/249183003/diff/1/src/base/macros.h File src/base/macros.h (right): https://codereview.chromium.org/249183003/diff/1/src/base/macros.h#newcode31 src/base/macros.h:31: #include "../../include/v8stdint.h" On 2014/04/23 11:38:35, Sven Panne wrote: Just a note: I thin

[v8-dev] Re: Extract common macros and start a base library (issue 249183003)

LGTM with a nit https://codereview.chromium.org/249183003/diff/1/src/base/macros.h File src/base/macros.h (right): https://codereview.chromium.org/249183003/diff/1/src/base/macros.h#newcode31 src/base/macros.h:31: #include "../../include/v8stdint.h" Just a note: I think we have to reconsider ou