Committed patchset #4 manually as r18261.
https://codereview.chromium.org/99013003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
LGTM
Life in V8 is full of tradeoffs.
https://codereview.chromium.org/99013003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group a
On 2013/12/04 17:49:16, titzer wrote:
https://codereview.chromium.org/99013003/diff/40001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/99013003/diff/40001/src/runtime.cc#newcode8670
src/runtime.cc:8670: if (!unoptimized->contains(frame->pc())) {
I am not sure thi
https://codereview.chromium.org/99013003/diff/40001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/99013003/diff/40001/src/runtime.cc#newcode8670
src/runtime.cc:8670: if (!unoptimized->contains(frame->pc())) {
I am not sure this is an improvement to no longer take th
On 2013/12/03 15:42:43, titzer wrote:
https://codereview.chromium.org/99013003/diff/20001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/99013003/diff/20001/src/runtime.cc#newcode8671
src/runtime.cc:8671: if
(static_cast(unoptimized->instruction_size())
<= pc_off
https://codereview.chromium.org/99013003/diff/20001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/99013003/diff/20001/src/runtime.cc#newcode8671
src/runtime.cc:8671: if
(static_cast(unoptimized->instruction_size()) <= pc_offset) {
I don't see how this check is stric
