On Tue, Jun 3, 2014 at 3:30 PM, Yang Guo wrote:
> The thing is, if the debugger is not active, entering the debugger loads a
> new debug context every time.
>
We assume that the same debug context is reused as long as we have debug
event listener set in v8 and this matches with what I see in debu
The thing is, if the debugger is not active, entering the debugger loads a
new debug context every time. You would have to re-disable the mirror cache
every time. Is that what you want?
Yang
On Tue, Jun 3, 2014 at 1:22 PM, Yury Semikhatsky wrote:
>
>
>
> On Tue, Jun 3, 2014 at 1:37 PM, Yang Gu
On Tue, Jun 3, 2014 at 1:37 PM, Yang Guo wrote:
> So, could we simply skip the cache if the debugger is not entered? I would
> then set a flag on the global object of the debug context after entering
> the debugger, which guards caching. Leaving the debugger would clear the
> cache and clear the
So, could we simply skip the cache if the debugger is not entered? I would
then set a flag on the global object of the debug context after entering
the debugger, which guards caching. Leaving the debugger would clear the
cache and clear the flag.
Since blink never enters the debugger, the mirror c
On 2014/06/03 08:12:46, Yang wrote:
https://codereview.chromium.org/296953005/diff/40001/src/debug-debugger.js
File src/debug-debugger.js (right):
https://codereview.chromium.org/296953005/diff/40001/src/debug-debugger.js#newcode491
src/debug-debugger.js:491: return %DebugGetLoadedScripts();
https://codereview.chromium.org/296953005/diff/40001/src/debug-debugger.js
File src/debug-debugger.js (right):
https://codereview.chromium.org/296953005/diff/40001/src/debug-debugger.js#newcode491
src/debug-debugger.js:491: return %DebugGetLoadedScripts();
On 2014/06/03 08:07:21, yurys wrote:
T
https://codereview.chromium.org/296953005/diff/40001/src/debug-debugger.js
File src/debug-debugger.js (right):
https://codereview.chromium.org/296953005/diff/40001/src/debug-debugger.js#newcode491
src/debug-debugger.js:491: return %DebugGetLoadedScripts();
This change looks wrong to me. By desig
Committed patchset #3 manually as r21477 (presubmit successful).
https://codereview.chromium.org/296953005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/296953005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/296953005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
10 matches
Mail list logo
