[v8-dev] Re: Fix unreachable liveness of unreachable constant-folded branches (issue 22876009)

2013-08-30 Thread jkummerow
Since the issue that's fixed by this CL has reached the stable channel (crbug.com/280333), I've pulled out the actual fix and the regression test in https://codereview.chromium.org/23623009/. We should still land the additional work to avoid generating unreachable code, but that's less urgen

[v8-dev] Re: Fix unreachable liveness of unreachable constant-folded branches (issue 22876009)

2013-08-20 Thread jkummerow
LGTM with comments. https://codereview.chromium.org/22876009/diff/13001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/22876009/diff/13001/src/hydrogen-instructions.h#newcode3393 src/hydrogen-instructions.h:3393: bool SameConstantObject(HCo

[v8-dev] Re: Fix unreachable liveness of unreachable constant-folded branches (issue 22876009)

2013-08-16 Thread mstarzinger
LGTM with a couple of comments. https://codereview.chromium.org/22876009/diff/13001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/22876009/diff/13001/src/hydrogen-instructions.h#newcode3393 src/hydrogen-instructions.h:3393: bool SameConsta