[v8-dev] Re: Flush code faster when doing emergency GCs. (issue 677043002 by erikco...@chromium.org)

2014-10-24 Thread ulan
On 2014/10/24 11:48:02, rmcilroy wrote: On 2014/10/24 11:18:57, ulan wrote: > Hi Erik, > > If I understand correctly, this flushes all flushable code including active > code. This could lead to recompile/flush cycles and could actually increase > memory usage because of fragmentation in code

[v8-dev] Re: Flush code faster when doing emergency GCs. (issue 677043002 by erikco...@chromium.org)

2014-10-24 Thread rmcilroy
Nice, it's always nice when a 2 year old CL comes back :). LGTM, but please wait for Ulan since I don't know the code you are touching in heap-inl.h very well. https://codereview.chromium.org/677043002/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview

[v8-dev] Re: Flush code faster when doing emergency GCs. (issue 677043002 by erikco...@chromium.org)

2014-10-24 Thread rmcilroy
On 2014/10/24 11:18:57, ulan wrote: Hi Erik, If I understand correctly, this flushes all flushable code including active code. This could lead to recompile/flush cycles and could actually increase memory usage because of fragmentation in code space. Would this not happen currently for an

[v8-dev] Re: Flush code faster when doing emergency GCs. (issue 677043002 by erikco...@chromium.org)

2014-10-24 Thread ulan
Hi Erik, If I understand correctly, this flushes all flushable code including active code. This could lead to recompile/flush cycles and could actually increase memory usage because of fragmentation in code space. Is there open bug for this? (or a way to measure improvement) https://codereview.

[v8-dev] Re: Flush code faster when doing emergency GCs. (issue 677043002 by erikco...@chromium.org)

2014-10-24 Thread erikcorry
This is a revival of https://codereview.chromium.org/10933124/ from 2 years ago. https://codereview.chromium.org/677043002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8