[v8-dev] Re: Generalize builtins inlining flag to allow forced inlining of any function (issue 1140743004 by da...@chromium.org)

2015-05-20 Thread 'I haz the power ' via codereview.chromium.org
Patchset 3 (id:??) landed as https://crrev.com/218e101297dc21f674499731b7119e339ca157e1 Cr-Commit-Position: refs/heads/master@{#28510} https://codereview.chromium.org/1140743004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Generalize builtins inlining flag to allow forced inlining of any function (issue 1140743004 by da...@chromium.org)

2015-05-20 Thread commit-bot
Committed patchset #3 (id:40001) https://codereview.chromium.org/1140743004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Generalize builtins inlining flag to allow forced inlining of any function (issue 1140743004 by da...@chromium.org)

2015-05-20 Thread danno
Feedback addressed https://codereview.chromium.org/1140743004/diff/1/src/compiler/js-inlining.cc File src/compiler/js-inlining.cc (right): https://codereview.chromium.org/1140743004/diff/1/src/compiler/js-inlining.cc#newcode298 src/compiler/js-inlining.cc:298: if (mode_ == kBuiltinsInlining &&

[v8-dev] Re: Generalize builtins inlining flag to allow forced inlining of any function (issue 1140743004 by da...@chromium.org)

2015-05-20 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140743004/40001 https://codereview.chromium.org/1140743004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscr

[v8-dev] Re: Generalize builtins inlining flag to allow forced inlining of any function (issue 1140743004 by da...@chromium.org)

2015-05-20 Thread mstarzinger
LGTM with nits. https://codereview.chromium.org/1140743004/diff/1/src/compiler/js-inlining.cc File src/compiler/js-inlining.cc (right): https://codereview.chromium.org/1140743004/diff/1/src/compiler/js-inlining.cc#newcode298 src/compiler/js-inlining.cc:298: if (mode_ == kBuiltinsInlining && !fu