I have addressed all the comments. Now I will split this CL into two as Mads
suggested: one dealing with registers/smis improvements, another dealing
with
ICs.
http://codereview.chromium.org/551093/diff/1/3
File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/551093/diff/1/3
First batch of comments.
We should probably measure the code size increase for the extra stubs types
on
real apps.
http://codereview.chromium.org/551093/diff/3002/3012
File src/debug.cc (right):
http://codereview.chromium.org/551093/diff/3002/3012#newcode129
src/debug.cc:129: && code->kind
I looked at parts of this.
I worry that there are too many different stubs and that we will get a stub
number explosion. Can we consolidate some of them and still get most of the
performance benefit?
http://codereview.chromium.org/551093/diff/1/3
File src/ia32/codegen-ia32.cc (right):
http://
http://codereview.chromium.org/551093
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev