[v8-dev] Re: Initial steps for moving code onto Map (issue 237143004)

2014-04-14 Thread verwaest
Committed patchset #1 manually as r20736 (presubmit successful). https://codereview.chromium.org/237143004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] Re: Initial steps for moving code onto Map (issue 237143004)

2014-04-14 Thread verwaest
As discussed offline, I don't really want to pollute all our code with , isolate, especially when it's not measurable. I'm going to leave as is. https://codereview.chromium.org/237143004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received t

[v8-dev] Re: Initial steps for moving code onto Map (issue 237143004)

2014-04-14 Thread ishell
lgtm with nits: https://codereview.chromium.org/237143004/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/237143004/diff/1/src/objects.cc#newcode4423 src/objects.cc:4423: Isolate* isolate = cache->GetIsolate(); While we are here: lets get isolate only once in