[v8-dev] Re: Introduce SmiValuesAre31Bits and SmiValuesAre32Bits global predicate functions (issue 22350005)

2013-08-27 Thread haitao . feng
Committed patchset #2 manually as r16365 (presubmit successful). https://codereview.chromium.org/22350005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Introduce SmiValuesAre31Bits and SmiValuesAre32Bits global predicate functions (issue 22350005)

2013-08-20 Thread haitao . feng
Thanks for the review. Sure I will wait for that. https://codereview.chromium.org/22350005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe fro

[v8-dev] Re: Introduce SmiValuesAre31Bits and SmiValuesAre32Bits global predicate functions (issue 22350005)

2013-08-19 Thread danno
lgtm, but please wait to land until the tree is no longer throttled https://chromiumcodereview.appspot.com/22350005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" gro

[v8-dev] Re: Introduce SmiValuesAre31Bits and SmiValuesAre32Bits global predicate functions (issue 22350005)

2013-08-13 Thread haitao . feng
danno, thanks for the review. I will commit this when the tree is open. https://codereview.chromium.org/22350005/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/22350005/diff/1/include/v8.h#newcode5454 include/v8.h:5454: V8_INLINE(static bool SmiValuesAre32Bits())

[v8-dev] Re: Introduce SmiValuesAre31Bits and SmiValuesAre32Bits global predicate functions (issue 22350005)

2013-08-13 Thread danno
I like this incremental step, please just change where the predicates are defined as described below and then I think the CL will be ready. https://chromiumcodereview.appspot.com/22350005/diff/1/include/v8.h File include/v8.h (right): https://chromiumcodereview.appspot.com/22350005/diff/1/inclu