[v8-dev] Re: JSON.stringify improvement. Fast case in C++ for string arrays. (issue7077004)

2011-05-26 Thread lrn
LGTM http://codereview.chromium.org/7077004/diff/3001/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7077004/diff/3001/src/runtime.cc#newcode3538 src/runtime.cc:3538: ASSERT(2 <= radix && radix <= 36); ASSERT -> RUNTIME_ASSERT http://codereview.chromium.org/7077004/

[v8-dev] Re: JSON.stringify improvement. Fast case in C++ for string arrays. (issue7077004)

2011-05-26 Thread sandholm
http://codereview.chromium.org/7077004/diff/3001/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7077004/diff/3001/src/runtime.cc#newcode3538 src/runtime.cc:3538: ASSERT(2 <= radix && radix <= 36); On 2011/05/26 11:24:43, Lasse Reichstein wrote: ASSERT -> RUNTIME_ASSE