https://codereview.chromium.org/1023153002/diff/1/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/1023153002/diff/1/src/heap/gc-idle-time-handler.cc#newcode160
src/heap/gc-idle-time-handler.cc:160: last_mark_compact_time +
https://codereview.chromium.org/1023153002/diff/1/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/1023153002/diff/1/src/heap/gc-idle-time-handler.cc#newcode160
src/heap/gc-idle-time-handler.cc:160: last_mark_compact_time +
I think we'll take another look at it Monday.
One idea is to add up the unutilized idle times and use those to measure how
much time has gone. That way any test that controls the idle notifications
is
still deterministic on varying devices and system loads.
I'd like to get rid of the idea
lgtm
just to clarify, if the system is fully idle, we'll attempt a MC every
second,
right?
https://codereview.chromium.org/1023153002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the
In terms of testability it's not great to add more time-based decision
making.
It would be good to get to a place where the test harness could call the
idle
API and there was no other time based decision making.
looks good overall - couple of questions though.
https://codereview.chromium.org/1023153002/diff/80001/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/1023153002/diff/80001/src/heap/gc-idle-time-handler.cc#newcode162
I agree, this is getting too complicated. We should have something simple
(modulo the unfortunate hack).
The system should serve two purposes:
1) Perform garbage collection during idle time when we are close to a full
new
or old generation.
2) Reduce memory footprint.
1) is easy and very
