[v8-dev] Re: MIPS: Fix [de]serialize problem of root objects. (issue 492303004 by balazs.kilv...@imgtec.com)

2014-08-28 Thread balazs . kilvady
PTAL. Could a v8 team member review? https://codereview.chromium.org/492303004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group

[v8-dev] Re: MIPS: Fix [de]serialize problem of root objects. (issue 492303004 by balazs.kilv...@imgtec.com)

2014-08-28 Thread yangguo
On 2014/08/28 09:45:19, balazs.kilvady wrote: PTAL. Could a v8 team member review? Why is it necessary for MIPS? Would the same also apply for ARM? https://codereview.chromium.org/492303004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You

[v8-dev] Re: MIPS: Fix [de]serialize problem of root objects. (issue 492303004 by balazs.kilv...@imgtec.com)

2014-08-28 Thread balazs . kilvady
On 2014/08/28 09:48:54, Yang wrote: On 2014/08/28 09:45:19, balazs.kilvady wrote: PTAL. Could a v8 team member review? Why is it necessary for MIPS? Would the same also apply for ARM? Thank you for the quick review. The same has done for arm/V8_OOL_CONSTANT_POOL arches in r r23242. Wee

[v8-dev] Re: MIPS: Fix [de]serialize problem of root objects. (issue 492303004 by balazs.kilv...@imgtec.com)

2014-08-28 Thread yangguo
On 2014/08/28 09:54:43, balazs.kilvady wrote: On 2014/08/28 09:48:54, Yang wrote: On 2014/08/28 09:45:19, balazs.kilvady wrote: PTAL. Could a v8 team member review? Why is it necessary for MIPS? Would the same also apply for ARM? Thank you for the quick review. The same has done for

[v8-dev] Re: MIPS: Fix [de]serialize problem of root objects. (issue 492303004 by balazs.kilv...@imgtec.com)

2014-08-28 Thread rmcilroy
On 2014/08/28 10:38:15, Yang wrote: On 2014/08/28 09:54:43, balazs.kilvady wrote: On 2014/08/28 09:48:54, Yang wrote: On 2014/08/28 09:45:19, balazs.kilvady wrote: PTAL. Could a v8 team member review? Why is it necessary for MIPS? Would the same also apply for ARM? Thank you for the

[v8-dev] Re: MIPS: Fix [de]serialize problem of root objects. (issue 492303004 by balazs.kilv...@imgtec.com)

2014-08-28 Thread yangguo
On 2014/08/28 10:47:08, rmcilroy wrote: On 2014/08/28 10:38:15, Yang wrote: On 2014/08/28 09:54:43, balazs.kilvady wrote: On 2014/08/28 09:48:54, Yang wrote: On 2014/08/28 09:45:19, balazs.kilvady wrote: PTAL. Could a v8 team member review? Why is it necessary for MIPS? Would the

[v8-dev] Re: MIPS: Fix [de]serialize problem of root objects. (issue 492303004 by balazs.kilv...@imgtec.com)

2014-08-28 Thread balazs . kilvady
On 2014/08/28 10:50:17, Yang wrote: On 2014/08/28 10:47:08, rmcilroy wrote: On 2014/08/28 10:38:15, Yang wrote: On 2014/08/28 09:54:43, balazs.kilvady wrote: On 2014/08/28 09:48:54, Yang wrote: On 2014/08/28 09:45:19, balazs.kilvady wrote: PTAL. Could a v8 team member review?

[v8-dev] Re: MIPS: Fix [de]serialize problem of root objects. (issue 492303004 by balazs.kilv...@imgtec.com)

2014-08-28 Thread yangguo
On 2014/08/28 11:14:04, balazs.kilvady wrote: On 2014/08/28 10:50:17, Yang wrote: On 2014/08/28 10:47:08, rmcilroy wrote: On 2014/08/28 10:38:15, Yang wrote: On 2014/08/28 09:54:43, balazs.kilvady wrote: On 2014/08/28 09:48:54, Yang wrote: On 2014/08/28 09:45:19, balazs.kilvady

[v8-dev] Re: MIPS: Fix [de]serialize problem of root objects. (issue 492303004 by balazs.kilv...@imgtec.com)

2014-08-28 Thread balazs . kilvady
Committed patchset #2 manually as r23487. https://codereview.chromium.org/492303004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this