Ok
http://codereview.chromium.org/115021
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
http://codereview.chromium.org/115021/diff/1011/6
File src/x64/assembler-x64.h (right):
http://codereview.chromium.org/115021/diff/1011/6#newcode35
Line 35: // A light-weight X64 Assembler.
On 2009/05/06 11:32:12, Kevin Millikin wrote:
> "light-weight" => "lightweight"
Done.
http://codereview.
http://codereview.chromium.org/115021/diff/1011/6
File src/x64/assembler-x64.h (right):
http://codereview.chromium.org/115021/diff/1011/6#newcode35
Line 35: // A light-weight X64 Assembler.
"light-weight" => "lightweight"
http://codereview.chromium.org/115021/diff/1011/6#newcode64
Line 64: // k
OK with the guards properly fixed.
http://codereview.chromium.org/115021/diff/1011/7
File src/x64/assembler-x64-inl.h (right):
http://codereview.chromium.org/115021/diff/1011/7#newcode29
Line 29: #define V8_X64_ASSEMBLER_IA32_INL_H_
this still says IA32, it should be X64
http://codereview.chro
http://codereview.chromium.org/115021/diff/1005/1007
File src/x64/assembler-x64-inl.h (right):
http://codereview.chromium.org/115021/diff/1005/1007#newcode27
Line 27:
On 2009/05/06 10:10:38, Dean McNamee wrote:
> we should have guards even on -inl.h files.
Done.
http://codereview.chromium.org/
LGTM, with Dean's comments. This is a good step towards getting arch=x64
to compile.
http://codereview.chromium.org/115021/diff/1005/1006
File src/x64/assembler-x64.h (right):
http://codereview.chromium.org/115021/diff/1005/1006#newcode76
Line 76: //return 1 << code_;
I disagree.
If code ex
http://codereview.chromium.org/115021/diff/1005/1007
File src/x64/assembler-x64-inl.h (right):
http://codereview.chromium.org/115021/diff/1005/1007#newcode27
Line 27:
we should have guards even on -inl.h files.
http://codereview.chromium.org/115021/diff/1005/1007#newcode36
Line 36: return 0;
re
