On 2010/01/25 13:01:40, Søren Gjesse wrote:
LGTM with a style comment:
In the V8 code base we always have explicit check against NULL, so
while (HeapObject* obj = it.next()) {
needs to be
while ((HeapObject* obj = it.next()) != NULL) {
As the while with != NULL check requires
Sure, will fix. Thanks a lot for review.
yours,
anton.
On Mon, Jan 25, 2010 at 4:01 PM, wrote:
> LGTM with a style comment:
>
> In the V8 code base we always have explicit check against NULL, so
>
> while (HeapObject* obj = it.next()) {
>
> needs to be
>
> while ((HeapObject* obj = it.next()
LGTM with a style comment:
In the V8 code base we always have explicit check against NULL, so
while (HeapObject* obj = it.next()) {
needs to be
while ((HeapObject* obj = it.next()) != NULL) {
http://codereview.chromium.org/555072
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
