[v8-dev] Re: Move OS/compiler/feature detection to public v8config.h header. (issue 23248006)

2014-12-01 Thread thakis
https://codereview.chromium.org/23248006/diff/11001/include/v8config.h File include/v8config.h (right): https://codereview.chromium.org/23248006/diff/11001/include/v8config.h#newcode118 include/v8config.h:118: #if defined(__clang__) On 2014/12/01 18:02:00, Benedikt Meurer wrote: So you're talki

[v8-dev] Re: Move OS/compiler/feature detection to public v8config.h header. (issue 23248006)

2014-12-01 Thread thakis
https://codereview.chromium.org/23248006/diff/11001/include/v8config.h File include/v8config.h (right): https://codereview.chromium.org/23248006/diff/11001/include/v8config.h#newcode118 include/v8config.h:118: #if defined(__clang__) On 2014/12/01 18:02:00, Benedikt Meurer wrote: So you're talki

[v8-dev] Re: Move OS/compiler/feature detection to public v8config.h header. (issue 23248006)

2014-12-01 Thread bmeurer
Reviewers: Sven Panne, Jakob, danno, Nico, https://codereview.chromium.org/23248006/diff/11001/include/v8config.h File include/v8config.h (right): https://codereview.chromium.org/23248006/diff/11001/include/v8config.h#newcode118 include/v8config.h:118: #if defined(__clang__) So you're talking a

[v8-dev] Re: Move OS/compiler/feature detection to public v8config.h header. (issue 23248006)

2014-11-26 Thread thakis
https://codereview.chromium.org/23248006/diff/11001/include/v8config.h File include/v8config.h (right): https://codereview.chromium.org/23248006/diff/11001/include/v8config.h#newcode118 include/v8config.h:118: #if defined(__clang__) This doesn't look like a good approach to me. Clang tries to lo

[v8-dev] Re: Move OS/compiler/feature detection to public v8config.h header. (issue 23248006)

2013-08-23 Thread bmeurer
Committed patchset #3 manually as r16281. https://codereview.chromium.org/23248006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this gro

[v8-dev] Re: Move OS/compiler/feature detection to public v8config.h header. (issue 23248006)

2013-08-23 Thread svenpanne
lgtm https://codereview.chromium.org/23248006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i