Still lgtm, thanks!
https://codereview.chromium.org/1325983002/diff/40001/src/interpreter/bytecodes.cc
File src/interpreter/bytecodes.cc (right):
https://codereview.chromium.org/1325983002/diff/40001/src/interpreter/bytecodes.cc#newcode183
src/interpreter/bytecodes.cc:183:
Committed patchset #5 (id:80001)
https://codereview.chromium.org/1325983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Looks much cleaner, thanks. Lgtm once comments are addressed.
https://codereview.chromium.org/1325983002/diff/40001/src/interpreter/bytecodes.cc
File src/interpreter/bytecodes.cc (right):
https://codereview.chromium.org/1325983002/diff/40001/src/interpreter/bytecodes.cc#newcode173
Patchset 5 (id:??) landed as
https://crrev.com/22983f71f95140d75faf8d5d0b0b7fdd2624e675
Cr-Commit-Position: refs/heads/master@{#30549}
https://codereview.chromium.org/1325983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1325983002/80001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1325983002/80001
https://codereview.chromium.org/1325983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Looks good. My main suggestion is whether we can move Register class to
bytecodes.h to keep all the logic together a bit more.
https://codereview.chromium.org/1325983002/diff/20001/src/interpreter/bytecode-array-builder.h
File src/interpreter/bytecode-array-builder.h (right):
Thanks. Exposed Register in bytecodes.h. I didn't like it when writing
PS1/2,
but it is a bit cleaner.
https://codereview.chromium.org/1325983002/diff/20001/src/interpreter/bytecode-array-builder.h
File src/interpreter/bytecode-array-builder.h (right):
