[v8-dev] Re: Provide a helper to generate multiple Lithium instructions for one Hydrogen instruction. (issue 296993002)

2014-05-23 Thread alexandre . rames
Committed patchset #2 manually as r21465 (presubmit successful). https://codereview.chromium.org/296993002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] Re: Provide a helper to generate multiple Lithium instructions for one Hydrogen instruction. (issue 296993002)

2014-05-22 Thread alexandre . rames
On 2014/05/22 14:56:20, Jakob wrote: Please don't forget to upload the updated patch set for future reference. Just did. I was waiting for our internal green flag. https://codereview.chromium.org/296993002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-de

[v8-dev] Re: Provide a helper to generate multiple Lithium instructions for one Hydrogen instruction. (issue 296993002)

2014-05-22 Thread jkummerow
Please don't forget to upload the updated patch set for future reference. https://codereview.chromium.org/296993002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" gro

[v8-dev] Re: Provide a helper to generate multiple Lithium instructions for one Hydrogen instruction. (issue 296993002)

2014-05-22 Thread ulan
lgtm https://codereview.chromium.org/296993002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Provide a helper to generate multiple Lithium instructions for one Hydrogen instruction. (issue 296993002)

2014-05-22 Thread alexandre . rames
Yes, all platforms have the same changes. https://codereview.chromium.org/296993002/diff/1/src/arm/lithium-arm.cc File src/arm/lithium-arm.cc (right): https://codereview.chromium.org/296993002/diff/1/src/arm/lithium-arm.cc#newcode843 src/arm/lithium-arm.cc:843: void LChunkBuilder::CheckAndAddIn

[v8-dev] Re: Provide a helper to generate multiple Lithium instructions for one Hydrogen instruction. (issue 296993002)

2014-05-22 Thread jkummerow
LGTM with comment. I've only looked at arm, I assume other platforms are identical. https://codereview.chromium.org/296993002/diff/1/src/arm/lithium-arm.cc File src/arm/lithium-arm.cc (right): https://codereview.chromium.org/296993002/diff/1/src/arm/lithium-arm.cc#newcode843 src/arm/lithium-ar