[v8-dev] Re: Refactor mjsunit/fuzz-natives-* into a separate test suite. (issue 252143002)

2014-05-07 Thread jkummerow
Committed patchset #3 manually as r21190 (tree was closed). https://codereview.chromium.org/252143002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubs

[v8-dev] Re: Refactor mjsunit/fuzz-natives-* into a separate test suite. (issue 252143002)

2014-05-02 Thread machenbach
lgtm https://codereview.chromium.org/252143002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it

[v8-dev] Re: Refactor mjsunit/fuzz-natives-* into a separate test suite. (issue 252143002)

2014-04-30 Thread jkummerow
Addressed the nits. Since the code in base.js is taken from the original mjsunit/fuzz-natives* tests, I'd prefer to just keep the logic we have for now, unless there's a concrete reason to change something. I've added a header comment to sum up our feelings :-) https://codereview.chromium.or

[v8-dev] Re: Refactor mjsunit/fuzz-natives-* into a separate test suite. (issue 252143002)

2014-04-30 Thread machenbach
LGTM as discussed offline, keeping the c/p issues and improvement suggestions from the original test case for future CLs. https://codereview.chromium.org/252143002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because y

[v8-dev] Re: Refactor mjsunit/fuzz-natives-* into a separate test suite. (issue 252143002)

2014-04-29 Thread machenbach
https://codereview.chromium.org/252143002/diff/20001/test/fuzz-natives/base.js File test/fuzz-natives/base.js (right): https://codereview.chromium.org/252143002/diff/20001/test/fuzz-natives/base.js#newcode32 test/fuzz-natives/base.js:32: return new Function(args.join(", "), args.join(", ") == ar