Committed patchset #12 manually as r18466 (presubmit successful).
https://codereview.chromium.org/96083005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Thanks, Toon. 32bit perf appeared fine yesterday. I'll verify all platforms
today. Addressed your comment and uploaded MIPs platform.
--Michael
https://codereview.chromium.org/96083005/diff/210001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/96083005/diff/210001/s
LGTM with 1 comment. Make sure to check performance though.
https://codereview.chromium.org/96083005/diff/210001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/96083005/diff/210001/src/objects.cc#newcode10868
src/objects.cc:10868: if (!needs_extended_extra_ic_state(
Whew. PTAL.
https://codereview.chromium.org/96083005/diff/160001/src/disassembler.cc
File src/disassembler.cc (right):
https://codereview.chromium.org/96083005/diff/160001/src/disassembler.cc#newcode240
src/disassembler.cc:240: if (!code->needs_extended_extra_ic_state(kind)
&&
On 2013/12/04 18:
I like this change! Looking good. Added comments and nitty nits.
https://codereview.chromium.org/96083005/diff/160001/src/disassembler.cc
File src/disassembler.cc (right):
https://codereview.chromium.org/96083005/diff/160001/src/disassembler.cc#newcode240
src/disassembler.cc:240: if (!code->nee
Hi Toon,
Okay, per your verbal comments, I've moved loads and stores out of the
builtins
into the stub cache. Thanks!
--Michael
https://codereview.chromium.org/96083005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message beca
Hi Toon,
Thanks for the comments, I've
1) used macros in builtins[.h/.cc] to reduce verbosity.
2) made sure that contextual and strictmode are treated separately. So for
example we can have a StoreIC that is contextual but not strict mode.
3) Added a test where I take call, load and store ics thro
Looking good. More macros / lists would probably reduce some of the code.
Also we probably should keep contextual/strict unlinked: allow both
non-strict+contextual and strict+contextual; even if it's not visible from
javascript.
https://codereview.chromium.org/96083005/diff/60001/src/builtins.c
