I ran Octane locally three times with and without this patch. I measured a
2.3%
regression caused by the patch in CodeLoad. Where do we go from here? I am
having trouble figuring out a clean strategy for avoiding the conditional by
pushing back all the way into the stream, though I can imagine
https://codereview.chromium.org/1295883002/diff/60001/src/scanner.h
File src/scanner.h (right):
https://codereview.chromium.org/1295883002/diff/60001/src/scanner.h#newcode547
src/scanner.h:547: (current_.literal_chars == literal_buffers_[0])
On 2015/08/17 at 18:24:39, adamk wrote:
On
https://codereview.chromium.org/1295883002/diff/60001/src/scanner.h
File src/scanner.h (right):
https://codereview.chromium.org/1295883002/diff/60001/src/scanner.h#newcode547
src/scanner.h:547: (current_.literal_chars == literal_buffers_[0])
On 2015/08/15 00:28:31, adamk wrote:
Why switch to
cc vogelheim@, who might have some insight into evaluating performance
regressions related to CodeLoad.
https://codereview.chromium.org/1295883002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Reviewers: adamk,
Message:
This is currently more of an RFC because of the indeterminate performance
impact. It should not be merged before the 46 branch.
Description:
Sloppy-mode let parsing
This patch makes 'let' a contextual keyword in both strict and sloppy mode.
It behaves as a keyword
Looking good, especially like that the ugliness is mostly contained in the
Scanner. Mostly naming concerns below.
https://codereview.chromium.org/1295883002/diff/60001/src/preparser.h
File src/preparser.h (right):
Actually, the performance runs didn't show a big regression: On
v8_linux64_haswell_perf_try, CodeLoad was up 0.1, and on
v8_linux32_perf_try,
CodeLoad was down just 0.4%. However, these tests seem to be very volatile.
Does
anyone have an idea for getting more reliable results before
https://codereview.chromium.org/1295883002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it, send
