Committed patchset #4 manually as r21150 (presubmit successful).
https://codereview.chromium.org/254433002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
On 2014/05/03 05:44:42, Toon Verwaest wrote:
Still LGTM. I don't see a security issue with this patch.
Good. I didn't either, but thought another pair of eyes was good given last
week...
https://codereview.chromium.org/254433002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups
Still LGTM. I don't see a security issue with this patch.
https://codereview.chromium.org/254433002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscr
On 2014/05/02 18:16:02, adamk wrote:
Now that Object.observe never tries to hash the global proxy, this change
goes
back to being simple (basically just reverting the
WeakCollectionGetForObserve
stuff).
Landing, since the rest of the patch is unchanged.
Actually, not landing, since we mi
Now that Object.observe never tries to hash the global proxy, this change
goes
back to being simple (basically just reverting the
WeakCollectionGetForObserve
stuff).
Landing, since the rest of the patch is unchanged.
https://codereview.chromium.org/254433002/
--
--
v8-dev mailing list
v8-de
lgtm, thanks!
https://codereview.chromium.org/254433002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving email
https://codereview.chromium.org/254433002/diff/20001/src/object-observe.js
File src/object-observe.js (right):
https://codereview.chromium.org/254433002/diff/20001/src/object-observe.js#newcode83
src/object-observe.js:83: key = %UnwrapGlobalProxy(key);
On 2014/04/28 14:32:50, Toon Verwaest wrote
https://codereview.chromium.org/254433002/diff/20001/src/object-observe.js
File src/object-observe.js (right):
https://codereview.chromium.org/254433002/diff/20001/src/object-observe.js#newcode83
src/object-observe.js:83: key = %UnwrapGlobalProxy(key);
I'd strongly prefer merging UnwrapGlobalPro
